Title: [174998] trunk/Tools
Revision
174998
Author
[email protected]
Date
2014-10-21 14:13:56 -0700 (Tue, 21 Oct 2014)

Log Message

[Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
https://bugs.webkit.org/show_bug.cgi?id=137932

Reviewed by Simon Fraser.

This is the first step in moving over to native Windows rendering for our layout tests.
Once this change lands, approximately 300 tests will start failing on Windows. I will
rebaseline these changes against our test hardware and update this bug with the
commits related to that work.

* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
we use native Windows drawing style.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (174997 => 174998)


--- trunk/Tools/ChangeLog	2014-10-21 20:43:18 UTC (rev 174997)
+++ trunk/Tools/ChangeLog	2014-10-21 21:13:56 UTC (rev 174998)
@@ -1,3 +1,19 @@
+2014-10-21  Brent Fulgham  <[email protected]>
+
+        [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
+        https://bugs.webkit.org/show_bug.cgi?id=137932
+
+        Reviewed by Simon Fraser.
+
+        This is the first step in moving over to native Windows rendering for our layout tests.
+        Once this change lands, approximately 300 tests will start failing on Windows. I will
+        rebaseline these changes against our test hardware and update this bug with the
+        commits related to that work.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
+        we use native Windows drawing style.
+
 2014-10-21  Dániel Bátyai  <[email protected]>
 
         Fix FTL Native Inlining for EFL

Modified: trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp (174997 => 174998)


--- trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2014-10-21 20:43:18 UTC (rev 174997)
+++ trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp	2014-10-21 21:13:56 UTC (rev 174998)
@@ -829,7 +829,7 @@
         prefsPrivate->setAuthorAndUserStylesEnabled(TRUE);
         prefsPrivate->setDeveloperExtrasEnabled(FALSE);
         prefsPrivate->setExperimentalNotificationsEnabled(TRUE);
-        prefsPrivate->setShouldPaintNativeControls(FALSE); // FIXME - need to make DRT pass with Windows native controls <http://bugs.webkit.org/show_bug.cgi?id=25592>
+        prefsPrivate->setShouldPaintNativeControls(TRUE); // FIXME - need to make DRT pass with Windows native controls <http://bugs.webkit.org/show_bug.cgi?id=25592>
         prefsPrivate->setJavaScriptCanAccessClipboard(TRUE);
         prefsPrivate->setXSSAuditorEnabled(FALSE);
         prefsPrivate->setOfflineWebApplicationCacheEnabled(TRUE);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to