Title: [175083] trunk/Source/WebCore
- Revision
- 175083
- Author
- [email protected]
- Date
- 2014-10-22 20:49:41 -0700 (Wed, 22 Oct 2014)
Log Message
REGRESSION(r175000): Crash in SourceBufferPrivateAVFObjC::destroyParser()
https://bugs.webkit.org/show_bug.cgi?id=137990
Reviewed by Alexey Proskuryakov.
NULL-check m_mediaSource before using.
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::destroyParser):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (175082 => 175083)
--- trunk/Source/WebCore/ChangeLog 2014-10-23 02:54:24 UTC (rev 175082)
+++ trunk/Source/WebCore/ChangeLog 2014-10-23 03:49:41 UTC (rev 175083)
@@ -1,3 +1,15 @@
+2014-10-22 Jer Noble <[email protected]>
+
+ REGRESSION(r175000): Crash in SourceBufferPrivateAVFObjC::destroyParser()
+ https://bugs.webkit.org/show_bug.cgi?id=137990
+
+ Reviewed by Alexey Proskuryakov.
+
+ NULL-check m_mediaSource before using.
+
+ * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
+ (WebCore::SourceBufferPrivateAVFObjC::destroyParser):
+
2014-10-22 Said Abou-Hallawa <[email protected]>
SVG loaded through html <img> can't request to load any external resources.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm (175082 => 175083)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm 2014-10-23 02:54:24 UTC (rev 175082)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm 2014-10-23 03:49:41 UTC (rev 175083)
@@ -783,7 +783,7 @@
void SourceBufferPrivateAVFObjC::destroyParser()
{
- if (m_mediaSource->player()->hasStreamSession())
+ if (m_mediaSource && m_mediaSource->player()->hasStreamSession())
[m_mediaSource->player()->streamSession() removeStreamDataParser:m_parser.get()];
[m_delegate invalidate];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
