Title: [175168] trunk/Source/WebCore
- Revision
- 175168
- Author
- [email protected]
- Date
- 2014-10-24 11:13:30 -0700 (Fri, 24 Oct 2014)
Log Message
Make ScriptWrappable's destructor protected instead of public
https://bugs.webkit.org/show_bug.cgi?id=138037
Reviewed by Andreas Kling.
Make ScriptWrappable's destructor protected instead of public as it is
not virtual and this class is subclassed a lot.
No new tests, no behavior change.
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::~ScriptWrappable):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (175167 => 175168)
--- trunk/Source/WebCore/ChangeLog 2014-10-24 17:25:24 UTC (rev 175167)
+++ trunk/Source/WebCore/ChangeLog 2014-10-24 18:13:30 UTC (rev 175168)
@@ -1,3 +1,18 @@
+2014-10-24 Chris Dumez <[email protected]>
+
+ Make ScriptWrappable's destructor protected instead of public
+ https://bugs.webkit.org/show_bug.cgi?id=138037
+
+ Reviewed by Andreas Kling.
+
+ Make ScriptWrappable's destructor protected instead of public as it is
+ not virtual and this class is subclassed a lot.
+
+ No new tests, no behavior change.
+
+ * bindings/js/ScriptWrappable.h:
+ (WebCore::ScriptWrappable::~ScriptWrappable):
+
2014-10-23 Carlos Garcia Campos <[email protected]>
[GTK][Cairo] Remove GTK dependency of WidgetBackingStoreGtkX11
Modified: trunk/Source/WebCore/bindings/js/ScriptWrappable.h (175167 => 175168)
--- trunk/Source/WebCore/bindings/js/ScriptWrappable.h 2014-10-24 17:25:24 UTC (rev 175167)
+++ trunk/Source/WebCore/bindings/js/ScriptWrappable.h 2014-10-24 18:13:30 UTC (rev 175168)
@@ -48,6 +48,9 @@
void setWrapper(JSDOMWrapper*, JSC::WeakHandleOwner*, void*);
void clearWrapper(JSDOMWrapper*);
+protected:
+ ~ScriptWrappable() { }
+
private:
JSC::Weak<JSDOMWrapper> m_wrapper;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
