Title: [175174] trunk/Source/WebCore
- Revision
- 175174
- Author
- [email protected]
- Date
- 2014-10-24 13:12:44 -0700 (Fri, 24 Oct 2014)
Log Message
[Mac] Use NSString API in QuickLookMac::computeNeedsQuickLookResourceCachingQuirks()
https://bugs.webkit.org/show_bug.cgi?id=138039
Reviewed by Darin Adler.
Use NSString API in QuickLookMac::computeNeedsQuickLookResourceCachingQuirks()
for case-insensitive string comparison instead of converting to UTF-8 and then
using strcasecmp().
No new tests, no behavior change.
* platform/mac/QuickLookMac.mm:
(WebCore::QuickLookMac::computeNeedsQuickLookResourceCachingQuirks):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (175173 => 175174)
--- trunk/Source/WebCore/ChangeLog 2014-10-24 19:28:59 UTC (rev 175173)
+++ trunk/Source/WebCore/ChangeLog 2014-10-24 20:12:44 UTC (rev 175174)
@@ -1,5 +1,21 @@
2014-10-24 Chris Dumez <[email protected]>
+ [Mac] Use NSString API in QuickLookMac::computeNeedsQuickLookResourceCachingQuirks()
+ https://bugs.webkit.org/show_bug.cgi?id=138039
+
+ Reviewed by Darin Adler.
+
+ Use NSString API in QuickLookMac::computeNeedsQuickLookResourceCachingQuirks()
+ for case-insensitive string comparison instead of converting to UTF-8 and then
+ using strcasecmp().
+
+ No new tests, no behavior change.
+
+ * platform/mac/QuickLookMac.mm:
+ (WebCore::QuickLookMac::computeNeedsQuickLookResourceCachingQuirks):
+
+2014-10-24 Chris Dumez <[email protected]>
+
Avoid unnecessary NSURLRequest copies in ResourceRequest::doUpdatePlatformRequest() / doUpdatePlatformHTTPBody()
https://bugs.webkit.org/show_bug.cgi?id=138049
Modified: trunk/Source/WebCore/platform/mac/QuickLookMac.mm (175173 => 175174)
--- trunk/Source/WebCore/platform/mac/QuickLookMac.mm 2014-10-24 19:28:59 UTC (rev 175173)
+++ trunk/Source/WebCore/platform/mac/QuickLookMac.mm 2014-10-24 20:12:44 UTC (rev 175174)
@@ -41,8 +41,8 @@
return false;
for (NSBundle *bundle in frameworks) {
- const char* bundleID = [[bundle bundleIdentifier] UTF8String];
- if (bundleID && !strcasecmp(bundleID, "com.apple.QuickLookUIFramework"))
+ NSString *bundleID = [bundle bundleIdentifier];
+ if (bundleID && [bundleID caseInsensitiveCompare:@"com.apple.QuickLookUIFramework"] == NSOrderedSame)
return true;
}
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
