[webkit-changes] [175338] trunk/Source/WebKit2

Wed, 29 Oct 2014 12:08:31 -0700

Title: [175338] trunk/Source/WebKit2
Revision
175338
Author
[email protected]
Date
2014-10-29 12:08:14 -0700 (Wed, 29 Oct 2014)

Log Message

Rename WebPageProxy::activeActionMenuHitTestResult to lastMouseMoveHitTestResult
https://bugs.webkit.org/show_bug.cgi?id=138137
<rdar://problem/18798257>

Reviewed by Anders Carlsson.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::mouseDidMoveOverElement):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::lastMouseMoveHitTestResult):
(WebKit::WebPageProxy::activeActionMenuHitTestResult): Deleted.
* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForLink]):
(-[WKActionMenuController _openURLFromActionMenu:]):
(-[WKActionMenuController _addToReadingListFromActionMenu:]):
(-[WKActionMenuController _quickLookURLFromActionMenu:]):
(-[WKActionMenuController _saveImageToDownloads:]):
(imageForResource:name::if):
(-[WKActionMenuController _updateActionMenuItems]):
Rename to the more accurate and general name.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (175337 => 175338)


--- trunk/Source/WebKit2/ChangeLog	2014-10-29 19:01:27 UTC (rev 175337)
+++ trunk/Source/WebKit2/ChangeLog	2014-10-29 19:08:14 UTC (rev 175338)
@@ -1,5 +1,28 @@
 2014-10-29  Tim Horton  <[email protected]>
 
+        Rename WebPageProxy::activeActionMenuHitTestResult to lastMouseMoveHitTestResult
+        https://bugs.webkit.org/show_bug.cgi?id=138137
+        <rdar://problem/18798257>
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::mouseDidMoveOverElement):
+        * UIProcess/WebPageProxy.h:
+        (WebKit::WebPageProxy::lastMouseMoveHitTestResult):
+        (WebKit::WebPageProxy::activeActionMenuHitTestResult): Deleted.
+        * UIProcess/mac/WKActionMenuController.mm:
+        (-[WKActionMenuController _defaultMenuItemsForLink]):
+        (-[WKActionMenuController _openURLFromActionMenu:]):
+        (-[WKActionMenuController _addToReadingListFromActionMenu:]):
+        (-[WKActionMenuController _quickLookURLFromActionMenu:]):
+        (-[WKActionMenuController _saveImageToDownloads:]):
+        (imageForResource:name::if):
+        (-[WKActionMenuController _updateActionMenuItems]):
+        Rename to the more accurate and general name.
+
+2014-10-29  Tim Horton  <[email protected]>
+
         Implement action menus for data detected items
         https://bugs.webkit.org/show_bug.cgi?id=138178
         <rdar://problem/18709436>

Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (175337 => 175338)


--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-10-29 19:01:27 UTC (rev 175337)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-10-29 19:08:14 UTC (rev 175338)
@@ -3111,7 +3111,7 @@
     if (!decoder.decode(messageDecoder))
         return;
 
-    m_activeActionMenuHitTestResult = WebHitTestResult::create(hitTestResultData);
+    m_lastMouseMoveHitTestResult = WebHitTestResult::create(hitTestResultData);
 
     WebEvent::Modifiers modifiers = static_cast<WebEvent::Modifiers>(opaqueModifiers);

Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.h (175337 => 175338)


--- trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2014-10-29 19:01:27 UTC (rev 175337)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.h	2014-10-29 19:08:14 UTC (rev 175338)
@@ -922,7 +922,7 @@
 #if PLATFORM(MAC)
     void removeNavigationGestureSnapshot();
 
-    WebHitTestResult* activeActionMenuHitTestResult() const { return m_activeActionMenuHitTestResult.get(); }
+    WebHitTestResult* lastMouseMoveHitTestResult() const { return m_lastMouseMoveHitTestResult.get(); }
     void performActionMenuHitTestAtLocation(WebCore::FloatPoint);
 #endif
 
@@ -1383,7 +1383,7 @@
     RefPtr<WebContextMenuProxy> m_activeContextMenu;
     ContextMenuContextData m_activeContextMenuContextData;
 #endif
-    RefPtr<WebHitTestResult> m_activeActionMenuHitTestResult;
+    RefPtr<WebHitTestResult> m_lastMouseMoveHitTestResult;
 
     RefPtr<WebOpenPanelResultListenerProxy> m_openPanelResultListener;
     GeolocationPermissionRequestManagerProxy m_geolocationPermissionRequestManager;

Modified: trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm (175337 => 175338)


--- trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm	2014-10-29 19:01:27 UTC (rev 175337)
+++ trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm	2014-10-29 19:08:14 UTC (rev 175338)
@@ -125,7 +125,7 @@
 
 - (NSArray *)_defaultMenuItemsForLink
 {
-    WebHitTestResult* hitTestResult = _page->activeActionMenuHitTestResult();
+    WebHitTestResult* hitTestResult = _page->lastMouseMoveHitTestResult();
     if (!WebCore::protocolIsInHTTPFamily(hitTestResult->absoluteLinkURL()))
         return @[ ];
 
@@ -138,20 +138,20 @@
 
 - (void)_openURLFromActionMenu:(id)sender
 {
-    WebHitTestResult* hitTestResult = _page->activeActionMenuHitTestResult();
+    WebHitTestResult* hitTestResult = _page->lastMouseMoveHitTestResult();
     [[NSWorkspace sharedWorkspace] openURL:[NSURL _web_URLWithWTFString:hitTestResult->absoluteLinkURL()]];
 }
 
 - (void)_addToReadingListFromActionMenu:(id)sender
 {
-    WebHitTestResult* hitTestResult = _page->activeActionMenuHitTestResult();
+    WebHitTestResult* hitTestResult = _page->lastMouseMoveHitTestResult();
     NSSharingService *service = [NSSharingService sharingServiceNamed:NSSharingServiceNameAddToSafariReadingList];
     [service performWithItems:@[ [NSURL _web_URLWithWTFString:hitTestResult->absoluteLinkURL()] ]];
 }
 
 - (void)_quickLookURLFromActionMenu:(id)sender
 {
-    WebHitTestResult* hitTestResult = _page->activeActionMenuHitTestResult();
+    WebHitTestResult* hitTestResult = _page->lastMouseMoveHitTestResult();
     NSRect itemFrame = [_wkView convertRect:hitTestResult->elementBoundingBox() toView:nil];
     NSSize maximumPreviewSize = NSMakeSize(_wkView.bounds.size.width * 0.75, _wkView.bounds.size.height * 0.75);
 
@@ -202,7 +202,7 @@
 
 - (void)_saveImageToDownloads:(id)sender
 {
-    WebHitTestResult* hitTestResult = _page->activeActionMenuHitTestResult();
+    WebHitTestResult* hitTestResult = _page->lastMouseMoveHitTestResult();
     _page->process().context().download(_page, hitTestResult->absoluteImageURL());
 }
 
@@ -384,7 +384,7 @@
 
 - (NSArray *)_defaultMenuItems
 {
-    if (WebHitTestResult* hitTestResult = _page->activeActionMenuHitTestResult()) {
+    if (WebHitTestResult* hitTestResult = _page->lastMouseMoveHitTestResult()) {
         if (!hitTestResult->absoluteImageURL().isEmpty() && _hitTestResult.image) {
             _type = kWKActionMenuImage;
             return [self _defaultMenuItemsForImage];
@@ -418,9 +418,9 @@
 
     NSArray *menuItems = [self _defaultMenuItems];
     if ([_wkView respondsToSelector:@selector(_actionMenuItemsForHitTestResult:defaultActionMenuItems:)])
-        menuItems = [_wkView _actionMenuItemsForHitTestResult:toAPI(_page->activeActionMenuHitTestResult()) defaultActionMenuItems:menuItems];
+        menuItems = [_wkView _actionMenuItemsForHitTestResult:toAPI(_page->lastMouseMoveHitTestResult()) defaultActionMenuItems:menuItems];
     else
-        menuItems = [_wkView _actionMenuItemsForHitTestResult:toAPI(_page->activeActionMenuHitTestResult()) withType:_type defaultActionMenuItems:menuItems];
+        menuItems = [_wkView _actionMenuItemsForHitTestResult:toAPI(_page->lastMouseMoveHitTestResult()) withType:_type defaultActionMenuItems:menuItems];
 
     for (NSMenuItem *item in menuItems)
         [_wkView.actionMenu addItem:item];

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to