Title: [175451] trunk/Source/WebKit2
Revision
175451
Author
[email protected]
Date
2014-11-01 02:59:09 -0700 (Sat, 01 Nov 2014)

Log Message

REGRESSION(r163656): Remote inspector doesn't work unless preferences change after page initialization
https://bugs.webkit.org/show_bug.cgi?id=138246

Reviewed by Joseph Pecoraro.

The problem is that initializeWebPage() is still using
pageGroup().preferences() instead of m_preferences to check if
developer extras are enabled to enable remote inspection of the page.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage): Use m_preferences
instead of pageGroup().preferences().

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (175450 => 175451)


--- trunk/Source/WebKit2/ChangeLog	2014-11-01 09:55:47 UTC (rev 175450)
+++ trunk/Source/WebKit2/ChangeLog	2014-11-01 09:59:09 UTC (rev 175451)
@@ -1,5 +1,20 @@
 2014-11-01  Carlos Garcia Campos  <[email protected]>
 
+        REGRESSION(r163656): Remote inspector doesn't work unless preferences change after page initialization
+        https://bugs.webkit.org/show_bug.cgi?id=138246
+
+        Reviewed by Joseph Pecoraro.
+
+        The problem is that initializeWebPage() is still using
+        pageGroup().preferences() instead of m_preferences to check if
+        developer extras are enabled to enable remote inspection of the page.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::initializeWebPage): Use m_preferences
+        instead of pageGroup().preferences().
+
+2014-11-01  Carlos Garcia Campos  <[email protected]>
+
         REGRESSION(CMake): Make it possible to build without introspection
         https://bugs.webkit.org/show_bug.cgi?id=138006
 

Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (175450 => 175451)


--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-11-01 09:55:47 UTC (rev 175450)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2014-11-01 09:59:09 UTC (rev 175451)
@@ -639,7 +639,7 @@
 #endif
 
 #if ENABLE(INSPECTOR_SERVER)
-    if (pageGroup().preferences().developerExtrasEnabled())
+    if (m_preferences->developerExtrasEnabled())
         inspector()->enableRemoteInspection();
 #endif
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to