Title: [175504] trunk/LayoutTests
Revision
175504
Author
cdu...@apple.com
Date
2014-11-03 18:23:50 -0800 (Mon, 03 Nov 2014)

Log Message

Fix jquery/manipulation.html flakiness on debug builds
https://bugs.webkit.org/show_bug.cgi?id=138335

Reviewed by Alexey Proskuryakov.

Update jquery's qunit config to not refresh the test results
regularly as this is not useful as part of layout testing.

This was causing qunit to set a timer every 13ms to check if
results should be updated and this timer would sometimes get
throttled after r175441.

* TestExpectations:
* jquery/resources/test/qunit/qunit/qunit.js:
(.):

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (175503 => 175504)


--- trunk/LayoutTests/ChangeLog	2014-11-04 02:08:27 UTC (rev 175503)
+++ trunk/LayoutTests/ChangeLog	2014-11-04 02:23:50 UTC (rev 175504)
@@ -1,3 +1,21 @@
+2014-11-03  Chris Dumez  <cdu...@apple.com>
+
+        Fix jquery/manipulation.html flakiness on debug builds
+        https://bugs.webkit.org/show_bug.cgi?id=138335
+
+        Reviewed by Alexey Proskuryakov.
+
+        Update jquery's qunit config to not refresh the test results
+        regularly as this is not useful as part of layout testing.
+
+        This was causing qunit to set a timer every 13ms to check if
+        results should be updated and this timer would sometimes get
+        throttled after r175441.
+
+        * TestExpectations:
+        * jquery/resources/test/qunit/qunit/qunit.js:
+        (.):
+
 2014-11-03  Joseph Pecoraro  <pecor...@apple.com>
 
         Web Inspector: Show Selector's Specificity

Modified: trunk/LayoutTests/TestExpectations (175503 => 175504)


--- trunk/LayoutTests/TestExpectations	2014-11-04 02:08:27 UTC (rev 175503)
+++ trunk/LayoutTests/TestExpectations	2014-11-04 02:23:50 UTC (rev 175504)
@@ -196,9 +196,6 @@
 webkit.org/b/136754 css3/flexbox/csswg/ttwf-reftest-flex-wrap-reverse.html [ ImageOnlyFailure ]
 webkit.org/b/136754 css3/flexbox/csswg/ttwf-reftest-flex-wrap.html [ ImageOnlyFailure ]
 
-# This test is currently slow on Debug builds due to timer throttling.
-webkit.org/b/138262 [ Debug ] jquery/manipulation.html [ Failure Pass ]
-
 # nth-child tests takes long time and Debug build sometimes timeouts because there are many test cases.
 webkit.org/b/137149 fast/selectors/nth-child-of-basics.html [ Slow ]
 

Modified: trunk/LayoutTests/jquery/resources/test/qunit/qunit/qunit.js (175503 => 175504)


--- trunk/LayoutTests/jquery/resources/test/qunit/qunit/qunit.js	2014-11-04 02:08:27 UTC (rev 175503)
+++ trunk/LayoutTests/jquery/resources/test/qunit/qunit/qunit.js	2014-11-04 02:23:50 UTC (rev 175504)
@@ -494,7 +494,7 @@
 			stats: { all: 0, bad: 0 },
 			moduleStats: { all: 0, bad: 0 },
 			started: +new Date,
-			updateRate: 1000,
+			updateRate: 0, // Do not update results regularly as this is not needed for layout tests.
 			blocking: false,
 			autostart: true,
 			autorun: false,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to