Title: [175786] trunk/Websites/perf.webkit.org
- Revision
- 175786
- Author
- rn...@webkit.org
- Date
- 2014-11-08 19:21:13 -0800 (Sat, 08 Nov 2014)
Log Message
Fix Ember.js warnings the new perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=138531
Reviewed by Darin Adler.
Fixed various warnings.
* public/v2/app.js:
(App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
* public/v2/data.js:
(PrivilegedAPI._post): Removed the superfluous console.log.
(CommitLogs.fetchForTimeRange): Ditto.
* public/v2/index.html: Added tbody as required by the HTML specification.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (175785 => 175786)
--- trunk/Websites/perf.webkit.org/ChangeLog 2014-11-09 03:18:40 UTC (rev 175785)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2014-11-09 03:21:13 UTC (rev 175786)
@@ -1,3 +1,19 @@
+2014-11-08 Ryosuke Niwa <rn...@webkit.org>
+
+ Fix Ember.js warnings the new perf dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=138531
+
+ Reviewed by Darin Adler.
+
+ Fixed various warnings.
+
+ * public/v2/app.js:
+ (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
+ * public/v2/data.js:
+ (PrivilegedAPI._post): Removed the superfluous console.log.
+ (CommitLogs.fetchForTimeRange): Ditto.
+ * public/v2/index.html: Added tbody as required by the HTML specification.
+
2014-11-07 Ryosuke Niwa <rn...@webkit.org>
Fix typos in r175768.
Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (175785 => 175786)
--- trunk/Websites/perf.webkit.org/public/v2/app.js 2014-11-09 03:18:40 UTC (rev 175785)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2014-11-09 03:21:13 UTC (rev 175786)
@@ -1158,7 +1158,7 @@
this._yAxisUnitContainer = this._yAxisLabels.append("text")
.attr("x", 0.5 * this._rem)
.attr("y", this._rem)
- .attr("dy", '0.8rem')
+ .attr("dy", 0.8 * this._rem)
.style("text-anchor", "start")
.style("z-index", "100")
.text(this._yAxisUnit);
Modified: trunk/Websites/perf.webkit.org/public/v2/data.js (175785 => 175786)
--- trunk/Websites/perf.webkit.org/public/v2/data.js 2014-11-09 03:18:40 UTC (rev 175785)
+++ trunk/Websites/perf.webkit.org/public/v2/data.js 2014-11-09 03:21:13 UTC (rev 175786)
@@ -44,8 +44,7 @@
else
resolve(data);
}).fail(function (xhr, status, error) {
- console.log(xhr);
- reject(xhr.status + (error ? ', ' + error : ''));
+ reject(xhr.status + (error ? ', ' + error : '') + '\n\nWith response:\n' + xhr.responseText);
});
});
}
@@ -77,8 +76,6 @@
return new Ember.RSVP.Promise(function (resolve) { resolve(cachedCommitsForRange); });
}
- console.log('Fecthing ' + url);
-
return new Ember.RSVP.Promise(function (resolve, reject) {
$.getJSON(url, function (data) {
if (data.status != 'OK') {
Modified: trunk/Websites/perf.webkit.org/public/v2/index.html (175785 => 175786)
--- trunk/Websites/perf.webkit.org/public/v2/index.html 2014-11-09 03:18:40 UTC (rev 175785)
+++ trunk/Websites/perf.webkit.org/public/v2/index.html 2014-11-09 03:21:13 UTC (rev 175786)
@@ -196,24 +196,26 @@
<div {{bind-attr class=":bugs-pane showingBugsPane::hidden"}}>
<table>
- {{#if selectedSinglePoint}}
- {{#each details.bugTrackers}}
- <tr>
- <th>{{label}}</th>
- <td>
- <form {{action "associateBug" this editedBugNumber on="submit"}}>
- {{input type=text value=editedBugNumber}}
- </form>
- </td>
- </tr>
- {{/each}}
- {{/if}}
- <tr>
- <th>
- <label>Name: {{input type=text value=newAnalysisTaskName}}</label>
- <button {{action "createAnalysisTask"}}>Analyze</button>
- </th>
- </tr>
+ <tbody>
+ {{#if selectedSinglePoint}}
+ {{#each details.bugTrackers}}
+ <tr>
+ <th>{{label}}</th>
+ <td>
+ <form {{action "associateBug" this editedBugNumber on="submit"}}>
+ {{input type=text value=editedBugNumber}}
+ </form>
+ </td>
+ </tr>
+ {{/each}}
+ {{/if}}
+ <tr>
+ <th>
+ <label>Name: {{input type=text value=newAnalysisTaskName}}</label>
+ <button {{action "createAnalysisTask"}}>Analyze</button>
+ </th>
+ </tr>
+ </tbody>
</table>
</div>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
