Title: [176348] trunk/Source/WebCore
Revision
176348
Author
[email protected]
Date
2014-11-19 14:40:00 -0800 (Wed, 19 Nov 2014)

Log Message

Fix TilesAdded bitmask
https://bugs.webkit.org/show_bug.cgi?id=138883

Reviewed by Simon Fraser.

Simon spotted this.

* platform/graphics/ca/GraphicsLayerCA.h:

    Use 1LLU << 29 instead of 1LLU < 29
    This worked before by pure luck as bit 0 is unused.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (176347 => 176348)


--- trunk/Source/WebCore/ChangeLog	2014-11-19 22:32:04 UTC (rev 176347)
+++ trunk/Source/WebCore/ChangeLog	2014-11-19 22:40:00 UTC (rev 176348)
@@ -1,3 +1,17 @@
+2014-11-19  Antti Koivisto  <[email protected]>
+
+        Fix TilesAdded bitmask
+        https://bugs.webkit.org/show_bug.cgi?id=138883
+
+        Reviewed by Simon Fraser.
+
+        Simon spotted this.
+
+        * platform/graphics/ca/GraphicsLayerCA.h:
+
+            Use 1LLU << 29 instead of 1LLU < 29
+            This worked before by pure luck as bit 0 is unused.
+
 2014-11-19  Daniel Bates  <[email protected]>
 
         [iOS] Make WebKit build with public iOS SDK

Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h (176347 => 176348)


--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h	2014-11-19 22:32:04 UTC (rev 176347)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h	2014-11-19 22:40:00 UTC (rev 176348)
@@ -405,40 +405,40 @@
     bool appendToUncommittedAnimations(const KeyframeValueList&, const FilterOperation*, const Animation*, const String& animationName, int animationIndex, double timeOffset);
 
     enum LayerChange {
-        NoChange = 0,
-        NameChanged = 1LLU << 1,
-        ChildrenChanged = 1LLU << 2, // also used for content layer, and preserves-3d, and size if tiling changes?
-        GeometryChanged = 1LLU << 3,
-        TransformChanged = 1LLU << 4,
-        ChildrenTransformChanged = 1LLU << 5,
-        Preserves3DChanged = 1LLU << 6,
-        MasksToBoundsChanged = 1LLU << 7,
-        DrawsContentChanged = 1LLU << 8,
-        BackgroundColorChanged = 1LLU << 9,
-        ContentsOpaqueChanged = 1LLU << 10,
-        BackfaceVisibilityChanged = 1LLU << 11,
-        OpacityChanged = 1LLU << 12,
-        AnimationChanged = 1LLU << 13,
-        DirtyRectsChanged = 1LLU << 14,
-        ContentsImageChanged = 1LLU << 15,
-        ContentsPlatformLayerChanged = 1LLU << 16,
-        ContentsColorLayerChanged = 1LLU << 17,
-        ContentsRectsChanged = 1LLU << 18,
-        MaskLayerChanged = 1LLU << 19,
-        ReplicatedLayerChanged = 1LLU << 20,
-        ContentsNeedsDisplay = 1LLU << 21,
-        AcceleratesDrawingChanged = 1LLU << 22,
-        ContentsScaleChanged = 1LLU << 23,
-        ContentsVisibilityChanged = 1LLU << 24,
-        VisibleRectChanged = 1LLU << 25,
-        FiltersChanged = 1LLU << 26,
-        BackdropFiltersChanged = 1LLU << 27,
-        TilingAreaChanged = 1LLU << 28,
-        TilesAdded = 1LLU < 29,
-        DebugIndicatorsChanged = 1LLU << 30,
-        CustomAppearanceChanged = 1LLU << 31,
-        CustomBehaviorChanged = 1LLU << 32,
-        BlendModeChanged = 1LLU << 33
+        NoChange =                      0,
+        NameChanged =                   1LLU << 1,
+        ChildrenChanged =               1LLU << 2, // also used for content layer, and preserves-3d, and size if tiling changes?
+        GeometryChanged =               1LLU << 3,
+        TransformChanged =              1LLU << 4,
+        ChildrenTransformChanged =      1LLU << 5,
+        Preserves3DChanged =            1LLU << 6,
+        MasksToBoundsChanged =          1LLU << 7,
+        DrawsContentChanged =           1LLU << 8,
+        BackgroundColorChanged =        1LLU << 9,
+        ContentsOpaqueChanged =         1LLU << 10,
+        BackfaceVisibilityChanged =     1LLU << 11,
+        OpacityChanged =                1LLU << 12,
+        AnimationChanged =              1LLU << 13,
+        DirtyRectsChanged =             1LLU << 14,
+        ContentsImageChanged =          1LLU << 15,
+        ContentsPlatformLayerChanged =  1LLU << 16,
+        ContentsColorLayerChanged =     1LLU << 17,
+        ContentsRectsChanged =          1LLU << 18,
+        MaskLayerChanged =              1LLU << 19,
+        ReplicatedLayerChanged =        1LLU << 20,
+        ContentsNeedsDisplay =          1LLU << 21,
+        AcceleratesDrawingChanged =     1LLU << 22,
+        ContentsScaleChanged =          1LLU << 23,
+        ContentsVisibilityChanged =     1LLU << 24,
+        VisibleRectChanged =            1LLU << 25,
+        FiltersChanged =                1LLU << 26,
+        BackdropFiltersChanged =        1LLU << 27,
+        TilingAreaChanged =             1LLU << 28,
+        TilesAdded =                    1LLU << 29,
+        DebugIndicatorsChanged =        1LLU << 30,
+        CustomAppearanceChanged =       1LLU << 31,
+        CustomBehaviorChanged =         1LLU << 32,
+        BlendModeChanged =              1LLU << 33,
     };
     typedef uint64_t LayerChangeFlags;
     enum ScheduleFlushOrNot { ScheduleFlush, DontScheduleFlush };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to