Title: [177091] trunk/Source
Revision
177091
Author
gga...@apple.com
Date
2014-12-10 13:10:48 -0800 (Wed, 10 Dec 2014)

Log Message

Please disable the webkitFirstVersionWithInitConstructorSupport check on Apple TV
https://bugs.webkit.org/show_bug.cgi?id=139501

Reviewed by Gavin Barraclough.

Source/_javascript_Core:

NSVersionOfLinkTimeLibrary only works if you link directly against
_javascript_Core, which is a bit awkward for our Apple TV client to do.

It's easy enough just to disable this check on Apple TV, since it has no
backwards compatibility requirement.

* API/JSWrapperMap.mm:
(supportsInitMethodConstructors):

Source/WTF:

Added a platform definition for APPLETV.

(It's not an OS because it's not mutually exclusive with other OS definitions.)

* wtf/Platform.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/API/JSWrapperMap.mm (177090 => 177091)


--- trunk/Source/_javascript_Core/API/JSWrapperMap.mm	2014-12-10 21:00:09 UTC (rev 177090)
+++ trunk/Source/_javascript_Core/API/JSWrapperMap.mm	2014-12-10 21:10:48 UTC (rev 177091)
@@ -654,6 +654,11 @@
 
 bool supportsInitMethodConstructors()
 {
+#if PLATFORM(APPLETV)
+    // There are no old clients on Apple TV, so there's no need for backwards compatibility.
+    return true;
+#endif
+
     static int32_t versionOfLinkTimeLibrary = 0;
     if (!versionOfLinkTimeLibrary)
         versionOfLinkTimeLibrary = NSVersionOfLinkTimeLibrary("_javascript_Core");

Modified: trunk/Source/_javascript_Core/ChangeLog (177090 => 177091)


--- trunk/Source/_javascript_Core/ChangeLog	2014-12-10 21:00:09 UTC (rev 177090)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-12-10 21:10:48 UTC (rev 177091)
@@ -1,3 +1,19 @@
+2014-12-10  Geoffrey Garen  <gga...@apple.com>
+
+        Please disable the webkitFirstVersionWithInitConstructorSupport check on Apple TV
+        https://bugs.webkit.org/show_bug.cgi?id=139501
+
+        Reviewed by Gavin Barraclough.
+
+        NSVersionOfLinkTimeLibrary only works if you link directly against
+        _javascript_Core, which is a bit awkward for our Apple TV client to do.
+
+        It's easy enough just to disable this check on Apple TV, since it has no
+        backwards compatibility requirement.
+
+        * API/JSWrapperMap.mm:
+        (supportsInitMethodConstructors):
+
 2014-12-10  Matthew Mirman  <mmir...@apple.com>
 
         Fixes operationPutByIds such that they check that the put didn't

Modified: trunk/Source/WTF/ChangeLog (177090 => 177091)


--- trunk/Source/WTF/ChangeLog	2014-12-10 21:00:09 UTC (rev 177090)
+++ trunk/Source/WTF/ChangeLog	2014-12-10 21:10:48 UTC (rev 177091)
@@ -1,3 +1,16 @@
+2014-12-10  Geoffrey Garen  <gga...@apple.com>
+
+        Please disable the webkitFirstVersionWithInitConstructorSupport check on Apple TV
+        https://bugs.webkit.org/show_bug.cgi?id=139501
+
+        Reviewed by Gavin Barraclough.
+
+        Added a platform definition for APPLETV.
+
+        (It's not an OS because it's not mutually exclusive with other OS definitions.)
+
+        * wtf/Platform.h:
+
 2014-12-10  Martin Robinson  <mrobin...@igalia.com>
 
         [GTK] Add support for text-decoration-skip

Modified: trunk/Source/WTF/wtf/Platform.h (177090 => 177091)


--- trunk/Source/WTF/wtf/Platform.h	2014-12-10 21:00:09 UTC (rev 177090)
+++ trunk/Source/WTF/wtf/Platform.h	2014-12-10 21:10:48 UTC (rev 177091)
@@ -452,6 +452,11 @@
 #endif
 #endif
 
+/* PLATFORM(APPLETV) */
+#if defined(TARGET_OS_TV) && TARGET_OS_TV
+#define WTF_PLATFORM_APPLETV 1
+#endif
+
 /* Graphics engines */
 
 /* USE(CG) and PLATFORM(CI) */
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to