Title: [178255] trunk/LayoutTests
- Revision
- 178255
- Author
- commit-qu...@webkit.org
- Date
- 2015-01-12 05:50:02 -0800 (Mon, 12 Jan 2015)
Log Message
AX: [ATK] Whether to show the title attribute, if there is a label with the attribute for?
https://bugs.webkit.org/show_bug.cgi?id=139986
Patch by Andrzej Badowski <a.badow...@samsung.com> on 2015-01-12
Reviewed by Chris Fleizach.
* accessibility/radio-button-title-label.html:
This test is also suitable for EFL and GTK port.
* platform/efl/TestExpectations:
* platform/efl/accessibility/radio-button-title-label-expected.txt: Added.
* platform/gtk/TestExpectations:
* platform/gtk/accessibility/radio-button-title-label-expected.txt: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (178254 => 178255)
--- trunk/LayoutTests/ChangeLog 2015-01-12 10:42:48 UTC (rev 178254)
+++ trunk/LayoutTests/ChangeLog 2015-01-12 13:50:02 UTC (rev 178255)
@@ -1,3 +1,17 @@
+2015-01-12 Andrzej Badowski <a.badow...@samsung.com>
+
+ AX: [ATK] Whether to show the title attribute, if there is a label with the attribute for?
+ https://bugs.webkit.org/show_bug.cgi?id=139986
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/radio-button-title-label.html:
+ This test is also suitable for EFL and GTK port.
+ * platform/efl/TestExpectations:
+ * platform/efl/accessibility/radio-button-title-label-expected.txt: Added.
+ * platform/gtk/TestExpectations:
+ * platform/gtk/accessibility/radio-button-title-label-expected.txt: Added.
+
2015-01-12 Shivakumar JM <shiva...@samsung.com>
Fix lint-test-files warnings in TestExpectations files.
Modified: trunk/LayoutTests/accessibility/radio-button-title-label.html (178254 => 178255)
--- trunk/LayoutTests/accessibility/radio-button-title-label.html 2015-01-12 10:42:48 UTC (rev 178254)
+++ trunk/LayoutTests/accessibility/radio-button-title-label.html 2015-01-12 13:50:02 UTC (rev 178255)
@@ -30,7 +30,10 @@
// 1) Even though a checkbox has a title attribute, the title ui element should still be exposed.
var radio1 = accessibilityController.accessibleElementById("r1");
var titleUIElement = radio1.titleUIElement();
- shouldBe("radio1.title", "'AXTitle: '");
+ if (accessibilityController.platformName == "atk")
+ shouldBe("radio1.title", "'AXTitle: LABEL'");
+ else
+ shouldBe("radio1.title", "'AXTitle: '");
shouldBeTrue("titleUIElement.isEqual(accessibilityController.accessibleElementById('label1'))");
// 2) aria-labeledby should override the native label semantics and return a title for the radio button, instead of a title ui element.
Modified: trunk/LayoutTests/platform/efl/TestExpectations (178254 => 178255)
--- trunk/LayoutTests/platform/efl/TestExpectations 2015-01-12 10:42:48 UTC (rev 178254)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2015-01-12 13:50:02 UTC (rev 178255)
@@ -1449,8 +1449,6 @@
# New accessibility test added in r149155 is failing. Has been moved to the mac port in r155603.
webkit.org/b/115659 accessibility/meter-element.html [ Missing ]
-webkit.org/b/121593 accessibility/radio-button-title-label.html [ Failure ]
-
# Fail to generate proper pixel results - let's wait with rebaselining.
webkit.org/b/106992 scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ Failure Pass ]
webkit.org/b/106992 scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html [ Failure Pass ]
Added: trunk/LayoutTests/platform/efl/accessibility/radio-button-title-label-expected.txt (0 => 178255)
--- trunk/LayoutTests/platform/efl/accessibility/radio-button-title-label-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/accessibility/radio-button-title-label-expected.txt 2015-01-12 13:50:02 UTC (rev 178255)
@@ -0,0 +1,22 @@
+This test checks that radio buttons expose title ui elements correctly under a variety of cirmcumstances. In general, the should NOT disappear and should be the titleUIElement for the checkbox.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS radio1.title is 'AXTitle: LABEL'
+PASS titleUIElement.isEqual(accessibilityController.accessibleElementById('label1')) is true
+PASS radio2.description is 'AXDescription: LABEL2a'
+PASS radio2.title is 'AXTitle: '
+PASS !titleUIElement || titleUIElement.title == 'AXTitle: ' is true
+PASS radio3.description is 'AXDescription: radio3'
+PASS radio3.title is 'AXTitle: '
+PASS !titleUIElement || titleUIElement.title == 'AXTitle: ' is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+Test
+LABEL Test
+LABEL2
+LABEL2a
+Test
+LABEL3
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (178254 => 178255)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2015-01-12 10:42:48 UTC (rev 178254)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2015-01-12 13:50:02 UTC (rev 178255)
@@ -1991,8 +1991,6 @@
webkit.org/b/120842 fast/regions/overflow/overflow-in-uniform-regions-dynamic.html [ ImageOnlyFailure ]
webkit.org/b/120842 fast/regions/overflow/overflow-moving-below-floats-in-variable-width-regions.html [ ImageOnlyFailure ]
-webkit.org/b/121593 accessibility/radio-button-title-label.html [ Failure ]
-
webkit.org/b/121905 fast/images/exif-orientation.html [ Failure ]
webkit.org/b/124360 media/video-canvas-drawing-output.html [ Failure ]
Added: trunk/LayoutTests/platform/gtk/accessibility/radio-button-title-label-expected.txt (0 => 178255)
--- trunk/LayoutTests/platform/gtk/accessibility/radio-button-title-label-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/radio-button-title-label-expected.txt 2015-01-12 13:50:02 UTC (rev 178255)
@@ -0,0 +1,22 @@
+This test checks that radio buttons expose title ui elements correctly under a variety of cirmcumstances. In general, the should NOT disappear and should be the titleUIElement for the checkbox.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS radio1.title is 'AXTitle: LABEL'
+PASS titleUIElement.isEqual(accessibilityController.accessibleElementById('label1')) is true
+PASS radio2.description is 'AXDescription: LABEL2a'
+PASS radio2.title is 'AXTitle: '
+PASS !titleUIElement || titleUIElement.title == 'AXTitle: ' is true
+PASS radio3.description is 'AXDescription: radio3'
+PASS radio3.title is 'AXTitle: '
+PASS !titleUIElement || titleUIElement.title == 'AXTitle: ' is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+Test
+LABEL Test
+LABEL2
+LABEL2a
+Test
+LABEL3
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes