Title: [179009] trunk/Source/WTF
Revision
179009
Author
carlo...@webkit.org
Date
2015-01-23 08:33:04 -0800 (Fri, 23 Jan 2015)

Log Message

[GTK] Add missing null check in some derefGPtr implementations
https://bugs.webkit.org/show_bug.cgi?id=140822

Reviewed by Sergio Villar Senin.

It's missing in GHashTable and GVariant implementations.

* wtf/gobject/GRefPtr.cpp:
(WTF::derefGPtr):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (179008 => 179009)


--- trunk/Source/WTF/ChangeLog	2015-01-23 14:56:54 UTC (rev 179008)
+++ trunk/Source/WTF/ChangeLog	2015-01-23 16:33:04 UTC (rev 179009)
@@ -1,5 +1,17 @@
 2015-01-23  Carlos Garcia Campos  <cgar...@igalia.com>
 
+        [GTK] Add missing null check in some derefGPtr implementations
+        https://bugs.webkit.org/show_bug.cgi?id=140822
+
+        Reviewed by Sergio Villar Senin.
+
+        It's missing in GHashTable and GVariant implementations.
+
+        * wtf/gobject/GRefPtr.cpp:
+        (WTF::derefGPtr):
+
+2015-01-23  Carlos Garcia Campos  <cgar...@igalia.com>
+
         [GTK] Add initial database process support
         https://bugs.webkit.org/show_bug.cgi?id=139491
 

Modified: trunk/Source/WTF/wtf/gobject/GRefPtr.cpp (179008 => 179009)


--- trunk/Source/WTF/wtf/gobject/GRefPtr.cpp	2015-01-23 14:56:54 UTC (rev 179008)
+++ trunk/Source/WTF/wtf/gobject/GRefPtr.cpp	2015-01-23 16:33:04 UTC (rev 179009)
@@ -35,7 +35,8 @@
 
 template <> void derefGPtr(GHashTable* ptr)
 {
-    g_hash_table_unref(ptr);
+    if (ptr)
+        g_hash_table_unref(ptr);
 }
 
 template <> GMainContext* refGPtr(GMainContext* ptr)
@@ -86,7 +87,8 @@
 
 template <> void derefGPtr(GVariant* ptr)
 {
-    g_variant_unref(ptr);
+    if (ptr)
+        g_variant_unref(ptr);
 }
 
 template <> GVariantBuilder* refGPtr(GVariantBuilder* ptr)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to