Title: [179035] trunk/Source/_javascript_Core
- Revision
- 179035
- Author
- msab...@apple.com
- Date
- 2015-01-23 15:48:14 -0800 (Fri, 23 Jan 2015)
Log Message
LayoutTests/js/script-tests/reentrant-caching.js crashing on 32 bit builds
https://bugs.webkit.org/show_bug.cgi?id=140843
Reviewed by Oliver Hunt.
When we are in vmEntryToJavaScript, we keep the stack pointer at an
alignment sutiable for pointing to a call frame header, which is the
alignment post making a call. We adjust the sp when calling to JS code,
but don't adjust it before calling the out of stack handler.
* llint/LowLevelInterpreter32_64.asm:
Moved stack point down 8 bytes to get it aligned.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (179034 => 179035)
--- trunk/Source/_javascript_Core/ChangeLog 2015-01-23 23:37:25 UTC (rev 179034)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-01-23 23:48:14 UTC (rev 179035)
@@ -1,3 +1,18 @@
+2015-01-23 Michael Saboff <msab...@apple.com>
+
+ LayoutTests/js/script-tests/reentrant-caching.js crashing on 32 bit builds
+ https://bugs.webkit.org/show_bug.cgi?id=140843
+
+ Reviewed by Oliver Hunt.
+
+ When we are in vmEntryToJavaScript, we keep the stack pointer at an
+ alignment sutiable for pointing to a call frame header, which is the
+ alignment post making a call. We adjust the sp when calling to JS code,
+ but don't adjust it before calling the out of stack handler.
+
+ * llint/LowLevelInterpreter32_64.asm:
+ Moved stack point down 8 bytes to get it aligned.
+
2015-01-23 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Object Previews in the Console
Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (179034 => 179035)
--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2015-01-23 23:37:25 UTC (rev 179034)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm 2015-01-23 23:48:14 UTC (rev 179035)
@@ -259,6 +259,7 @@
move temp3, vm
end
+ subp 8, sp # Align stack for cCall2() to make a call.
cCall2(_llint_throw_stack_overflow_error, vm, protoCallFrame)
if ARMv7
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
