Title: [179115] trunk/Source/WebKit2
- Revision
- 179115
- Author
- commit-qu...@webkit.org
- Date
- 2015-01-26 08:25:09 -0800 (Mon, 26 Jan 2015)
Log Message
AX: crash in accessibilityRootObjectWrapper method (WebPageAccessibilityObjectAtk.cpp)
<https://bugs.webkit.org/show_bug.cgi?id=140618>
Patch by Fabien Vallée <fval...@connected-labs.com> on 2015-01-26
Reviewed by Chris Fleizach.
Check if document()->axObjectCache() is nullptr to fix the crash.
Similar patch has been applied on mac port:
<http://trac.webkit.org/changeset/167136>
Crash occured on <http://itv.mit-xperts.com/hbbtvtest/appmanager/>
(this page needs CEHTML / HbbTV extensions, conditions cannot
be reproduced using regression tests)
* WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
(accessibilityRootObjectWrapper):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (179114 => 179115)
--- trunk/Source/WebKit2/ChangeLog 2015-01-26 15:51:21 UTC (rev 179114)
+++ trunk/Source/WebKit2/ChangeLog 2015-01-26 16:25:09 UTC (rev 179115)
@@ -1,3 +1,21 @@
+2015-01-26 Fabien Vallée <fval...@connected-labs.com>
+
+ AX: crash in accessibilityRootObjectWrapper method (WebPageAccessibilityObjectAtk.cpp)
+ <https://bugs.webkit.org/show_bug.cgi?id=140618>
+
+ Reviewed by Chris Fleizach.
+
+ Check if document()->axObjectCache() is nullptr to fix the crash.
+ Similar patch has been applied on mac port:
+ <http://trac.webkit.org/changeset/167136>
+
+ Crash occured on <http://itv.mit-xperts.com/hbbtvtest/appmanager/>
+ (this page needs CEHTML / HbbTV extensions, conditions cannot
+ be reproduced using regression tests)
+
+ * WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp:
+ (accessibilityRootObjectWrapper):
+
2015-01-26 Michael Catanzaro <mcatanz...@igalia.com>
[GTK] gtkdoc does not appear in DevHelp
Modified: trunk/Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp (179114 => 179115)
--- trunk/Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp 2015-01-26 15:51:21 UTC (rev 179114)
+++ trunk/Source/WebKit2/WebProcess/WebPage/atk/WebPageAccessibilityObjectAtk.cpp 2015-01-26 16:25:09 UTC (rev 179115)
@@ -56,7 +56,11 @@
if (!coreFrame.document())
return 0;
- AccessibilityObject* coreRootObject = coreFrame.document()->axObjectCache()->rootObject();
+ AXObjectCache* cache = coreFrame.document()->axObjectCache();
+ if (!cache)
+ return nullptr;
+
+ AccessibilityObject* coreRootObject = cache->rootObject();
if (!coreRootObject)
return 0;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
