Title: [179875] trunk/Source/_javascript_Core
- Revision
- 179875
- Author
- fpi...@apple.com
- Date
- 2015-02-10 11:48:56 -0800 (Tue, 10 Feb 2015)
Log Message
Remove unused DFG::SpeculativeJIT::calleeFrameOffset().
Rubber stamped by Michael Saboff.
Not only was this not used, I believe that the math was wrong. The callee frame doesn't
actually land past m_nextMachineLocal; instead it lands just below wherever we put SP and
that decision is made elsewhere. Also, it makes no sense to subtract 1 from
m_nextMachineLocal when trying to deduce the number of in-use stack slots.
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::calleeFrameOffset): Deleted.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (179874 => 179875)
--- trunk/Source/_javascript_Core/ChangeLog 2015-02-10 19:11:44 UTC (rev 179874)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-02-10 19:48:56 UTC (rev 179875)
@@ -1,3 +1,17 @@
+2015-02-10 Filip Pizlo <fpi...@apple.com>
+
+ Remove unused DFG::SpeculativeJIT::calleeFrameOffset().
+
+ Rubber stamped by Michael Saboff.
+
+ Not only was this not used, I believe that the math was wrong. The callee frame doesn't
+ actually land past m_nextMachineLocal; instead it lands just below wherever we put SP and
+ that decision is made elsewhere. Also, it makes no sense to subtract 1 from
+ m_nextMachineLocal when trying to deduce the number of in-use stack slots.
+
+ * dfg/DFGSpeculativeJIT.h:
+ (JSC::DFG::SpeculativeJIT::calleeFrameOffset): Deleted.
+
2015-02-10 Saam Barati <saambara...@gmail.com>
Parser::parseVarDeclarationList gets the wrong JSToken for the last identifier
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h (179874 => 179875)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h 2015-02-10 19:11:44 UTC (rev 179874)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h 2015-02-10 19:48:56 UTC (rev 179875)
@@ -717,11 +717,6 @@
void compileInstanceOfForObject(Node*, GPRReg valueReg, GPRReg prototypeReg, GPRReg scratchAndResultReg, GPRReg scratch2Reg);
void compileInstanceOf(Node*);
- ptrdiff_t calleeFrameOffset(int numArgs)
- {
- return virtualRegisterForLocal(m_jit.graph().m_nextMachineLocal - 1 + JSStack::CallFrameHeaderSize + numArgs).offset() * sizeof(Register);
- }
-
// Access to our fixed callee CallFrame.
MacroAssembler::Address calleeFrameSlot(int slot)
{
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
