Title: [180782] trunk/Source/WebKit2
- Revision
- 180782
- Author
- bda...@apple.com
- Date
- 2015-02-27 14:45:33 -0800 (Fri, 27 Feb 2015)
Log Message
Lookup panel dismisses when pages are loading in other tabs/windows
https://bugs.webkit.org/show_bug.cgi?id=142104
-and corresponding-
rdar://problem/19882137
Reviewed by Tim Horton.
Until rdar://problem/13875766 is resolved, we should only call into Lookup and
DataDetectors for key windows.
* UIProcess/API/mac/WKView.mm:
(-[WKView _dismissContentRelativeChildWindows]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (180781 => 180782)
--- trunk/Source/WebKit2/ChangeLog 2015-02-27 22:17:09 UTC (rev 180781)
+++ trunk/Source/WebKit2/ChangeLog 2015-02-27 22:45:33 UTC (rev 180782)
@@ -1,3 +1,17 @@
+2015-02-27 Beth Dakin <bda...@apple.com>
+
+ Lookup panel dismisses when pages are loading in other tabs/windows
+ https://bugs.webkit.org/show_bug.cgi?id=142104
+ -and corresponding-
+ rdar://problem/19882137
+
+ Reviewed by Tim Horton.
+
+ Until rdar://problem/13875766 is resolved, we should only call into Lookup and
+ DataDetectors for key windows.
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView _dismissContentRelativeChildWindows]):
+
2015-02-27 Anders Carlsson <ander...@apple.com>
Add infrastructure for handling website data in the network process
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (180781 => 180782)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-02-27 22:17:09 UTC (rev 180781)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2015-02-27 22:45:33 UTC (rev 180782)
@@ -4408,12 +4408,14 @@
- (void)_dismissContentRelativeChildWindows
{
// FIXME: We don't know which panel we are dismissing, it may not even be in the current page (see <rdar://problem/13875766>).
- if (Class lookupDefinitionModuleClass = getLULookupDefinitionModuleClass())
- [lookupDefinitionModuleClass hideDefinition];
+ if ([[self window] isKeyWindow]) {
+ if (Class lookupDefinitionModuleClass = getLULookupDefinitionModuleClass())
+ [lookupDefinitionModuleClass hideDefinition];
- DDActionsManager *actionsManager = [getDDActionsManagerClass() sharedManager];
- if ([actionsManager respondsToSelector:@selector(requestBubbleClosureUnanchorOnFailure:)])
- [actionsManager requestBubbleClosureUnanchorOnFailure:YES];
+ DDActionsManager *actionsManager = [getDDActionsManagerClass() sharedManager];
+ if ([actionsManager respondsToSelector:@selector(requestBubbleClosureUnanchorOnFailure:)])
+ [actionsManager requestBubbleClosureUnanchorOnFailure:YES];
+ }
[self _setTextIndicator:nullptr fadeOut:NO];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
