Title: [181819] trunk/Source/WebInspectorUI
- Revision
- 181819
- Author
- nvasil...@apple.com
- Date
- 2015-03-20 16:38:03 -0700 (Fri, 20 Mar 2015)
Log Message
Web Inspector: Fast typing lags in the Styles sidebar or Console
https://bugs.webkit.org/show_bug.cgi?id=142919
Asynchronous autocomplete causes a race condition in CodeMirror,
which results in skipped characters in while typing. Completing immediately
fixes the issues.
Reviewed by Timothy Hatcher.
* UserInterface/Controllers/CodeMirrorCompletionController.js:
(WebInspector.CodeMirrorCompletionController.prototype.hideCompletions):
(WebInspector.CodeMirrorCompletionController.prototype._completeAtCurrentPosition):
(WebInspector.CodeMirrorCompletionController.prototype.):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (181818 => 181819)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-03-20 23:37:51 UTC (rev 181818)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-03-20 23:38:03 UTC (rev 181819)
@@ -1,3 +1,19 @@
+2015-03-20 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: Fast typing lags in the Styles sidebar or Console
+ https://bugs.webkit.org/show_bug.cgi?id=142919
+
+ Asynchronous autocomplete causes a race condition in CodeMirror,
+ which results in skipped characters in while typing. Completing immediately
+ fixes the issues.
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Controllers/CodeMirrorCompletionController.js:
+ (WebInspector.CodeMirrorCompletionController.prototype.hideCompletions):
+ (WebInspector.CodeMirrorCompletionController.prototype._completeAtCurrentPosition):
+ (WebInspector.CodeMirrorCompletionController.prototype.):
+
2015-03-19 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: Adopt ES6 Class Syntax for all Model Objects
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js (181818 => 181819)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js 2015-03-20 23:37:51 UTC (rev 181818)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js 2015-03-20 23:38:03 UTC (rev 181819)
@@ -169,11 +169,6 @@
this._implicitSuffix = "";
this._forced = false;
- if (this._completionDelayTimeout) {
- clearTimeout(this._completionDelayTimeout);
- delete this._completionDelayTimeout;
- }
-
delete this._currentCompletion;
delete this._ignoreNextCursorActivity;
},
@@ -443,11 +438,6 @@
return;
}
- if (this._completionDelayTimeout) {
- clearTimeout(this._completionDelayTimeout);
- delete this._completionDelayTimeout;
- }
-
this._removeCompletionHint(true, true);
var cursor = this._codeMirror.getCursor();
@@ -787,15 +777,7 @@
if (change.origin === "+delete" && !this._hasPendingCompletion())
return;
- if (this._completionDelayTimeout) {
- clearTimeout(this._completionDelayTimeout);
- delete this._completionDelayTimeout;
- }
-
- if (this._hasPendingCompletion())
- this._completeAtCurrentPosition(false);
- else
- this._completionDelayTimeout = setTimeout(this._completeAtCurrentPosition.bind(this, false), WebInspector.CodeMirrorCompletionController.CompletionTypingDelay);
+ this._completeAtCurrentPosition(false);
},
_handleCursorActivity: function(codeMirror)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
