Title: [181880] trunk/Tools
- Revision
- 181880
- Author
- bfulg...@apple.com
- Date
- 2015-03-23 15:56:58 -0700 (Mon, 23 Mar 2015)
Log Message
Regression(r181257): WTF_WorkQueue.Simple is flaky
https://bugs.webkit.org/show_bug.cgi?id=142560
Remove the check that the refCount has returned to one after the
individual tasks have completed. It's too nondeterministic when
the reference count will be reduced.
Reviewed by Alexey Proskuryakov
* TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
(TestWebKitAPI::TEST): Remove test that refCount is back to 1.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (181879 => 181880)
--- trunk/Tools/ChangeLog 2015-03-23 22:52:27 UTC (rev 181879)
+++ trunk/Tools/ChangeLog 2015-03-23 22:56:58 UTC (rev 181880)
@@ -1,3 +1,17 @@
+2015-03-23 Brent Fulgham <bfulg...@apple.com>
+
+ Regression(r181257): WTF_WorkQueue.Simple is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=142560
+
+ Remove the check that the refCount has returned to one after the
+ individual tasks have completed. It's too nondeterministic when
+ the reference count will be reduced.
+
+ Reviewed by Alexey Proskuryakov
+
+ * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
+ (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
+
2015-03-23 Gyuyoung Kim <gyuyoung....@samsung.com>
[CMake][EFL] Put failure API test excutables into failure directory
Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp (181879 => 181880)
--- trunk/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp 2015-03-23 22:52:27 UTC (rev 181879)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp 2015-03-23 22:56:58 UTC (rev 181880)
@@ -87,7 +87,6 @@
EXPECT_TRUE(calledSimpleTest);
EXPECT_TRUE(calledLongTest);
EXPECT_TRUE(calledThirdTest);
- EXPECT_EQ(1, queue->refCount());
EXPECT_EQ(static_cast<size_t>(3), m_functionCallOrder.size());
EXPECT_STREQ(simpleTestLabel, m_functionCallOrder[0].c_str());
@@ -108,10 +107,8 @@
auto queue1 = WorkQueue::create("com.apple.WebKit.Test.twoQueues1");
auto queue2 = WorkQueue::create("com.apple.WebKit.Test.twoQueues2");
- int initialQueue1RefCount = queue1->refCount();
- int initialQueue2RefCount = queue2->refCount();
- EXPECT_EQ(1, initialQueue1RefCount);
- EXPECT_EQ(1, initialQueue2RefCount);
+ EXPECT_EQ(1, queue1->refCount());
+ EXPECT_EQ(1, queue2->refCount());
MutexLocker locker(m_lock);
@@ -146,14 +143,12 @@
EXPECT_TRUE(calledSimpleTest);
EXPECT_FALSE(calledLongTest);
EXPECT_TRUE(calledThirdTest);
- EXPECT_EQ(1, queue1->refCount());
m_testQueue2Completed.wait(m_lock);
EXPECT_TRUE(calledSimpleTest);
EXPECT_TRUE(calledLongTest);
EXPECT_TRUE(calledThirdTest);
- EXPECT_EQ(1, queue2->refCount());
EXPECT_EQ(static_cast<size_t>(3), m_functionCallOrder.size());
EXPECT_STREQ(simpleTestLabel, m_functionCallOrder[0].c_str());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
