Title: [182095] trunk/Source/WebInspectorUI
Revision
182095
Author
commit-qu...@webkit.org
Date
2015-03-27 17:57:53 -0700 (Fri, 27 Mar 2015)

Log Message

Web Inspector: Disable editing in Metrics section while it is not working
https://bugs.webkit.org/show_bug.cgi?id=143165

Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-03-27
Reviewed by Timothy Hatcher.

* UserInterface/Views/BoxModelDetailsSectionRow.js:
(WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement):
(WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
Disable double click to edit while it is not working. The value setter
and add methods no longer exist.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182094 => 182095)


--- trunk/Source/WebInspectorUI/ChangeLog	2015-03-28 00:56:03 UTC (rev 182094)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-03-28 00:57:53 UTC (rev 182095)
@@ -1,5 +1,18 @@
 2015-03-27  Joseph Pecoraro  <pecor...@apple.com>
 
+        Web Inspector: Disable editing in Metrics section while it is not working
+        https://bugs.webkit.org/show_bug.cgi?id=143165
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/BoxModelDetailsSectionRow.js:
+        (WebInspector.BoxModelDetailsSectionRow.prototype._updateMetrics.createElement):
+        (WebInspector.BoxModelDetailsSectionRow.prototype._applyUserInput):
+        Disable double click to edit while it is not working. The value setter
+        and add methods no longer exist.
+
+2015-03-27  Joseph Pecoraro  <pecor...@apple.com>
+
         Web Inspector: Uncaught Exceptions evaluating code while paused
         https://bugs.webkit.org/show_bug.cgi?id=143163
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js (182094 => 182095)


--- trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js	2015-03-28 00:56:03 UTC (rev 182094)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js	2015-03-28 00:57:53 UTC (rev 182095)
@@ -117,7 +117,8 @@
             element.textContent = shouldRoundValue ? ("~" + Math.round(floatValue * 100) / 100) : value;
             if (shouldRoundValue)
                 element.title = value;
-            element.addEventListener("dblclick", this._startEditing.bind(this, element, name, propertyName, style), false);
+            // FIXME: <https://webkit.org/b/143164> Web Inspector: REGRESSION(r179286) Editing Style Metrics Values no longer works
+            // element.addEventListener("dblclick", this._startEditing.bind(this, element, name, propertyName, style), false);
             return element;
         }
 
@@ -413,8 +414,7 @@
         }
 
         var property = this._nodeStyles.inlineStyle.propertyForName(context.styleProperty);
-        property.value = userInput;
-        property.add();
+        // FIXME: <https://webkit.org/b/143164> Web Inspector: REGRESSION(r179286) Editing Style Metrics Values no longer works
     }
 
     _editingCommitted(element, userInput, previousContent, context)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to