Title: [182292] trunk/Source/WebCore
- Revision
- 182292
- Author
- jer.no...@apple.com
- Date
- 2015-04-02 15:31:24 -0700 (Thu, 02 Apr 2015)
Log Message
[Mac] Only pass in the AVURLAssetClientBundleIdentifierKey on iOS.
https://bugs.webkit.org/show_bug.cgi?id=143347
Reviewed by Brent Fulgham.
Only pass in the main app bundle id into AVURLAsset via the AVURLAssetClientBundleIdentifierKey option
on iOS. On OS X, setting this key can cause media playback to fail.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (182291 => 182292)
--- trunk/Source/WebCore/ChangeLog 2015-04-02 22:23:16 UTC (rev 182291)
+++ trunk/Source/WebCore/ChangeLog 2015-04-02 22:31:24 UTC (rev 182292)
@@ -1,3 +1,16 @@
+2015-04-02 Jer Noble <jer.no...@apple.com>
+
+ [Mac] Only pass in the AVURLAssetClientBundleIdentifierKey on iOS.
+ https://bugs.webkit.org/show_bug.cgi?id=143347
+
+ Reviewed by Brent Fulgham.
+
+ Only pass in the main app bundle id into AVURLAsset via the AVURLAssetClientBundleIdentifierKey option
+ on iOS. On OS X, setting this key can cause media playback to fail.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
+
2015-04-02 Roger Fong <roger_f...@apple.com>
Show audio media controls on OSX.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (182291 => 182292)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2015-04-02 22:23:16 UTC (rev 182291)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2015-04-02 22:31:24 UTC (rev 182292)
@@ -843,9 +843,12 @@
if (player()->doesHaveAttribute("x-itunes-inherit-uri-query-component"))
[options.get() setObject: [NSNumber numberWithBool: TRUE] forKey: AVURLAssetInheritURIQueryComponentFromReferencingURIKey];
+#if PLATFORM(IOS)
+ // FIXME: rdar://problem/20354688
String identifier = player()->sourceApplicationIdentifier();
if (!identifier.isEmpty() && AVURLAssetClientBundleIdentifierKey)
[options setObject:identifier forKey:AVURLAssetClientBundleIdentifierKey];
+#endif
#if ENABLE(AVF_CAPTIONS)
const Vector<RefPtr<PlatformTextTrack>>& outOfBandTrackSources = player()->outOfBandTrackSources();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
