Title: [182372] trunk/Source/WebInspectorUI
Revision
182372
Author
commit-qu...@webkit.org
Date
2015-04-05 18:56:28 -0700 (Sun, 05 Apr 2015)

Log Message

Web Inspector: Regression: Map instances don't expand
https://bugs.webkit.org/show_bug.cgi?id=143428

Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-04-05
Reviewed by Brian Burg.

Fix uses of "this" in super() calls. Also fix a style name
that no longer exists and was intended to be inlined.

* UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js:
(WebInspector.IndexedDatabaseObjectStoreTreeElement):
* UserInterface/Views/IndexedDatabaseTreeElement.js:
(WebInspector.IndexedDatabaseTreeElement):
* UserInterface/Views/ObjectTreeMapEntryTreeElement.js:
(WebInspector.ObjectTreeMapEntryTreeElement):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (182371 => 182372)


--- trunk/Source/WebInspectorUI/ChangeLog	2015-04-06 01:43:32 UTC (rev 182371)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-04-06 01:56:28 UTC (rev 182372)
@@ -1,3 +1,20 @@
+2015-04-05  Joseph Pecoraro  <pecor...@apple.com>
+
+        Web Inspector: Regression: Map instances don't expand
+        https://bugs.webkit.org/show_bug.cgi?id=143428
+
+        Reviewed by Brian Burg.
+
+        Fix uses of "this" in super() calls. Also fix a style name
+        that no longer exists and was intended to be inlined.
+
+        * UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js:
+        (WebInspector.IndexedDatabaseObjectStoreTreeElement):
+        * UserInterface/Views/IndexedDatabaseTreeElement.js:
+        (WebInspector.IndexedDatabaseTreeElement):
+        * UserInterface/Views/ObjectTreeMapEntryTreeElement.js:
+        (WebInspector.ObjectTreeMapEntryTreeElement):
+
 2015-04-05  Nikita Vasilyev  <nvasil...@apple.com>
 
         Web Inspector: ObjectTree array index hints are clipped when shown in popover

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js (182371 => 182372)


--- trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js	2015-04-06 01:43:32 UTC (rev 182371)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js	2015-04-06 01:56:28 UTC (rev 182372)
@@ -29,7 +29,7 @@
     {
         console.assert(objectStore instanceof WebInspector.IndexedDatabaseObjectStore);
 
-        super(WebInspector.IndexedDatabaseObjectStoreTreeElement.IconStyleClassName, objectStore.name, null, objectStore, !!this._objectStore.indexes.length);
+        super("database-table-icon", objectStore.name, null, objectStore, !!objectStore.indexes.length);
 
         this._objectStore = objectStore;
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseTreeElement.js (182371 => 182372)


--- trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseTreeElement.js	2015-04-06 01:43:32 UTC (rev 182371)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseTreeElement.js	2015-04-06 01:56:28 UTC (rev 182372)
@@ -29,10 +29,10 @@
     {
         console.assert(indexedDatabase instanceof WebInspector.IndexedDatabase);
 
+        super("database-icon", indexedDatabase.name, null, indexedDatabase, !!indexedDatabase.objectStores.length);
+
         this._indexedDatabase = indexedDatabase;
 
-        super("database-icon", indexedDatabase.name, null, indexedDatabase, !!this._indexedDatabase.objectStores.length);
-
         this.small = true;
     }
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.js (182371 => 182372)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.js	2015-04-06 01:43:32 UTC (rev 182371)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeMapEntryTreeElement.js	2015-04-06 01:56:28 UTC (rev 182372)
@@ -30,7 +30,7 @@
         console.assert(object instanceof WebInspector.RemoteObject);
 
         // Treat the same as an array-index just with different strings and widths.
-        super(this._object, propertyPath);
+        super(object, propertyPath);
 
         this._object = object;
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to