Title: [182377] trunk/Source/WebCore
Revision
182377
Author
aes...@apple.com
Date
2015-04-05 22:24:21 -0700 (Sun, 05 Apr 2015)

Log Message

[Content Filtering] Only pass http(s) requests to -[NEFilterSource willSendRequest:...]
https://bugs.webkit.org/show_bug.cgi?id=143437

Reviewed by Dan Bernstein.

No new tests. We can't test NEFilterSource directly.

* platform/cocoa/NetworkExtensionContentFilter.mm:
(WebCore::NetworkExtensionContentFilter::willSendRequest): Immediately allow requests with url schemes other than http and https.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (182376 => 182377)


--- trunk/Source/WebCore/ChangeLog	2015-04-06 04:48:33 UTC (rev 182376)
+++ trunk/Source/WebCore/ChangeLog	2015-04-06 05:24:21 UTC (rev 182377)
@@ -1,3 +1,15 @@
+2015-04-05  Andy Estes  <aes...@apple.com>
+
+        [Content Filtering] Only pass http(s) requests to -[NEFilterSource willSendRequest:...]
+        https://bugs.webkit.org/show_bug.cgi?id=143437
+
+        Reviewed by Dan Bernstein.
+
+        No new tests. We can't test NEFilterSource directly.
+
+        * platform/cocoa/NetworkExtensionContentFilter.mm:
+        (WebCore::NetworkExtensionContentFilter::willSendRequest): Immediately allow requests with url schemes other than http and https.
+
 2015-04-05  Darin Adler  <da...@apple.com>
 
         FrameView code uses page() without null checking

Modified: trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm (182376 => 182377)


--- trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm	2015-04-06 04:48:33 UTC (rev 182376)
+++ trunk/Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm	2015-04-06 05:24:21 UTC (rev 182377)
@@ -76,6 +76,11 @@
 {
 #if HAVE(MODERN_NE_FILTER_SOURCE)
     ASSERT(!request.isNull());
+    if (!request.url().protocolIsInHTTPFamily()) {
+        m_status = NEFilterSourceStatusPass;
+        return;
+    }
+
     if (!redirectResponse.isNull()) {
         responseReceived(redirectResponse);
         if (!needsMoreData())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to