Title: [182666] trunk/Tools
Revision
182666
Author
a...@apple.com
Date
2015-04-11 22:05:18 -0700 (Sat, 11 Apr 2015)

Log Message

Use en_US spell checker for tests on Mac instead of Multilingual
https://bugs.webkit.org/show_bug.cgi?id=143641

Reviewed by Dan Bernstein.

* DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
While at it, override NSUserDictionaryReplacementItems, so that user replacements
cannot affect tests.

* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
Made this more like WebKit1 version.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (182665 => 182666)


--- trunk/Tools/ChangeLog	2015-04-12 02:23:26 UTC (rev 182665)
+++ trunk/Tools/ChangeLog	2015-04-12 05:05:18 UTC (rev 182666)
@@ -1,3 +1,17 @@
+2015-04-11  Alexey Proskuryakov  <a...@apple.com>
+
+        Use en_US spell checker for tests on Mac instead of Multilingual
+        https://bugs.webkit.org/show_bug.cgi?id=143641
+
+        Reviewed by Dan Bernstein.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
+        While at it, override NSUserDictionaryReplacementItems, so that user replacements
+        cannot affect tests.
+
+        * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
+        Made this more like WebKit1 version.
+
 2015-04-10  Tim Horton  <timothy_hor...@apple.com>
 
         Replace setFixedLayoutSizeEnabled: with an enum of layout modes

Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (182665 => 182666)


--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2015-04-12 02:23:26 UTC (rev 182665)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm	2015-04-12 05:05:18 UTC (rev 182666)
@@ -964,6 +964,8 @@
         WebKitFullScreenEnabledPreferenceKey: @YES,
         @"UseWebKitWebInspector": @YES,
 #if !PLATFORM(IOS)
+        @"NSPreferredSpellServerLanguage": @"en_US",
+        @"NSUserDictionaryReplacementItems": @[],
         @"NSTestCorrectionDictionary": @{
             @"notationl": @"notational",
             @"mesage": @"message",

Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm (182665 => 182666)


--- trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm	2015-04-12 02:23:26 UTC (rev 182665)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm	2015-04-12 05:05:18 UTC (rev 182666)
@@ -57,9 +57,14 @@
         // FIXME (<rdar://problem/13396515>): It is too late to set AppleLanguages here, as loaded frameworks localizations cannot be changed.
         // This breaks some accessibility tests on machines with non-English user language.
         @"AppleLanguages": @[ @"en" ],
-        // FIXME: Why does this dictionary not match the one in DumpRenderTree?
+        @"NSPreferredSpellServerLanguage": @"en_US",
+        @"NSUserDictionaryReplacementItems": @[],
         @"NSTestCorrectionDictionary": @{
-            @"notationl": @"notational"
+            @"notationl": @"notational",
+            @"mesage": @"message",
+            @"wouldn": @"would",
+            @"wellcome": @"welcome",
+            @"hellolfworld": @"hello\nworld"
         },
 #if __MAC_OS_X_VERSION_MIN_REQUIRED > 101000
         @"AppleSystemFontOSSubversion": @(10),
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to