- Revision
- 182830
- Author
- dba...@webkit.org
- Date
- 2015-04-14 18:59:39 -0700 (Tue, 14 Apr 2015)
Log Message
Rename test LayoutTests/fast/events/drag-link.html to drag-and-drop-link-into-focused-contenteditable.html
https://bugs.webkit.org/show_bug.cgi?id=143683
Reviewed by Alexey Proskuryakov.
The name of the test LayoutTests/fast/events/drag-link.html is too generic given its purpose, which is
to test that we do not cause an assertion failure when dragging and dropping an HTML hyperlink into
a focused content editable element. We should come up with a more descriptive name for this test that
better describes what it tests.
* fast/events/drag-and-drop-link-into-focused-contenteditable-expected.txt: Renamed from LayoutTests/fast/events/drag-link-expected.txt.
* fast/events/drag-and-drop-link-into-focused-contenteditable.html: Renamed from LayoutTests/fast/events/drag-link.html.
* platform/efl/TestExpectations: Update file because of the rename.
* platform/gtk/TestExpectations: Ditto.
* platform/ios-simulator/TestExpectations: Ditto.
* platform/mac-wk2/TestExpectations: Ditto.
Modified Paths
Added Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (182829 => 182830)
--- trunk/LayoutTests/ChangeLog 2015-04-15 01:39:05 UTC (rev 182829)
+++ trunk/LayoutTests/ChangeLog 2015-04-15 01:59:39 UTC (rev 182830)
@@ -1,3 +1,22 @@
+2015-04-14 Daniel Bates <daba...@apple.com>
+
+ Rename test LayoutTests/fast/events/drag-link.html to drag-and-drop-link-into-focused-contenteditable.html
+ https://bugs.webkit.org/show_bug.cgi?id=143683
+
+ Reviewed by Alexey Proskuryakov.
+
+ The name of the test LayoutTests/fast/events/drag-link.html is too generic given its purpose, which is
+ to test that we do not cause an assertion failure when dragging and dropping an HTML hyperlink into
+ a focused content editable element. We should come up with a more descriptive name for this test that
+ better describes what it tests.
+
+ * fast/events/drag-and-drop-link-into-focused-contenteditable-expected.txt: Renamed from LayoutTests/fast/events/drag-link-expected.txt.
+ * fast/events/drag-and-drop-link-into-focused-contenteditable.html: Renamed from LayoutTests/fast/events/drag-link.html.
+ * platform/efl/TestExpectations: Update file because of the rename.
+ * platform/gtk/TestExpectations: Ditto.
+ * platform/ios-simulator/TestExpectations: Ditto.
+ * platform/mac-wk2/TestExpectations: Ditto.
+
2015-04-14 Chris Dumez <cdu...@apple.com>
Regression(r180020): Web Inspector crashes on pages that have a stylesheet with an invalid MIME type
Copied: trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable-expected.txt (from rev 182829, trunk/LayoutTests/fast/events/drag-link-expected.txt) (0 => 182830)
--- trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable-expected.txt 2015-04-15 01:59:39 UTC (rev 182830)
@@ -0,0 +1,8 @@
+Test for bug 70277. This tests that a link is dragged and dropped properly in an already focused editable area. This test passes only if it does not hit an assertion.
+
+Test Link
+Editable area
+
+Test Link
+
+PASS
Copied: trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable.html (from rev 182829, trunk/LayoutTests/fast/events/drag-link.html) (0 => 182830)
--- trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable.html (rev 0)
+++ trunk/LayoutTests/fast/events/drag-and-drop-link-into-focused-contenteditable.html 2015-04-15 01:59:39 UTC (rev 182830)
@@ -0,0 +1,40 @@
+<!DOCTYPE html>
+<html>
+<body>
+<div>
+<p>Test for <a href="" 70277</a>.
+This tests that a link is dragged and dropped properly in an already focused editable area.
+This test passes only if it does not hit an assertion.
+</p>
+<a href=# id="anchorElement">Test Link</a>
+</div>
+<div id="editableDiv" contenteditable="true">
+<h3>Editable area</h3>
+<br>
+<br>
+</div>
+<div id="result">
+</div>
+<script>
+function dragElement(srcElement, destElement)
+{
+ eventSender.mouseMoveTo(srcElement.offsetLeft + srcElement.offsetWidth / 2,
+ srcElement.offsetTop + srcElement.offsetHeight / 2);
+ eventSender.mouseDown();
+ eventSender.leapForward(100);
+ eventSender.mouseMoveTo(destElement.offsetLeft + destElement.offsetWidth / 2,
+ destElement.offsetTop + destElement.offsetHeight / 2);
+ eventSender.mouseUp();
+
+ document.getElementById('result').innerHTML = "PASS";
+}
+
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+var editableDiv = document.getElementById('editableDiv');
+editableDiv.focus();
+dragElement(document.getElementById('anchorElement'), editableDiv);
+</script>
+</body>
+</html>
Deleted: trunk/LayoutTests/fast/events/drag-link-expected.txt (182829 => 182830)
--- trunk/LayoutTests/fast/events/drag-link-expected.txt 2015-04-15 01:39:05 UTC (rev 182829)
+++ trunk/LayoutTests/fast/events/drag-link-expected.txt 2015-04-15 01:59:39 UTC (rev 182830)
@@ -1,8 +0,0 @@
-Test for bug 70277. This tests that a link is dragged and dropped properly in an already focused editable area. This test passes only if it does not hit an assertion.
-
-Test Link
-Editable area
-
-Test Link
-
-PASS
Deleted: trunk/LayoutTests/fast/events/drag-link.html (182829 => 182830)
--- trunk/LayoutTests/fast/events/drag-link.html 2015-04-15 01:39:05 UTC (rev 182829)
+++ trunk/LayoutTests/fast/events/drag-link.html 2015-04-15 01:59:39 UTC (rev 182830)
@@ -1,40 +0,0 @@
-<!DOCTYPE html>
-<html>
-<body>
-<div>
-<p>Test for <a href="" 70277</a>.
-This tests that a link is dragged and dropped properly in an already focused editable area.
-This test passes only if it does not hit an assertion.
-</p>
-<a href=# id="anchorElement">Test Link</a>
-</div>
-<div id="editableDiv" contenteditable="true">
-<h3>Editable area</h3>
-<br>
-<br>
-</div>
-<div id="result">
-</div>
-<script>
-function dragElement(srcElement, destElement)
-{
- eventSender.mouseMoveTo(srcElement.offsetLeft + srcElement.offsetWidth / 2,
- srcElement.offsetTop + srcElement.offsetHeight / 2);
- eventSender.mouseDown();
- eventSender.leapForward(100);
- eventSender.mouseMoveTo(destElement.offsetLeft + destElement.offsetWidth / 2,
- destElement.offsetTop + destElement.offsetHeight / 2);
- eventSender.mouseUp();
-
- document.getElementById('result').innerHTML = "PASS";
-}
-
-if (window.testRunner)
- testRunner.dumpAsText();
-
-var editableDiv = document.getElementById('editableDiv');
-editableDiv.focus();
-dragElement(document.getElementById('anchorElement'), editableDiv);
-</script>
-</body>
-</html>
Modified: trunk/LayoutTests/platform/efl/TestExpectations (182829 => 182830)
--- trunk/LayoutTests/platform/efl/TestExpectations 2015-04-15 01:39:05 UTC (rev 182829)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2015-04-15 01:59:39 UTC (rev 182830)
@@ -343,7 +343,7 @@
webkit.org/b/86623 fast/events/drag-dataTransferItemList.html
webkit.org/b/86623 fast/events/drag-image-filename.html [ Timeout ]
webkit.org/b/86623 fast/events/drag-in-frames.html [ Failure ]
-webkit.org/b/86623 fast/events/drag-link.html [ Failure ]
+webkit.org/b/86623 fast/events/drag-and-drop-link-into-focused-contenteditable.html [ Failure ]
webkit.org/b/86623 fast/events/drag-parent-node.html [ Failure ]
webkit.org/b/86623 fast/events/drag-selects-image.html
webkit.org/b/86623 fast/events/dropzone-001.html
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (182829 => 182830)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2015-04-15 01:39:05 UTC (rev 182829)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2015-04-15 01:59:39 UTC (rev 182830)
@@ -1403,7 +1403,7 @@
webkit.org/b/63706 fast/events/drag-and-drop-fire-drag-dragover.html [ Failure ]
webkit.org/b/63706 fast/events/drag-and-drop.html [ Failure Timeout ]
webkit.org/b/63706 fast/events/drag-and-drop-subframe-dataTransfer.html [ Failure Timeout ]
-webkit.org/b/63706 fast/events/drag-link.html [ Failure ]
+webkit.org/b/63706 fast/events/drag-and-drop-link-into-focused-contenteditable.html [ Failure ]
webkit.org/b/63706 fast/events/drag-parent-node.html [ Failure ]
webkit.org/b/63706 fast/events/dropzone-001.html [ Failure Timeout ]
webkit.org/b/63706 fast/events/dropzone-002.html [ Failure Timeout ]
Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (182829 => 182830)
--- trunk/LayoutTests/platform/ios-simulator/TestExpectations 2015-04-15 01:39:05 UTC (rev 182829)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations 2015-04-15 01:59:39 UTC (rev 182830)
@@ -157,7 +157,7 @@
fast/events/drag-file-crash.html
fast/events/drag-image-filename.html
fast/events/drag-in-frames.html
-fast/events/drag-link.html
+fast/events/drag-and-drop-link-into-focused-contenteditable.html
fast/events/drag-outside-window.html
fast/events/drag-parent-node.html
fast/events/drag-selects-image.html
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (182829 => 182830)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2015-04-15 01:39:05 UTC (rev 182829)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2015-04-15 01:59:39 UTC (rev 182830)
@@ -162,7 +162,7 @@
fast/events/drag-selects-image.html
fast/events/remove-target-with-shadow-in-drag.html
-webkit.org/b/81833 fast/events/drag-link.html [ Failure ]
+webkit.org/b/81833 fast/events/drag-and-drop-link-into-focused-contenteditable.html [ Failure ]
# Missing functionality of textInputController
# https://bugs.webkit.org/show_bug.cgi?id=89401
