Title: [182892] trunk/Source/WebKit2
- Revision
- 182892
- Author
- commit-qu...@webkit.org
- Date
- 2015-04-16 10:28:34 -0700 (Thu, 16 Apr 2015)
Log Message
Remove PluginController::isPluginVisible().
https://bugs.webkit.org/show_bug.cgi?id=143830
Patch by Sungmann Cho <sungmann....@navercorp.com> on 2015-04-16
Reviewed by Darin Adler.
PluginController::isPluginVisible() was introduced by http://webkit.org/b/60285.
This method had been used only for WebKit2 on Windows, and no one uses it now.
So we can remove it.
No new tests, no behavior change.
* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::isPluginVisible): Deleted.
* PluginProcess/PluginControllerProxy.h:
* WebProcess/Plugins/PluginController.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::isPluginVisible): Deleted.
* WebProcess/Plugins/PluginView.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (182891 => 182892)
--- trunk/Source/WebKit2/ChangeLog 2015-04-16 17:03:23 UTC (rev 182891)
+++ trunk/Source/WebKit2/ChangeLog 2015-04-16 17:28:34 UTC (rev 182892)
@@ -1,3 +1,24 @@
+2015-04-16 Sungmann Cho <sungmann....@navercorp.com>
+
+ Remove PluginController::isPluginVisible().
+ https://bugs.webkit.org/show_bug.cgi?id=143830
+
+ Reviewed by Darin Adler.
+
+ PluginController::isPluginVisible() was introduced by http://webkit.org/b/60285.
+ This method had been used only for WebKit2 on Windows, and no one uses it now.
+ So we can remove it.
+
+ No new tests, no behavior change.
+
+ * PluginProcess/PluginControllerProxy.cpp:
+ (WebKit::PluginControllerProxy::isPluginVisible): Deleted.
+ * PluginProcess/PluginControllerProxy.h:
+ * WebProcess/Plugins/PluginController.h:
+ * WebProcess/Plugins/PluginView.cpp:
+ (WebKit::PluginView::isPluginVisible): Deleted.
+ * WebProcess/Plugins/PluginView.h:
+
2015-04-16 Gyuyoung Kim <gyuyoung....@webkit.org>
[EFL] Disable a flaky ewk_context_network_process_model() API test
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp (182891 => 182892)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2015-04-16 17:03:23 UTC (rev 182891)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp 2015-04-16 17:28:34 UTC (rev 182892)
@@ -220,13 +220,6 @@
m_waitingForDidUpdate = true;
}
-bool PluginControllerProxy::isPluginVisible()
-{
- // FIXME: Implement this.
- notImplemented();
- return false;
-}
-
void PluginControllerProxy::invalidate(const IntRect& rect)
{
IntRect dirtyRect = rect;
Modified: trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h (182891 => 182892)
--- trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h 2015-04-16 17:03:23 UTC (rev 182891)
+++ trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h 2015-04-16 17:28:34 UTC (rev 182892)
@@ -83,7 +83,6 @@
void paint();
// PluginController
- virtual bool isPluginVisible() override;
virtual void invalidate(const WebCore::IntRect&) override;
virtual String userAgent() override;
virtual void loadURL(uint64_t requestID, const String& method, const String& urlString, const String& target, const WebCore::HTTPHeaderMap& headerFields, const Vector<uint8_t>& httpBody, bool allowPopups) override;
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginController.h (182891 => 182892)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginController.h 2015-04-16 17:03:23 UTC (rev 182891)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginController.h 2015-04-16 17:28:34 UTC (rev 182892)
@@ -48,9 +48,6 @@
class PluginController {
public:
- // Returns false if the plugin has explicitly been hidden. Returns true otherwise (even if the plugin is currently obscured from view on screen.)
- virtual bool isPluginVisible() = 0;
-
// Tells the controller that the plug-in wants the given rect to be repainted. The rect is in the plug-in's coordinate system.
virtual void invalidate(const WebCore::IntRect&) = 0;
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (182891 => 182892)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2015-04-16 17:03:23 UTC (rev 182891)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp 2015-04-16 17:28:34 UTC (rev 182892)
@@ -1340,11 +1340,6 @@
#endif
}
-bool PluginView::isPluginVisible()
-{
- return isVisible();
-}
-
void PluginView::invalidate(const IntRect& dirtyRect)
{
invalidateRect(dirtyRect);
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h (182891 => 182892)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h 2015-04-16 17:03:23 UTC (rev 182891)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h 2015-04-16 17:28:34 UTC (rev 182892)
@@ -186,7 +186,6 @@
virtual void pageMutedStateDidChange() override;
// PluginController
- virtual bool isPluginVisible() override;
virtual void invalidate(const WebCore::IntRect&) override;
virtual String userAgent() override;
virtual void loadURL(uint64_t requestID, const String& method, const String& urlString, const String& target, const WebCore::HTTPHeaderMap& headerFields, const Vector<uint8_t>& httpBody, bool allowPopups) override;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
