Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (182989 => 182990)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-19 04:20:46 UTC (rev 182990)
@@ -1,5 +1,45 @@
2015-04-18 Nikita Vasilyev <nvasil...@apple.com>
+ Web Inspector: Pass multiple arguments to classList.add and classList.remove
+ https://bugs.webkit.org/show_bug.cgi?id=143914
+
+ classList.add and classList.remove can accept multiple arguments, use that.
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector.updateDockedState):
+ * UserInterface/Views/DOMTreeDataGrid.js:
+ (WebInspector.DOMTreeDataGrid):
+ * UserInterface/Views/DOMTreeOutline.js:
+ (WebInspector.DOMTreeOutline):
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGridNode.prototype.set hasChildren):
+ * UserInterface/Views/DatabaseContentView.js:
+ (WebInspector.DatabaseContentView):
+ * UserInterface/Views/DetailsSection.js:
+ (WebInspector.DetailsSection):
+ * UserInterface/Views/DetailsSectionPropertiesRow.js:
+ (WebInspector.DetailsSectionPropertiesRow):
+ * UserInterface/Views/GeneralTreeElement.js:
+ (WebInspector.GeneralTreeElement.prototype.set classNames):
+ * UserInterface/Views/NavigationItem.js:
+ (WebInspector.NavigationItem):
+ * UserInterface/Views/ResourceContentView.js:
+ (WebInspector.ResourceContentView):
+ * UserInterface/Views/ResourceTimelineDataGridNode.js:
+ (WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
+ * UserInterface/Views/Sidebar.js:
+ (WebInspector.Sidebar):
+ * UserInterface/Views/SidebarPanel.js:
+ (WebInspector.SidebarPanel):
+ * UserInterface/Views/SourceCodeTextEditor.js:
+ * UserInterface/Views/TextEditor.js:
+ (WebInspector.TextEditor):
+ * UserInterface/Views/TimelineRuler.js:
+
+2015-04-18 Nikita Vasilyev <nvasil...@apple.com>
+
Web Inspector: Make prototype pill’s background semi-transparent
https://bugs.webkit.org/show_bug.cgi?id=143928
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -457,27 +457,19 @@
this._ignoreToolbarModeDidChangeEvents = true;
if (side === "bottom") {
- document.body.classList.add("docked");
- document.body.classList.add("bottom");
+ document.body.classList.add("docked", "bottom");
+ document.body.classList.remove("window-inactive", "right");
- document.body.classList.remove("window-inactive");
- document.body.classList.remove("right");
-
this.toolbar.displayMode = this._toolbarDockedBottomDisplayModeSetting.value;
this.toolbar.sizeMode = this._toolbarDockedBottomSizeModeSetting.value;
} else if (side === "right") {
- document.body.classList.add("docked");
- document.body.classList.add("right");
+ document.body.classList.add("docked", "right");
+ document.body.classList.remove("window-inactive", "bottom");
- document.body.classList.remove("window-inactive");
- document.body.classList.remove("bottom");
-
this.toolbar.displayMode = this._toolbarDockedRightDisplayModeSetting.value;
this.toolbar.sizeMode = this._toolbarDockedRightSizeModeSetting.value;
} else {
- document.body.classList.remove("docked");
- document.body.classList.remove("right");
- document.body.classList.remove("bottom");
+ document.body.classList.remove("docked", "right", "bottom");
this.toolbar.displayMode = this._toolbarUndockedDisplayModeSetting.value;
this.toolbar.sizeMode = this._toolbarUndockedSizeModeSetting.value;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -30,8 +30,7 @@
this._previousHoveredElement = null;
- this.element.classList.add("dom-tree-data-grid");
- this.element.classList.add("inline");
+ this.element.classList.add("inline", "dom-tree-data-grid");
this.element.addEventListener("mousemove", this._onmousemove.bind(this), false);
this.element.addEventListener("mouseout", this._onmouseout.bind(this), false);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -45,8 +45,7 @@
element.addEventListener("drop", this._ondrop.bind(this), false);
element.addEventListener("dragend", this._ondragend.bind(this), false);
- element.classList.add("dom-tree-outline");
- element.classList.add(WebInspector.SyntaxHighlightedStyleClassName);
+ element.classList.add("dom-tree-outline", WebInspector.SyntaxHighlightedStyleClassName);
this._includeRootDOMNode = !omitRootDOMNode;
this._selectEnabled = selectEnabled;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -1454,8 +1454,7 @@
}
else
{
- this._element.classList.remove("parent");
- this._element.classList.remove("expanded");
+ this._element.classList.remove("parent", "expanded");
}
},
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -29,9 +29,7 @@
this.database = representedObject;
- this.element.classList.add("storage-view");
- this.element.classList.add("query");
- this.element.classList.add("monospace");
+ this.element.classList.add("storage-view", "query", "monospace");
this._promptElement = document.createElement("div");
this._promptElement.className = "database-query-prompt";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -32,8 +32,7 @@
console.assert(identifier);
this._element = document.createElement("div");
- this._element.className = WebInspector.DetailsSection.StyleClassName;
- this._element.classList.add(identifier);
+ this._element.classList.add(identifier, "details-section");
this._headerElement = document.createElement("div");
this._headerElement.addEventListener("click", this._headerElementClicked.bind(this));
@@ -161,7 +160,6 @@
}
};
-WebInspector.DetailsSection.StyleClassName = "details-section";
WebInspector.DetailsSection.HeaderElementStyleClassName = "header";
WebInspector.DetailsSection.TitleElementStyleClassName = "title";
WebInspector.DetailsSection.ContentElementStyleClassName = "content";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSectionPropertiesRow.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSectionPropertiesRow.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSectionPropertiesRow.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -29,8 +29,7 @@
{
super(emptyMessage);
- this.element.classList.add("properties");
- this.element.classList.add(WebInspector.SyntaxHighlightedStyleClassName);
+ this.element.classList.add("properties", WebInspector.SyntaxHighlightedStyleClassName);
this.propertiesSection = propertiesSection;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -77,8 +77,7 @@
set classNames(x)
{
if (this._listItemNode && this._classNames) {
- for (var i = 0; i < this._classNames.length; ++i)
- this._listItemNode.classList.remove(this._classNames[i]);
+ this._listItemNode.classList.remove(...this._classNames);
}
if (typeof x === "string")
@@ -87,8 +86,7 @@
this._classNames = x || [];
if (this._listItemNode) {
- for (var i = 0; i < this._classNames.length; ++i)
- this._listItemNode.classList.add(this._classNames[i]);
+ this._listItemNode.classList.add(...this._classNames);
}
}
@@ -222,8 +220,7 @@
this._listItemNode.classList.add("item");
if (this._classNames) {
- for (var i = 0; i < this._classNames.length; ++i)
- this._listItemNode.classList.add(this._classNames[i]);
+ this._listItemNode.classList.add(...this._classNames);
}
if (this._small)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationItem.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationItem.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationItem.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -37,10 +37,7 @@
if (label)
this._element.setAttribute("aria-label", label);
- var classNames = this._classNames;
- for (var i = 0; i < classNames.length; ++i)
- this._element.classList.add(classNames[i]);
-
+ this._element.classList.add(...this._classNames);
this._element.navigationItem = this;
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceContentView.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -32,8 +32,7 @@
this._resource = resource;
- this.element.classList.add(WebInspector.ResourceContentView.StyleClassName);
- this.element.classList.add(styleClassName);
+ this.element.classList.add(styleClassName, "resource");
// Append a spinner while waiting for contentAvailable. The subclasses are responsible for removing
// the spinner before showing the resource content.
@@ -54,8 +53,6 @@
}
};
-WebInspector.ResourceContentView.StyleClassName = "resource";
-
WebInspector.ResourceContentView.prototype = {
constructor: WebInspector.ResourceContentView,
__proto__: WebInspector.ContentView.prototype,
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -107,8 +107,7 @@
switch (columnIdentifier) {
case "name":
- cell.classList.add(WebInspector.ResourceTreeElement.ResourceIconStyleClassName);
- cell.classList.add(resource.type);
+ cell.classList.add(resource.type, WebInspector.ResourceTreeElement.ResourceIconStyleClassName);
var fragment = document.createDocumentFragment();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -33,9 +33,7 @@
this._side = side || WebInspector.Sidebar.Sides.Left;
this._element = element || document.createElement("div");
- this._element.classList.add("sidebar");
- this._element.classList.add(WebInspector.Sidebar.CollapsedStyleClassName);
- this._element.classList.add(this._side);
+ this._element.classList.add("sidebar", this._side, WebInspector.Sidebar.CollapsedStyleClassName);
this._element.setAttribute("role", role || "group");
if (label)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SidebarPanel.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -36,8 +36,7 @@
this._toolbarItem.enabled = false;
this._element = element || document.createElement("div");
- this._element.classList.add("panel");
- this._element.classList.add(identifier);
+ this._element.classList.add("panel", identifier);
this._element.setAttribute("role", role || "group");
this._element.setAttribute("aria-label", label || displayName);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -840,8 +840,7 @@
return null;
var widgetElement = widget.widgetElement;
- widgetElement.classList.add("issue-widget");
- widgetElement.classList.add("inline");
+ widgetElement.classList.add("issue-widget", "inline");
widgetElement.addEventListener("click", this._handleWidgetClick.bind(this, widget, lineNumber));
this._widgetMap.set(lineNumber, widget);
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -30,8 +30,7 @@
super();
this._element = element || document.createElement("div");
- this._element.classList.add("text-editor");
- this._element.classList.add(WebInspector.SyntaxHighlightedStyleClassName);
+ this._element.classList.add("text-editor", WebInspector.SyntaxHighlightedStyleClassName);
this._codeMirror = CodeMirror(this.element, {
readOnly: true,
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js (182989 => 182990)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js 2015-04-19 04:19:54 UTC (rev 182989)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js 2015-04-19 04:20:46 UTC (rev 182990)
@@ -291,8 +291,7 @@
marker.addEventListener(WebInspector.TimelineMarker.Event.TimeChanged, this._timelineMarkerTimeChanged, this);
var markerElement = document.createElement("div");
- markerElement.classList.add(WebInspector.TimelineRuler.BaseMarkerElementStyleClassName);
- markerElement.classList.add(marker.type);
+ markerElement.classList.add(marker.type, WebInspector.TimelineRuler.BaseMarkerElementStyleClassName);
this._markerElementMap.set(marker, markerElement);
