Title: [183680] trunk
Revision
183680
Author
mrobin...@webkit.org
Date
2015-05-01 10:50:49 -0700 (Fri, 01 May 2015)

Log Message

[Freetype] Properly support synthetic oblique in vertical text
https://bugs.webkit.org/show_bug.cgi?id=144492

Reviewed by Sergio Villar Senin.

Source/WebCore:

No new tests. Covered by existing tests.

* platform/graphics/freetype/FontPlatformDataFreeType.cpp:
(WebCore::FontPlatformData::initializeWithFontFace): Skew vertical when using synthetic
oblique for vertical text.

LayoutTests:

* platform/gtk/TestExpectations: Unskip passing tests.
* platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.png: Added.
* platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (183679 => 183680)


--- trunk/LayoutTests/ChangeLog	2015-05-01 17:14:37 UTC (rev 183679)
+++ trunk/LayoutTests/ChangeLog	2015-05-01 17:50:49 UTC (rev 183680)
@@ -1,3 +1,14 @@
+2015-05-01  Martin Robinson  <mrobin...@igalia.com>
+
+        [Freetype] Properly support synthetic oblique in vertical text
+        https://bugs.webkit.org/show_bug.cgi?id=144492
+
+        Reviewed by Sergio Villar Senin.
+
+        * platform/gtk/TestExpectations: Unskip passing tests.
+        * platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.png: Added.
+        * platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Added.
+
 2015-05-01  Eric Carlson  <eric.carl...@apple.com>
 
         Fix text track language selection logic

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (183679 => 183680)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-05-01 17:14:37 UTC (rev 183679)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-05-01 17:50:49 UTC (rev 183680)
@@ -424,9 +424,6 @@
 # No concept of secure text input
 Bug(GTK) editing/secure-input [ Failure ]
 
-# Synthesized italics not supported
-webkit.org/b/117975 fast/text/international/synthesized-italic-vertical-latin.html [ Skip ]
-
 # crypto.subtle is not yet enabled, but digest algorithms are already implemented
 # and their tests are whitelisted
 webkit.org/b/133122 crypto/subtle [ Skip ]
@@ -2005,8 +2002,6 @@
 
 webkit.org/b/118221 fast/text/complex-first-glyph-with-initial-advance.html [ ImageOnlyFailure ]
 
-webkit.org/b/118222 fast/text/international/synthesized-italic-vertical.html [ ImageOnlyFailure ]
-
 webkit.org/b/118416 storage/websql/sql-error-codes.html [ Failure ]
 
 # May take too long on the bots.

Added: trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.png


(Binary files differ)
Property changes on: trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.png ___________________________________________________________________

Added: svn:mime-type

Added: trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt (0 => 183680)


--- trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt	2015-05-01 17:50:49 UTC (rev 183680)
@@ -0,0 +1,8 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 93x600
+  RenderBlock {HTML} at (0,0) size 93x600
+    RenderBody {BODY} at (30,8) size 33x584
+      RenderBlock {P} at (0,0) size 33x584
+        RenderText {#text} at (0,0) size 33x376
+          text run at (0,0) width 376: "ABC\x{4E39}\x{7FBD} \x{4EAE}\x{4ECB}ABC\x{4E39}\x{7FBD} \x{4EAE}\x{4ECB}"
Property changes on: trunk/LayoutTests/platform/gtk/fast/text/international/synthesized-italic-vertical-latin-expected.txt
___________________________________________________________________

Added: svn:eol-style

Modified: trunk/Source/WebCore/ChangeLog (183679 => 183680)


--- trunk/Source/WebCore/ChangeLog	2015-05-01 17:14:37 UTC (rev 183679)
+++ trunk/Source/WebCore/ChangeLog	2015-05-01 17:50:49 UTC (rev 183680)
@@ -1,3 +1,16 @@
+2015-05-01  Martin Robinson  <mrobin...@igalia.com>
+
+        [Freetype] Properly support synthetic oblique in vertical text
+        https://bugs.webkit.org/show_bug.cgi?id=144492
+
+        Reviewed by Sergio Villar Senin.
+
+        No new tests. Covered by existing tests.
+
+        * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
+        (WebCore::FontPlatformData::initializeWithFontFace): Skew vertical when using synthetic
+        oblique for vertical text.
+
 2015-05-01  Joanmarie Diggs  <jdi...@igalia.com>
 
         AX: [ATK] REGRESSION: accessibility/canvas-fallback-content.html now crashes

Modified: trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp (183679 => 183680)


--- trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp	2015-05-01 17:14:37 UTC (rev 183679)
+++ trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp	2015-05-01 17:50:49 UTC (rev 183680)
@@ -339,8 +339,9 @@
 
     if (syntheticOblique()) {
         static const float syntheticObliqueSkew = -tanf(14 * acosf(0) / 90);
-        cairo_matrix_t skew = {1, 0, syntheticObliqueSkew, 1, 0, 0};
-        cairo_matrix_multiply(&fontMatrix, &skew, &fontMatrix);
+        static const cairo_matrix_t skew = {1, 0, syntheticObliqueSkew, 1, 0, 0};
+        static const cairo_matrix_t verticalSkew = {1, -syntheticObliqueSkew, 0, 1, 0, 0};
+        cairo_matrix_multiply(&fontMatrix, m_orientation == Vertical ? &verticalSkew : &skew, &fontMatrix);
     }
 
     m_horizontalOrientationMatrix = fontMatrix;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to