Title: [183900] trunk
- Revision
- 183900
- Author
- commit-qu...@webkit.org
- Date
- 2015-05-06 17:26:48 -0700 (Wed, 06 May 2015)
Log Message
Unreviewed, rolling out r183894.
https://bugs.webkit.org/show_bug.cgi?id=144719
crashes on mavericks (Requested by dino on #webkit).
Reverted changeset:
"Handle backdrop views that have to tile"
https://bugs.webkit.org/show_bug.cgi?id=142317
http://trac.webkit.org/changeset/183894
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (183899 => 183900)
--- trunk/LayoutTests/ChangeLog 2015-05-06 23:42:45 UTC (rev 183899)
+++ trunk/LayoutTests/ChangeLog 2015-05-07 00:26:48 UTC (rev 183900)
@@ -1,3 +1,16 @@
+2015-05-06 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r183894.
+ https://bugs.webkit.org/show_bug.cgi?id=144719
+
+ crashes on mavericks (Requested by dino on #webkit).
+
+ Reverted changeset:
+
+ "Handle backdrop views that have to tile"
+ https://bugs.webkit.org/show_bug.cgi?id=142317
+ http://trac.webkit.org/changeset/183894
+
2015-05-06 Jon Lee <jon...@apple.com>
Expose more font weights for -apple-system
Deleted: trunk/LayoutTests/compositing/media-controls-bar-appearance-big-expected.txt (183899 => 183900)
--- trunk/LayoutTests/compositing/media-controls-bar-appearance-big-expected.txt 2015-05-06 23:42:45 UTC (rev 183899)
+++ trunk/LayoutTests/compositing/media-controls-bar-appearance-big-expected.txt 2015-05-07 00:26:48 UTC (rev 183900)
@@ -1,23 +0,0 @@
-(GraphicsLayer
- (anchor 0.00 0.00)
- (bounds 2056.00 4117.00)
- (children 1
- (GraphicsLayer
- (bounds 2056.00 4117.00)
- (contentsOpaque 1)
- (children 2
- (GraphicsLayer
- (position 8.00 8.00)
- (bounds 2048.00 2048.00)
- (drawsContent 1)
- )
- (GraphicsLayer
- (position 8.00 2056.00)
- (bounds 2048.00 2048.00)
- (drawsContent 1)
- )
- )
- )
- )
-)
-
Deleted: trunk/LayoutTests/compositing/media-controls-bar-appearance-big.html (183899 => 183900)
--- trunk/LayoutTests/compositing/media-controls-bar-appearance-big.html 2015-05-06 23:42:45 UTC (rev 183899)
+++ trunk/LayoutTests/compositing/media-controls-bar-appearance-big.html 2015-05-07 00:26:48 UTC (rev 183900)
@@ -1,56 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
- <style>
- div {
- position: relative;
- height: 100px;
- width: 100px;
- }
- .big {
- width: 2048px;
- height: 2048px;
- }
- .media-controls {
- -webkit-transform: translate3d(0, 0, 0); /* The element has to request a layer for the appearance to work */
- }
- .dark {
- -webkit-appearance: media-controls-dark-bar-background;
- }
- .light {
- -webkit-appearance: media-controls-light-bar-background;
- }
- </style>
- <script>
- if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.waitUntilDone();
- }
-
- function change()
- {
- var elements = document.querySelectorAll(".media-controls");
- for (var i = 0; i < elements.length; ++i)
- elements[i].classList.add("big");
- setTimeout(dumpLayers, 0);
- }
-
- function dumpLayers()
- {
- var layersResult = document.getElementById('layers');
- if (window.testRunner) {
- layersResult.innerText = window.internals.layerTreeAsText(document);
- testRunner.notifyDone();
- }
- }
- window.addEventListener('load', change, false)
- </script>
-</head>
-<body>
- <div class="media-controls dark">
- </div>
- <div class="media-controls light">
- </div>
-<pre id="layers"></pre>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (183899 => 183900)
--- trunk/Source/WebCore/ChangeLog 2015-05-06 23:42:45 UTC (rev 183899)
+++ trunk/Source/WebCore/ChangeLog 2015-05-07 00:26:48 UTC (rev 183900)
@@ -1,3 +1,16 @@
+2015-05-06 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r183894.
+ https://bugs.webkit.org/show_bug.cgi?id=144719
+
+ crashes on mavericks (Requested by dino on #webkit).
+
+ Reverted changeset:
+
+ "Handle backdrop views that have to tile"
+ https://bugs.webkit.org/show_bug.cgi?id=142317
+ http://trac.webkit.org/changeset/183894
+
2015-05-06 Jon Lee <jon...@apple.com>
CoreTextSPI.h uses wrong version number to denote Yosemite
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (183899 => 183900)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2015-05-06 23:42:45 UTC (rev 183899)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2015-05-07 00:26:48 UTC (rev 183900)
@@ -1438,10 +1438,10 @@
bool needBackdropLayerType = (customAppearance() == LightBackdropAppearance || customAppearance() == DarkBackdropAppearance);
PlatformCALayer::LayerType neededLayerType = m_layer->layerType();
- if (needBackdropLayerType)
+ if (needTiledLayer)
+ neededLayerType = PlatformCALayer::LayerTypeTiledBackingLayer;
+ else if (needBackdropLayerType)
neededLayerType = layerTypeForCustomBackdropAppearance(customAppearance());
- else if (needTiledLayer)
- neededLayerType = PlatformCALayer::LayerTypeTiledBackingLayer;
else if (isCustomBackdropLayerType(m_layer->layerType()) || m_usingTiledBacking)
neededLayerType = PlatformCALayer::LayerTypeWebLayer;
Modified: trunk/Source/WebKit2/ChangeLog (183899 => 183900)
--- trunk/Source/WebKit2/ChangeLog 2015-05-06 23:42:45 UTC (rev 183899)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-07 00:26:48 UTC (rev 183900)
@@ -1,3 +1,16 @@
+2015-05-06 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r183894.
+ https://bugs.webkit.org/show_bug.cgi?id=144719
+
+ crashes on mavericks (Requested by dino on #webkit).
+
+ Reverted changeset:
+
+ "Handle backdrop views that have to tile"
+ https://bugs.webkit.org/show_bug.cgi?id=142317
+ http://trac.webkit.org/changeset/183894
+
2015-05-06 Brady Eidson <beid...@apple.com>
Addition review followup for:
Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm (183899 => 183900)
--- trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm 2015-05-06 23:42:45 UTC (rev 183899)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerTreeTransaction.mm 2015-05-07 00:26:48 UTC (rev 183900)
@@ -666,7 +666,6 @@
RemoteLayerTreeTextStream& operator<<(const FilterOperations&);
RemoteLayerTreeTextStream& operator<<(const PlatformCAAnimationRemote::Properties&);
RemoteLayerTreeTextStream& operator<<(const RemoteLayerBackingStore&);
- RemoteLayerTreeTextStream& operator<<(const WebCore::GraphicsLayer::CustomAppearance&);
RemoteLayerTreeTextStream& operator<<(BlendMode);
RemoteLayerTreeTextStream& operator<<(PlatformCAAnimation::AnimationType);
RemoteLayerTreeTextStream& operator<<(PlatformCAAnimation::FillModeType);
@@ -838,19 +837,6 @@
return ts;
}
-RemoteLayerTreeTextStream& RemoteLayerTreeTextStream::operator<<(const WebCore::GraphicsLayer::CustomAppearance& customAppearance)
-{
- RemoteLayerTreeTextStream& ts = *this;
- switch (customAppearance) {
- case WebCore::GraphicsLayer::CustomAppearance::NoCustomAppearance: ts << "none"; break;
- case WebCore::GraphicsLayer::CustomAppearance::ScrollingOverhang: ts << "scrolling-overhang"; break;
- case WebCore::GraphicsLayer::CustomAppearance::ScrollingShadow: ts << "scrolling-shadow"; break;
- case WebCore::GraphicsLayer::CustomAppearance::LightBackdropAppearance: ts << "light-backdrop"; break;
- case WebCore::GraphicsLayer::CustomAppearance::DarkBackdropAppearance: ts << "dark-backdrop"; break;
- }
- return ts;
-}
-
RemoteLayerTreeTextStream& RemoteLayerTreeTextStream::operator<<(BlendMode blendMode)
{
RemoteLayerTreeTextStream& ts = *this;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
