Title: [183903] trunk/Source/WebKit2
- Revision
- 183903
- Author
- commit-qu...@webkit.org
- Date
- 2015-05-06 18:23:12 -0700 (Wed, 06 May 2015)
Log Message
[WK2] Simplify AsyncRequestImpl::ArgumentType parameters
https://bugs.webkit.org/show_bug.cgi?id=144689
Patch by Joonghun Park <jh718.p...@samsung.com> on 2015-05-06
Reviewed by Darin Adler.
Remove duplicated typename and ::type from AsyncRequestImpl related
function parameters.
* Shared/AsyncRequest.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (183902 => 183903)
--- trunk/Source/WebKit2/ChangeLog 2015-05-07 00:59:05 UTC (rev 183902)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-07 01:23:12 UTC (rev 183903)
@@ -1,3 +1,15 @@
+2015-05-06 Joonghun Park <jh718.p...@samsung.com>
+
+ [WK2] Simplify AsyncRequestImpl::ArgumentType parameters
+ https://bugs.webkit.org/show_bug.cgi?id=144689
+
+ Reviewed by Darin Adler.
+
+ Remove duplicated typename and ::type from AsyncRequestImpl related
+ function parameters.
+
+ * Shared/AsyncRequest.h:
+
2015-05-06 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r183894.
Modified: trunk/Source/WebKit2/Shared/AsyncRequest.h (183902 => 183903)
--- trunk/Source/WebKit2/Shared/AsyncRequest.h 2015-05-07 00:59:05 UTC (rev 183902)
+++ trunk/Source/WebKit2/Shared/AsyncRequest.h 2015-05-07 01:23:12 UTC (rev 183903)
@@ -58,14 +58,14 @@
template <typename... Arguments>
class AsyncRequestImpl final : public AsyncRequest {
public:
- template<typename T> using ArgumentType = std::conditional<std::is_integral<T>::value, T, const T&>;
+ template<typename T> using ArgumentType = typename std::conditional<std::is_integral<T>::value, T, const T&>::type;
- static PassRefPtr<AsyncRequest> create(std::function<void (typename ArgumentType<Arguments>::type...)> completionHandler)
+ static PassRefPtr<AsyncRequest> create(std::function<void (ArgumentType<Arguments>...)> completionHandler)
{
return adoptRef(new AsyncRequestImpl<Arguments...>(WTF::move(completionHandler), nullptr));
}
- static PassRefPtr<AsyncRequest> create(std::function<void (typename ArgumentType<Arguments>::type...)> completionHandler, std::function<void ()> abortHandler)
+ static PassRefPtr<AsyncRequest> create(std::function<void (ArgumentType<Arguments>...)> completionHandler, std::function<void ()> abortHandler)
{
return adoptRef(new AsyncRequestImpl<Arguments...>(WTF::move(completionHandler), WTF::move(abortHandler)));
}
@@ -83,7 +83,7 @@
}
private:
- AsyncRequestImpl(std::function<void (typename ArgumentType<Arguments>::type...)> completionHandler, std::function<void ()> abortHandler)
+ AsyncRequestImpl(std::function<void (ArgumentType<Arguments>...)> completionHandler, std::function<void ()> abortHandler)
: AsyncRequest(WTF::move(abortHandler))
, m_completionHandler(WTF::move(completionHandler))
{
@@ -95,7 +95,7 @@
m_completionHandler = nullptr;
}
- std::function<void (typename ArgumentType<Arguments>::type...)> m_completionHandler;
+ std::function<void (ArgumentType<Arguments>...)> m_completionHandler;
};
template<typename... Arguments> void AsyncRequest::completeRequest(Arguments&&... arguments)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
