Title: [184063] trunk
- Revision
- 184063
- Author
- commit-qu...@webkit.org
- Date
- 2015-05-10 20:07:09 -0700 (Sun, 10 May 2015)
Log Message
CMake defines CAIROGL_FOUND, not CAIRO_GL_FOUND
https://bugs.webkit.org/show_bug.cgi?id=144846
Patch by Philip Chimento <philip.chime...@gmail.com> on 2015-05-10
Reviewed by Martin Robinson.
* Source/cmake/FindCairoGL.cmake: Use CAIROGL_* instead of
CAIRO_GL_* throughout, because find_package will define
CAIROGL_FOUND.
* Source/cmake/OptionsGTK.cmake: Ditto.
Modified Paths
Diff
Modified: trunk/ChangeLog (184062 => 184063)
--- trunk/ChangeLog 2015-05-11 03:03:07 UTC (rev 184062)
+++ trunk/ChangeLog 2015-05-11 03:07:09 UTC (rev 184063)
@@ -1,5 +1,17 @@
2015-05-10 Philip Chimento <philip.chime...@gmail.com>
+ CMake defines CAIROGL_FOUND, not CAIRO_GL_FOUND
+ https://bugs.webkit.org/show_bug.cgi?id=144846
+
+ Reviewed by Martin Robinson.
+
+ * Source/cmake/FindCairoGL.cmake: Use CAIROGL_* instead of
+ CAIRO_GL_* throughout, because find_package will define
+ CAIROGL_FOUND.
+ * Source/cmake/OptionsGTK.cmake: Ditto.
+
+2015-05-10 Philip Chimento <philip.chime...@gmail.com>
+
[CMake] Some macros need to be defined/undefined, rather than ON/OFF
https://bugs.webkit.org/show_bug.cgi?id=144845
Modified: trunk/Source/cmake/FindCairoGL.cmake (184062 => 184063)
--- trunk/Source/cmake/FindCairoGL.cmake 2015-05-11 03:03:07 UTC (rev 184062)
+++ trunk/Source/cmake/FindCairoGL.cmake 2015-05-11 03:07:09 UTC (rev 184063)
@@ -1,9 +1,9 @@
# - Try to find CairoGL
# Once done, this will define
#
-# CAIRO_GL_FOUND - system has CairoGL
-# CAIRO_GL_INCLUDE_DIRS - the CairoGL include directories
-# CAIRO_GL_LIBRARIES - link these to use CairoGL
+# CAIROGL_FOUND - system has CairoGL
+# CAIROGL_INCLUDE_DIRS - the CairoGL include directories
+# CAIROGL_LIBRARIES - link these to use CairoGL
#
# Copyright (C) 2014 Igalia S.L.
#
@@ -29,18 +29,18 @@
# ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
find_package(PkgConfig)
-pkg_check_modules(CAIRO_GL cairo-gl)
+pkg_check_modules(CAIROGL cairo-gl)
# At the moment CairoGL does not add any extra cflags and libraries, so we can
-# safely ignore CAIRO_GL_LIBRARIES and CAIRO_GL_INCLUDE_DIRS for the moment.
+# safely ignore CAIROGL_LIBRARIES and CAIROGL_INCLUDE_DIRS for the moment.
foreach (_component ${CairoGL_FIND_COMPONENTS})
string(TOUPPER ${_component} _UPPER_NAME)
string(REGEX REPLACE "-" "_" _UPPER_NAME ${_UPPER_NAME})
pkg_check_modules(${_UPPER_NAME} ${_component})
- set(CAIRO_GL_INCLUDE_DIRS ${CAIRO_GL_INCLUDE_DIRS} ${_UPPER_NAME}_INCLUDE_DIRS)
- set(CAIRO_GL_LIBRARIES ${CAIRO_GL_LIBRARIES} ${_UPPER_NAME}_LIBRARIES)
+ set(CAIROGL_INCLUDE_DIRS ${CAIROGL_INCLUDE_DIRS} ${_UPPER_NAME}_INCLUDE_DIRS)
+ set(CAIROGL_LIBRARIES ${CAIROGL_LIBRARIES} ${_UPPER_NAME}_LIBRARIES)
endforeach ()
include(FindPackageHandleStandardArgs)
-find_package_handle_standard_args(CairoGL DEFAULT_MSG CAIRO_GL_INCLUDE_DIRS CAIRO_GL_LIBRARIES)
+find_package_handle_standard_args(CairoGL DEFAULT_MSG CAIROGL_INCLUDE_DIRS CAIROGL_LIBRARIES)
Modified: trunk/Source/cmake/OptionsGTK.cmake (184062 => 184063)
--- trunk/Source/cmake/OptionsGTK.cmake 2015-05-11 03:03:07 UTC (rev 184062)
+++ trunk/Source/cmake/OptionsGTK.cmake 2015-05-11 03:07:09 UTC (rev 184063)
@@ -102,12 +102,12 @@
CMAKE_POP_CHECK_STATE()
if (GLX_FOUND)
- list(APPEND CAIRO_GL_COMPONENTS cairo-glx)
+ list(APPEND CAIROGL_COMPONENTS cairo-glx)
endif ()
if (EGL_FOUND)
- list(APPEND CAIRO_GL_COMPONENTS cairo-egl)
+ list(APPEND CAIROGL_COMPONENTS cairo-egl)
endif ()
- find_package(CairoGL 1.10.2 COMPONENTS ${CAIRO_GL_COMPONENTS})
+ find_package(CairoGL 1.10.2 COMPONENTS ${CAIROGL_COMPONENTS})
endif ()
# Normally we do not set the value of options automatically. However, CairoGL is special. Currently
@@ -119,7 +119,7 @@
# EGL is not, and ENABLE_X11_TARGET is OFF, this guess is wrong and the user must override it. We
# can't check ENABLE_X11_TARGET at this point because we don't know whether it's enabled until
# WEBKIT_OPTION_END has been called, and at that point it's too late to change default values.
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS PUBLIC ${CAIRO_GL_FOUND})
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ACCELERATED_2D_CANVAS PUBLIC ${CAIROGL_FOUND})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CREDENTIAL_STORAGE PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT PUBLIC ON)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
