Title: [184138] trunk/Source/WebCore
- Revision
- 184138
- Author
- [email protected]
- Date
- 2015-05-11 18:06:59 -0700 (Mon, 11 May 2015)
Log Message
Addressing post-review comments after r184037.
Unreviewed.
No new tests because there is no behavior change.
* rendering/SimpleLineLayoutTextFragmentIterator.cpp:
(WebCore::SimpleLineLayout::TextFragmentIterator::runWidth):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (184137 => 184138)
--- trunk/Source/WebCore/ChangeLog 2015-05-12 00:58:07 UTC (rev 184137)
+++ trunk/Source/WebCore/ChangeLog 2015-05-12 01:06:59 UTC (rev 184138)
@@ -1,3 +1,14 @@
+2015-05-11 Myles C. Maxfield <[email protected]>
+
+ Addressing post-review comments after r184037.
+
+ Unreviewed.
+
+ No new tests because there is no behavior change.
+
+ * rendering/SimpleLineLayoutTextFragmentIterator.cpp:
+ (WebCore::SimpleLineLayout::TextFragmentIterator::runWidth):
+
2015-05-11 Brent Fulgham <[email protected]>
[Win] Move Windows build target to Windows 7 (or newer)
Modified: trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp (184137 => 184138)
--- trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp 2015-05-12 00:58:07 UTC (rev 184137)
+++ trunk/Source/WebCore/rendering/SimpleLineLayoutTextFragmentIterator.cpp 2015-05-12 01:06:59 UTC (rev 184138)
@@ -197,8 +197,7 @@
bool measureWithEndSpace = m_style.collapseWhitespace && segmentTo < segment.text.length() && segment.text[segmentTo] == ' ';
if (measureWithEndSpace)
++segmentTo;
- auto string = segment.text.substring(segmentFrom, segmentTo - segmentFrom);
- TextRun run(string);
+ TextRun run(StringView(segment.text).substring(segmentFrom, segmentTo - segmentFrom));
run.setXPos(xPosition);
run.setTabSize(!!m_style.tabWidth, m_style.tabWidth);
float width = m_style.font.width(run);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes