Title: [184236] branches/safari-601.1.32-branch/Source/WebKit2
Revision
184236
Author
dburk...@apple.com
Date
2015-05-12 20:15:51 -0700 (Tue, 12 May 2015)

Log Message

Merge r183911. rdar://problem/20702435

Modified Paths

Diff

Modified: branches/safari-601.1.32-branch/Source/WebKit2/ChangeLog (184235 => 184236)


--- branches/safari-601.1.32-branch/Source/WebKit2/ChangeLog	2015-05-13 03:15:49 UTC (rev 184235)
+++ branches/safari-601.1.32-branch/Source/WebKit2/ChangeLog	2015-05-13 03:15:51 UTC (rev 184236)
@@ -2,65 +2,69 @@
 Dana Burkart  <dburk...@apple.com
 dburk...@apple.com>
 
-        Merge r183909. rdar://problem/18894598
+        Merge r183911. rdar://problem/20702435
 
-    2015-05-06  Daniel Bates  <daba...@apple.com>
+    2015-05-06  Jer Noble  <jer.no...@apple.com>
 
-            [iOS][WK2] Pause/resume database thread when UIProcess enters/leaves the background
-            https://bugs.webkit.org/show_bug.cgi?id=144657
-            <rdar://problem/18894598>
+            [WK2][Fullscreen] Elements whose children extend beyond their bounds are clipped in fullscreen mode.
+            https://bugs.webkit.org/show_bug.cgi?id=144716
 
-            Reviewed by Andy Estes.
+            Reviewed by Darin Adler.
 
-            Pause and resume the database thread when the UIProcess enters and leaves the background,
-            respectively, so that we avoid WebProcess termination due to holding a locked SQLite
-            database file when the WebProcess is suspended. This behavior matches the analagous
-            behavior in Legacy WebKit.
+            We create a mask animation for the transition between windowed and fullscreen modes, on the
+            assumption that the element being taken into fullscreen mode does not have visible children
+            who extend beyond that elements bounds. This assumption breaks down in the case where div
+            with absolutely positioned children is taken fullscreen. While we can't necessarily make the
+            transition look correct in this case, we can remove the mask after the transition completes.
 
-            * UIProcess/WebPageProxy.h:
-            * UIProcess/ios/WKContentView.mm:
-            (-[WKContentView _applicationDidEnterBackground:]): Call WebPageProxy::applicationDidEnterBackground()
-            when the UIProcess enters the background.
-            * UIProcess/ios/WebPageProxyIOS.mm:
-            (WebKit::WebPageProxy::applicationDidEnterBackground): Added; notify the WebProcess to pause the database thread.
-            We temporarily take out background assertion on the WebProcess before sending this notification to ensure that the
-            WebProcess is running to receive it. We'll release this assertion when the WebProcess replies that it received the
-            notification.
-            * WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
-            (WebKit::WebDatabaseManager::setPauseAllDatabases): Added; turns around and calls DatabaseManager::setPauseAllDatabases().
-            * WebProcess/WebCoreSupport/WebDatabaseManager.h:
-            * WebProcess/WebPage/WebPage.h:
-            * WebProcess/WebPage/WebPage.messages.in: Add message ApplicationDidEnterBackground(). Also,
-            add empty lines to help demarcate this message and the other UIKit application lifecycle-related
-            messages from the rest of the list of messages.
-            * WebProcess/WebPage/ios/WebPageIOS.mm:
-            (WebKit::WebPage::applicationWillEnterForeground): Resume the database thread.
-            (WebKit::WebPage::applicationDidEnterBackground): Pause the database thread.
+            * UIProcess/mac/WKFullScreenWindowController.mm:
+            (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
+            * WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:
+            (WebKit::removeAllMediaKeyStorageForOriginPath):
 
     2015-05-12  Dana Burkart
-    Dana Burkart  <dburk...@apple.com>
+    Dana Burkart  <dburk...@apple.com
+    dburk...@apple.com>
 
-            Merge r183942. rdar://problem/20049088
+            Merge r183909. rdar://problem/18894598
 
-        2015-05-06  Dean Jackson  <d...@apple.com>
+        2015-05-06  Daniel Bates  <daba...@apple.com>
 
-                Handle backdrop views that have to tile
-                https://bugs.webkit.org/show_bug.cgi?id=142317
-                <rdar://problem/20049088>
+                [iOS][WK2] Pause/resume database thread when UIProcess enters/leaves the background
+                https://bugs.webkit.org/show_bug.cgi?id=144657
+                <rdar://problem/18894598>
 
-                Reviewed by Simon Fraser.
+                Reviewed by Andy Estes.
 
-                Take 2 - this was rolled out because Mavericks was crashing.
+                Pause and resume the database thread when the UIProcess enters and leaves the background,
+                respectively, so that we avoid WebProcess termination due to holding a locked SQLite
+                database file when the WebProcess is suspended. This behavior matches the analagous
+                behavior in Legacy WebKit.
 
-                Add some better logging for custom appearance.
+                * UIProcess/WebPageProxy.h:
+                * UIProcess/ios/WKContentView.mm:
+                (-[WKContentView _applicationDidEnterBackground:]): Call WebPageProxy::applicationDidEnterBackground()
+                when the UIProcess enters the background.
+                * UIProcess/ios/WebPageProxyIOS.mm:
+                (WebKit::WebPageProxy::applicationDidEnterBackground): Added; notify the WebProcess to pause the database thread.
+                We temporarily take out background assertion on the WebProcess before sending this notification to ensure that the
+                WebProcess is running to receive it. We'll release this assertion when the WebProcess replies that it received the
+                notification.
+                * WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
+                (WebKit::WebDatabaseManager::setPauseAllDatabases): Added; turns around and calls DatabaseManager::setPauseAllDatabases().
+                * WebProcess/WebCoreSupport/WebDatabaseManager.h:
+                * WebProcess/WebPage/WebPage.h:
+                * WebProcess/WebPage/WebPage.messages.in: Add message ApplicationDidEnterBackground(). Also,
+                add empty lines to help demarcate this message and the other UIKit application lifecycle-related
+                messages from the rest of the list of messages.
+                * WebProcess/WebPage/ios/WebPageIOS.mm:
+                (WebKit::WebPage::applicationWillEnterForeground): Resume the database thread.
+                (WebKit::WebPage::applicationDidEnterBackground): Pause the database thread.
 
-                * Shared/mac/RemoteLayerTreeTransaction.mm:
-                (WebKit::RemoteLayerTreeTextStream::operator<<):
-
         2015-05-12  Dana Burkart
         Dana Burkart  <dburk...@apple.com>
 
-                Merge r183894. rdar://problem/20049088
+                Merge r183942. rdar://problem/20049088
 
             2015-05-06  Dean Jackson  <d...@apple.com>
 
@@ -70,11 +74,31 @@
 
                     Reviewed by Simon Fraser.
 
+                    Take 2 - this was rolled out because Mavericks was crashing.
+
                     Add some better logging for custom appearance.
 
                     * Shared/mac/RemoteLayerTreeTransaction.mm:
                     (WebKit::RemoteLayerTreeTextStream::operator<<):
 
+            2015-05-12  Dana Burkart
+            Dana Burkart  <dburk...@apple.com>
+
+                    Merge r183894. rdar://problem/20049088
+
+                2015-05-06  Dean Jackson  <d...@apple.com>
+
+                        Handle backdrop views that have to tile
+                        https://bugs.webkit.org/show_bug.cgi?id=142317
+                        <rdar://problem/20049088>
+
+                        Reviewed by Simon Fraser.
+
+                        Add some better logging for custom appearance.
+
+                        * Shared/mac/RemoteLayerTreeTransaction.mm:
+                        (WebKit::RemoteLayerTreeTextStream::operator<<):
+
 2015-05-11  Babak Shafiei  <bshaf...@apple.com>
 
         Merge r184004.

Modified: branches/safari-601.1.32-branch/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm (184235 => 184236)


--- branches/safari-601.1.32-branch/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm	2015-05-13 03:15:49 UTC (rev 184235)
+++ branches/safari-601.1.32-branch/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm	2015-05-13 03:15:51 UTC (rev 184236)
@@ -297,6 +297,11 @@
         [self _manager]->didEnterFullScreen();
         [self _manager]->setAnimatingFullScreen(false);
 
+        NSView *contentView = [[self window] contentView];
+        [contentView.layer removeAllAnimations];
+        [[_clipView layer] removeAllAnimations];
+        [[_clipView layer].mask removeAllAnimations];
+
         [_webViewPlaceholder setExitWarningVisible:YES];
         [_webViewPlaceholder setTarget:self];
     } else {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to