Title: [184289] trunk/Source/_javascript_Core
- Revision
- 184289
- Author
- msab...@apple.com
- Date
- 2015-05-13 10:58:59 -0700 (Wed, 13 May 2015)
Log Message
com.apple.WebKit.WebContent crashed at _javascript_Core: JSC::CodeBlock::finalizeUnconditionally
https://bugs.webkit.org/show_bug.cgi?id=144933
Changed the RELEASE_ASSERT_NOT_REACHED into an ASSERT. Added some diagnostic messages to
help determine the cause for any crash.
Reviewed by Geoffrey Garen.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (184288 => 184289)
--- trunk/Source/_javascript_Core/ChangeLog 2015-05-13 17:39:02 UTC (rev 184288)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-05-13 17:58:59 UTC (rev 184289)
@@ -1,3 +1,16 @@
+2015-05-13 Michael Saboff <msab...@apple.com>
+
+ com.apple.WebKit.WebContent crashed at _javascript_Core: JSC::CodeBlock::finalizeUnconditionally
+ https://bugs.webkit.org/show_bug.cgi?id=144933
+
+ Changed the RELEASE_ASSERT_NOT_REACHED into an ASSERT. Added some diagnostic messages to
+ help determine the cause for any crash.
+
+ Reviewed by Geoffrey Garen.
+
+ * bytecode/CodeBlock.cpp:
+ (JSC::CodeBlock::finalizeUnconditionally):
+
2015-05-13 Filip Pizlo <fpi...@apple.com>
REGRESSION(r184260): arguments elimination has stopped working because of Check(UntypedUse:) from SSAConversionPhase
Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (184288 => 184289)
--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2015-05-13 17:39:02 UTC (rev 184288)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp 2015-05-13 17:58:59 UTC (rev 184289)
@@ -2580,7 +2580,8 @@
break;
}
default:
- RELEASE_ASSERT_NOT_REACHED();
+ OpcodeID opcodeID = interpreter->getOpcodeID(curInstruction[0].u.opcode);
+ ASSERT_WITH_MESSAGE_UNUSED(opcodeID, false, "Unhandled opcode in CodeBlock::finalizeUnconditionally, %s(%d) at bc %u", opcodeNames[opcodeID], opcodeID, propertyAccessInstructions[i]);
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
