Title: [184323] trunk/Source/WebCore
- Revision
- 184323
- Author
- [email protected]
- Date
- 2015-05-13 18:21:03 -0700 (Wed, 13 May 2015)
Log Message
REGRESION (r179958): Crash in WebCore::DocumentLoader::detachFromFrame when -[id<WebPolicyDelegate> decidePolicyForMIMEType:request:frame:decisionListener:] fails to call -[id<WebPolicyDecisionListener> download|ignore|use]
<http://webkit.org/b/144975>
Reviewed by Andy Estes.
This change reverts r179958. It changes RELEASE_ASSERT*()
statements back to Debug-only ASSERT*() statements.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::detachFromFrame):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (184322 => 184323)
--- trunk/Source/WebCore/ChangeLog 2015-05-14 00:39:50 UTC (rev 184322)
+++ trunk/Source/WebCore/ChangeLog 2015-05-14 01:21:03 UTC (rev 184323)
@@ -1,3 +1,18 @@
+2015-05-13 David Kilzer <[email protected]>
+
+ REGRESION (r179958): Crash in WebCore::DocumentLoader::detachFromFrame when -[id<WebPolicyDelegate> decidePolicyForMIMEType:request:frame:decisionListener:] fails to call -[id<WebPolicyDecisionListener> download|ignore|use]
+ <http://webkit.org/b/144975>
+
+ Reviewed by Andy Estes.
+
+ This change reverts r179958. It changes RELEASE_ASSERT*()
+ statements back to Debug-only ASSERT*() statements.
+
+ * loader/DocumentLoader.cpp:
+ (WebCore::DocumentLoader::~DocumentLoader):
+ (WebCore::DocumentLoader::continueAfterContentPolicy):
+ (WebCore::DocumentLoader::detachFromFrame):
+
2015-05-13 Antti Koivisto <[email protected]>
Cached CSS image resources don't show up after reloading <http://nightly.webkit.org/start/>
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (184322 => 184323)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2015-05-14 00:39:50 UTC (rev 184322)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2015-05-14 01:21:03 UTC (rev 184323)
@@ -162,7 +162,7 @@
DocumentLoader::~DocumentLoader()
{
ASSERT(!m_frame || frameLoader()->activeDocumentLoader() != this || !isLoading());
- RELEASE_ASSERT_WITH_MESSAGE(!m_waitingForContentPolicy, "The content policy callback should never outlive its DocumentLoader.");
+ ASSERT_WITH_MESSAGE(!m_waitingForContentPolicy, "The content policy callback should never outlive its DocumentLoader.");
if (m_iconLoadDecisionCallback)
m_iconLoadDecisionCallback->invalidate();
if (m_iconDataCallback)
@@ -667,7 +667,7 @@
void DocumentLoader::continueAfterContentPolicy(PolicyAction policy)
{
- RELEASE_ASSERT(m_waitingForContentPolicy);
+ ASSERT(m_waitingForContentPolicy);
m_waitingForContentPolicy = false;
if (isStopping())
return;
@@ -927,7 +927,7 @@
InspectorInstrumentation::loaderDetachedFromFrame(*m_frame, *this);
m_frame = nullptr;
// The call to stopLoading() above should have canceled any pending content policy check.
- RELEASE_ASSERT_WITH_MESSAGE(!m_waitingForContentPolicy, "The content policy callback needs a valid frame.");
+ ASSERT_WITH_MESSAGE(!m_waitingForContentPolicy, "The content policy callback needs a valid frame.");
}
void DocumentLoader::clearMainResourceLoader()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
