Title: [184983] trunk/Source/_javascript_Core
- Revision
- 184983
- Author
- commit-qu...@webkit.org
- Date
- 2015-05-29 00:51:17 -0700 (Fri, 29 May 2015)
Log Message
Unreviewed, rolling out r184860.
https://bugs.webkit.org/show_bug.cgi?id=145456
May have caused ~1% Octane regression (Requested by kling on
#webkit).
Reverted changeset:
"Try to use StringView when comparing JSStrings for equality."
https://bugs.webkit.org/show_bug.cgi?id=145379
http://trac.webkit.org/changeset/184860
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (184982 => 184983)
--- trunk/Source/_javascript_Core/ChangeLog 2015-05-29 06:38:22 UTC (rev 184982)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-05-29 07:51:17 UTC (rev 184983)
@@ -1,3 +1,17 @@
+2015-05-29 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r184860.
+ https://bugs.webkit.org/show_bug.cgi?id=145456
+
+ May have caused ~1% Octane regression (Requested by kling on
+ #webkit).
+
+ Reverted changeset:
+
+ "Try to use StringView when comparing JSStrings for equality."
+ https://bugs.webkit.org/show_bug.cgi?id=145379
+ http://trac.webkit.org/changeset/184860
+
2015-05-28 Michael Saboff <msab...@apple.com>
mozilla/js1_5/Array/regress-154338.js test causes ARM 32 bit iOS devices to run out of memory
Modified: trunk/Source/_javascript_Core/jit/JITOperations.cpp (184982 => 184983)
--- trunk/Source/_javascript_Core/jit/JITOperations.cpp 2015-05-29 06:38:22 UTC (rev 184982)
+++ trunk/Source/_javascript_Core/jit/JITOperations.cpp 2015-05-29 07:51:17 UTC (rev 184983)
@@ -923,7 +923,7 @@
VM* vm = &exec->vm();
NativeCallFrameTracer tracer(vm, exec);
- bool result = WTF::equal(asString(left)->view(exec), asString(right)->view(exec));
+ bool result = WTF::equal(*asString(left)->value(exec).impl(), *asString(right)->value(exec).impl());
#if USE(JSVALUE64)
return JSValue::encode(jsBoolean(result));
#else
Modified: trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h (184982 => 184983)
--- trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h 2015-05-29 06:38:22 UTC (rev 184982)
+++ trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h 2015-05-29 07:51:17 UTC (rev 184983)
@@ -786,7 +786,7 @@
bool s1 = v1.isString();
bool s2 = v2.isString();
if (s1 && s2)
- return WTF::equal(asString(v1)->view(exec), asString(v2)->view(exec));
+ return WTF::equal(*asString(v1)->value(exec).impl(), *asString(v2)->value(exec).impl());
if (v1.isUndefinedOrNull()) {
if (v2.isUndefinedOrNull())
@@ -856,7 +856,7 @@
ASSERT(v1.isCell() && v2.isCell());
if (v1.asCell()->isString() && v2.asCell()->isString())
- return WTF::equal(asString(v1)->view(exec), asString(v2)->view(exec));
+ return WTF::equal(*asString(v1)->value(exec).impl(), *asString(v2)->value(exec).impl());
if (v1.asCell()->isSymbol() && v2.asCell()->isSymbol())
return asSymbol(v1)->privateName() == asSymbol(v2)->privateName();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
