Title: [185142] trunk/Source/WebInspectorUI
- Revision
- 185142
- Author
- commit-qu...@webkit.org
- Date
- 2015-06-02 22:57:33 -0700 (Tue, 02 Jun 2015)
Log Message
Web Inspector: Remove uses of delete in Sidebar related code
https://bugs.webkit.org/show_bug.cgi?id=145592
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-06-02
Reviewed by Timothy Hatcher.
* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
Clear value instead of deleting.
* UserInterface/Views/SearchSidebarPanel.js:
(WebInspector.SearchSidebarPanel.prototype.performSearch):
Just clear the search identifier. Also assert it (a required string) is always non-falsey.
* UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype.resizerDragEnded): Deleted.
This entire callback is unnecessary because whenever we start
a drag we save the value.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (185141 => 185142)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-03 05:46:56 UTC (rev 185141)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-03 05:57:33 UTC (rev 185142)
@@ -1,5 +1,25 @@
2015-06-02 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Remove uses of delete in Sidebar related code
+ https://bugs.webkit.org/show_bug.cgi?id=145592
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
+ (WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
+ Clear value instead of deleting.
+
+ * UserInterface/Views/SearchSidebarPanel.js:
+ (WebInspector.SearchSidebarPanel.prototype.performSearch):
+ Just clear the search identifier. Also assert it (a required string) is always non-falsey.
+
+ * UserInterface/Views/Sidebar.js:
+ (WebInspector.Sidebar.prototype.resizerDragEnded): Deleted.
+ This entire callback is unnecessary because whenever we start
+ a drag we save the value.
+
+2015-06-02 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs
https://bugs.webkit.org/show_bug.cgi?id=145591
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js (185141 => 185142)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2015-06-03 05:46:56 UTC (rev 185141)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js 2015-06-03 05:57:33 UTC (rev 185142)
@@ -101,9 +101,9 @@
this.contentElement.scrollTop = this._initialScrollOffset;
- for (var i = 0; i < this._panels.length; ++i) {
- delete this._panels[i].element._savedScrollTop;
- this._panels[i].markAsNeedsRefresh(domNode);
+ for (var panel of this._panels) {
+ panel.element._savedScrollTop = undefined;
+ panel.markAsNeedsRefresh(domNode);
}
this._updatePseudoClassCheckboxes();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js (185141 => 185142)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js 2015-06-03 05:46:56 UTC (rev 185141)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js 2015-06-03 05:57:33 UTC (rev 185142)
@@ -211,6 +211,8 @@
if (error || !resultsCount)
return;
+ console.assert(searchId);
+
this._domSearchIdentifier = searchId;
function domSearchResults(error, nodeIds)
@@ -277,9 +279,9 @@
setTimeout(searchScripts.bind(this, WebInspector.debuggerManager.knownNonResourceScripts), 0);
if (window.DOMAgent) {
- if ("_domSearchIdentifier" in this) {
+ if (this._domSearchIdentifier) {
DOMAgent.discardSearchResults(this._domSearchIdentifier);
- delete this._domSearchIdentifier;
+ this._domSearchIdentifier = undefined;
}
DOMAgent.performSearch(searchQuery, domCallback.bind(this));
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js (185141 => 185142)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2015-06-03 05:46:56 UTC (rev 185141)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2015-06-03 05:57:33 UTC (rev 185142)
@@ -281,11 +281,6 @@
this.collapsed = (newWidth < (this.minimumWidth / 2));
}
- resizerDragEnded(resizer)
- {
- delete this._widthBeforeResize;
- }
-
// Private
_navigationItemSelected(event)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
