Title: [185185] trunk
- Revision
- 185185
- Author
- commit-qu...@webkit.org
- Date
- 2015-06-03 21:19:51 -0700 (Wed, 03 Jun 2015)
Log Message
AX: Expose field sets to accessibility clients
https://bugs.webkit.org/show_bug.cgi?id=145585
Source/WebCore:
Expose fieldsets to the accessibility API via a subrole of AXFieldset.
Patch by Greg Hughes <ghug...@apple.com> on 2015-06-03
Reviewed by Chris Fleizach.
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper subrole]):
LayoutTests:
Updated role tests to include the new subrole for fieldsets
Patch by Greg Hughes <ghug...@apple.com> on 2015-06-03
Reviewed by Chris Fleizach.
* platform/mac/accessibility/roles-exposed-expected.txt:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (185184 => 185185)
--- trunk/LayoutTests/ChangeLog 2015-06-04 03:42:31 UTC (rev 185184)
+++ trunk/LayoutTests/ChangeLog 2015-06-04 04:19:51 UTC (rev 185185)
@@ -1,3 +1,14 @@
+2015-06-03 Greg Hughes <ghug...@apple.com>
+
+ AX: Expose field sets to accessibility clients
+ https://bugs.webkit.org/show_bug.cgi?id=145585
+
+ Updated role tests to include the new subrole for fieldsets
+
+ Reviewed by Chris Fleizach.
+
+ * platform/mac/accessibility/roles-exposed-expected.txt:
+
2015-06-03 Said Abou-Hallawa <sabouhall...@apple.com>
Skip webgl/useWhilePending.html on WebKit 1 following:
Modified: trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt (185184 => 185185)
--- trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2015-06-04 03:42:31 UTC (rev 185184)
+++ trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt 2015-06-04 04:19:51 UTC (rev 185185)
@@ -121,7 +121,7 @@
fieldset
AXRole: AXGroup
- AXSubrole:
+ AXSubrole: AXFieldset
AXRoleDescription: group
legend
Modified: trunk/LayoutTests/platform/mac-mavericks/accessibility/roles-exposed-expected.txt (185184 => 185185)
--- trunk/LayoutTests/platform/mac-mavericks/accessibility/roles-exposed-expected.txt 2015-06-04 03:42:31 UTC (rev 185184)
+++ trunk/LayoutTests/platform/mac-mavericks/accessibility/roles-exposed-expected.txt 2015-06-04 04:19:51 UTC (rev 185185)
@@ -121,7 +121,7 @@
fieldset
AXRole: AXGroup
- AXSubrole:
+ AXSubrole: AXFieldset
AXRoleDescription: group
legend
Modified: trunk/Source/WebCore/ChangeLog (185184 => 185185)
--- trunk/Source/WebCore/ChangeLog 2015-06-04 03:42:31 UTC (rev 185184)
+++ trunk/Source/WebCore/ChangeLog 2015-06-04 04:19:51 UTC (rev 185185)
@@ -1,3 +1,15 @@
+2015-06-03 Greg Hughes <ghug...@apple.com>
+
+ AX: Expose field sets to accessibility clients
+ https://bugs.webkit.org/show_bug.cgi?id=145585
+
+ Expose fieldsets to the accessibility API via a subrole of AXFieldset.
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper subrole]):
+
2015-06-03 Myles C. Maxfield <mmaxfi...@apple.com>
Remove dead code FontPlatformData::roundsGlyphAdvances()
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (185184 => 185185)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-06-04 03:42:31 UTC (rev 185184)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2015-06-04 04:19:51 UTC (rev 185185)
@@ -2026,6 +2026,9 @@
if (m_object->isTreeItem())
return NSAccessibilityOutlineRowSubrole;
+ if (m_object->isFieldset())
+ return @"AXFieldset";
+
if (is<AccessibilityList>(*m_object)) {
auto& listObject = downcast<AccessibilityList>(*m_object);
if (listObject.isUnorderedList() || listObject.isOrderedList())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
