Title: [185220] trunk/Source/WebCore
Revision
185220
Author
eric.carl...@apple.com
Date
2015-06-04 15:08:59 -0700 (Thu, 04 Jun 2015)

Log Message

[Mac] Don't show default controls after playing to wireless target, again
https://bugs.webkit.org/show_bug.cgi?id=145620
<rdar://problem/21145806>

Reviewed by Dean Jackson.

Follow up to fix two tests broken by r185207.

* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.updateControls): Always show controls when the video element
  is the fullscreen element because custom controls aren't possible.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (185219 => 185220)


--- trunk/Source/WebCore/ChangeLog	2015-06-04 22:00:09 UTC (rev 185219)
+++ trunk/Source/WebCore/ChangeLog	2015-06-04 22:08:59 UTC (rev 185220)
@@ -1,3 +1,17 @@
+2015-06-04  Eric Carlson  <eric.carl...@apple.com>
+
+        [Mac] Don't show default controls after playing to wireless target, again
+        https://bugs.webkit.org/show_bug.cgi?id=145620
+        <rdar://problem/21145806>
+
+        Reviewed by Dean Jackson.
+
+        Follow up to fix two tests broken by r185207.
+
+        * Modules/mediacontrols/mediaControlsApple.js:
+        (Controller.prototype.updateControls): Always show controls when the video element
+          is the fullscreen element because custom controls aren't possible.
+
 2015-06-04  Myles C. Maxfield  <mmaxfi...@apple.com>
 
         [Cocoa] Add ASSERT to FontPlatformData::ctFont()

Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (185219 => 185220)


--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js	2015-06-04 22:00:09 UTC (rev 185219)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js	2015-06-04 22:08:59 UTC (rev 185220)
@@ -612,7 +612,7 @@
         this.updateLayoutForDisplayedWidth();
         this.setNeedsTimelineMetricsUpdate();
 
-        if (this.video.controls) {
+        if (this.video.controls || this.isFullScreen()) {
             this.controls.panel.classList.add(this.ClassNames.show);
             this.controls.panel.classList.remove(this.ClassNames.hidden);
             this.resetHideControlsTimer();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to