Title: [185224] trunk/Tools
- Revision
- 185224
- Author
- a...@apple.com
- Date
- 2015-06-04 15:53:49 -0700 (Thu, 04 Jun 2015)
Log Message
WebKitTestRunner leaks strings in generateWhitelist()
https://bugs.webkit.org/show_bug.cgi?id=145665
Reviewed by Myles C. Maxfield.
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::generateWhitelist):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (185223 => 185224)
--- trunk/Tools/ChangeLog 2015-06-04 22:37:25 UTC (rev 185223)
+++ trunk/Tools/ChangeLog 2015-06-04 22:53:49 UTC (rev 185224)
@@ -1,3 +1,13 @@
+2015-06-04 Alexey Proskuryakov <a...@apple.com>
+
+ WebKitTestRunner leaks strings in generateWhitelist()
+ https://bugs.webkit.org/show_bug.cgi?id=145665
+
+ Reviewed by Myles C. Maxfield.
+
+ * WebKitTestRunner/mac/TestControllerMac.mm:
+ (WTR::generateWhitelist):
+
2015-06-03 Yusuke Suzuki <utatane....@gmail.com>
Fix options in build-jsc for CMake builds
Modified: trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm (185223 => 185224)
--- trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm 2015-06-04 22:37:25 UTC (rev 185223)
+++ trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm 2015-06-04 22:53:49 UTC (rev 185224)
@@ -286,10 +286,12 @@
WKMutableArrayRef result = WKMutableArrayCreate();
for (NSString *fontFamily in allowedFontFamilySet()) {
NSArray *fontsForFamily = [[NSFontManager sharedFontManager] availableMembersOfFontFamily:fontFamily];
- WKArrayAppendItem(result, WKStringCreateWithUTF8CString([fontFamily UTF8String]));
+ WKRetainPtr<WKStringRef> familyInFont = adoptWK(WKStringCreateWithUTF8CString([fontFamily UTF8String]));
+ WKArrayAppendItem(result, familyInFont.get());
for (NSArray *fontInfo in fontsForFamily) {
// Font name is the first entry in the array.
- WKArrayAppendItem(result, WKStringCreateWithUTF8CString([[fontInfo objectAtIndex:0] UTF8String]));
+ WKRetainPtr<WKStringRef> fontName = adoptWK(WKStringCreateWithUTF8CString([[fontInfo objectAtIndex:0] UTF8String]));
+ WKArrayAppendItem(result, fontName.get());
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
