Diff
Modified: trunk/Source/WebCore/ChangeLog (185517 => 185518)
--- trunk/Source/WebCore/ChangeLog 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/ChangeLog 2015-06-12 18:48:53 UTC (rev 185518)
@@ -1,3 +1,91 @@
+2015-06-12 Zan Dobersek <[email protected]>
+
+ Add the remaining missing override specifiers under Source/WebCore/
+ https://bugs.webkit.org/show_bug.cgi?id=145907
+
+ Reviewed by Darin Adler.
+
+ Fix the remaining compiler warnings about missing override specifiers
+ for overriding method declarations in classes under Source/WebCore/.
+
+ Where the addition had to be performed on all virtual methods of the
+ class, the virtual specifier was removed so now only the override
+ specifier is in use.
+
+ * Modules/indexeddb/IDBOpenDBRequest.h:
+ * Modules/indexeddb/IDBRequest.h:
+ * Modules/webdatabase/DatabaseServer.h:
+ * bindings/js/ReadableJSStream.h:
+ * editing/InsertTextCommand.h:
+ * mathml/MathMLInlineContainerElement.h:
+ * platform/audio/EqualPowerPanner.h:
+ (WebCore::EqualPowerPanner::reset):
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::NullMediaPlayerPrivate::load):
+ (WebCore::NullMediaPlayerPrivate::cancelLoad):
+ (WebCore::NullMediaPlayerPrivate::prepareToPlay):
+ (WebCore::NullMediaPlayerPrivate::play):
+ (WebCore::NullMediaPlayerPrivate::pause):
+ (WebCore::NullMediaPlayerPrivate::platformMedia):
+ (WebCore::NullMediaPlayerPrivate::platformLayer):
+ (WebCore::NullMediaPlayerPrivate::naturalSize):
+ (WebCore::NullMediaPlayerPrivate::hasVideo):
+ (WebCore::NullMediaPlayerPrivate::hasAudio):
+ (WebCore::NullMediaPlayerPrivate::setVisible):
+ (WebCore::NullMediaPlayerPrivate::durationDouble):
+ (WebCore::NullMediaPlayerPrivate::currentTimeDouble):
+ (WebCore::NullMediaPlayerPrivate::seekDouble):
+ (WebCore::NullMediaPlayerPrivate::seeking):
+ (WebCore::NullMediaPlayerPrivate::setRateDouble):
+ (WebCore::NullMediaPlayerPrivate::setPreservesPitch):
+ (WebCore::NullMediaPlayerPrivate::paused):
+ (WebCore::NullMediaPlayerPrivate::setVolumeDouble):
+ (WebCore::NullMediaPlayerPrivate::supportsMuting):
+ (WebCore::NullMediaPlayerPrivate::setMuted):
+ (WebCore::NullMediaPlayerPrivate::hasClosedCaptions):
+ (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
+ (WebCore::NullMediaPlayerPrivate::networkState):
+ (WebCore::NullMediaPlayerPrivate::readyState):
+ (WebCore::NullMediaPlayerPrivate::maxTimeSeekableDouble):
+ (WebCore::NullMediaPlayerPrivate::minTimeSeekable):
+ (WebCore::NullMediaPlayerPrivate::buffered):
+ (WebCore::NullMediaPlayerPrivate::totalBytes):
+ (WebCore::NullMediaPlayerPrivate::didLoadingProgress):
+ (WebCore::NullMediaPlayerPrivate::setSize):
+ (WebCore::NullMediaPlayerPrivate::canLoadPoster):
+ (WebCore::NullMediaPlayerPrivate::setPoster):
+ (WebCore::NullMediaPlayerPrivate::hasSingleSecurityOrigin):
+ * platform/graphics/filters/DistantLightSource.h:
+ * platform/graphics/filters/FEComposite.h:
+ * platform/graphics/filters/FEDisplacementMap.h:
+ (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
+ * platform/graphics/filters/FEFlood.h:
+ (WebCore::FEFlood::determineAbsolutePaintRect):
+ * platform/graphics/filters/PointLightSource.h:
+ * platform/graphics/filters/SpotLightSource.h:
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
+ (WebCore::MediaPlayerPrivateGStreamer::hasVideo):
+ (WebCore::MediaPlayerPrivateGStreamer::hasAudio):
+ (WebCore::MediaPlayerPrivateGStreamer::audioSourceProvider):
+ (WebCore::MediaPlayerPrivateGStreamer::engineDescription):
+ (WebCore::MediaPlayerPrivateGStreamer::isLiveStream):
+ (WebCore::MediaPlayerPrivateGStreamer::totalVideoFrames):
+ (WebCore::MediaPlayerPrivateGStreamer::droppedVideoFrames):
+ (WebCore::MediaPlayerPrivateGStreamer::corruptedVideoFrames):
+ (WebCore::MediaPlayerPrivateGStreamer::totalFrameDelay):
+ * platform/graphics/texmap/BitmapTextureGL.h:
+ (WebCore::BitmapTextureGL::isBackedByOpenGL):
+ * platform/graphics/transforms/Matrix3DTransformOperation.h:
+ * platform/graphics/transforms/MatrixTransformOperation.h:
+ * platform/graphics/transforms/PerspectiveTransformOperation.h:
+ * platform/graphics/transforms/RotateTransformOperation.h:
+ * platform/graphics/transforms/ScaleTransformOperation.h:
+ * platform/graphics/transforms/SkewTransformOperation.h:
+ * platform/image-decoders/png/PNGImageDecoder.h:
+ (WebCore::PNGImageDecoder::filenameExtension):
+ * platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h:
+ * platform/mock/MockRealtimeMediaSourceCenter.h:
+
2015-06-12 Commit Queue <[email protected]>
Unreviewed, rolling out r185512.
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.h (185517 => 185518)
--- trunk/Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBOpenDBRequest.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -47,7 +47,7 @@
virtual void onSuccess(PassRefPtr<IDBDatabaseBackend>, const IDBDatabaseMetadata&) override;
// EventTarget
- virtual EventTargetInterface eventTargetInterface() const;
+ virtual EventTargetInterface eventTargetInterface() const override;
virtual bool dispatchEvent(PassRefPtr<Event>) override;
protected:
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h (185517 => 185518)
--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -80,15 +80,15 @@
void abort();
// IDBCallbacks
- virtual void onError(PassRefPtr<IDBDatabaseError>);
- virtual void onSuccess(PassRefPtr<DOMStringList>);
- virtual void onSuccess(PassRefPtr<IDBCursorBackend>);
- virtual void onSuccess(PassRefPtr<IDBKey>);
- virtual void onSuccess(PassRefPtr<SharedBuffer>);
- virtual void onSuccess(PassRefPtr<SharedBuffer>, PassRefPtr<IDBKey>, const IDBKeyPath&);
- virtual void onSuccess(int64_t);
- virtual void onSuccess();
- virtual void onSuccess(PassRefPtr<IDBKey>, PassRefPtr<IDBKey> primaryKey, PassRefPtr<SharedBuffer>);
+ virtual void onError(PassRefPtr<IDBDatabaseError>) override;
+ virtual void onSuccess(PassRefPtr<DOMStringList>) override;
+ virtual void onSuccess(PassRefPtr<IDBCursorBackend>) override;
+ virtual void onSuccess(PassRefPtr<IDBKey>) override;
+ virtual void onSuccess(PassRefPtr<SharedBuffer>) override;
+ virtual void onSuccess(PassRefPtr<SharedBuffer>, PassRefPtr<IDBKey>, const IDBKeyPath&) override;
+ virtual void onSuccess(int64_t) override;
+ virtual void onSuccess() override;
+ virtual void onSuccess(PassRefPtr<IDBKey>, PassRefPtr<IDBKey> primaryKey, PassRefPtr<SharedBuffer>) override;
// EventTarget
virtual EventTargetInterface eventTargetInterface() const override;
Modified: trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.h (185517 => 185518)
--- trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/Modules/webdatabase/DatabaseServer.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -36,33 +36,33 @@
DatabaseServer() { };
virtual ~DatabaseServer() { }
- virtual void initialize(const String& databasePath);
+ void initialize(const String& databasePath) override;
- virtual void setClient(DatabaseManagerClient*);
- virtual String databaseDirectoryPath() const;
- virtual void setDatabaseDirectoryPath(const String&);
+ void setClient(DatabaseManagerClient*) override;
+ String databaseDirectoryPath() const override;
+ void setDatabaseDirectoryPath(const String&) override;
- virtual String fullPathForDatabase(SecurityOrigin*, const String& name, bool createIfDoesNotExist);
+ String fullPathForDatabase(SecurityOrigin*, const String& name, bool createIfDoesNotExist) override;
- virtual RefPtr<DatabaseBackendBase> openDatabase(RefPtr<DatabaseContext>&, const String& name, const String& expectedVersion, const String& displayName, unsigned long estimatedSize, bool setVersionInNewDatabase, DatabaseError&, String& errorMessage, OpenAttempt);
+ RefPtr<DatabaseBackendBase> openDatabase(RefPtr<DatabaseContext>&, const String& name, const String& expectedVersion, const String& displayName, unsigned long estimatedSize, bool setVersionInNewDatabase, DatabaseError&, String& errorMessage, OpenAttempt) override;
void closeAllDatabases() override;
- virtual bool hasEntryForOrigin(SecurityOrigin*);
- virtual void origins(Vector<RefPtr<SecurityOrigin>>& result);
- virtual bool databaseNamesForOrigin(SecurityOrigin*, Vector<String>& result);
- virtual DatabaseDetails detailsForNameAndOrigin(const String&, SecurityOrigin*);
+ bool hasEntryForOrigin(SecurityOrigin*) override;
+ void origins(Vector<RefPtr<SecurityOrigin>>& result) override;
+ bool databaseNamesForOrigin(SecurityOrigin*, Vector<String>& result) override;
+ DatabaseDetails detailsForNameAndOrigin(const String&, SecurityOrigin*) override;
- virtual unsigned long long usageForOrigin(SecurityOrigin*);
- virtual unsigned long long quotaForOrigin(SecurityOrigin*);
+ unsigned long long usageForOrigin(SecurityOrigin*) override;
+ unsigned long long quotaForOrigin(SecurityOrigin*) override;
- virtual void setQuota(SecurityOrigin*, unsigned long long);
+ void setQuota(SecurityOrigin*, unsigned long long) override;
- virtual void deleteAllDatabases();
- virtual bool deleteOrigin(SecurityOrigin*);
- virtual bool deleteDatabase(SecurityOrigin*, const String& name);
+ void deleteAllDatabases() override;
+ bool deleteOrigin(SecurityOrigin*) override;
+ bool deleteDatabase(SecurityOrigin*, const String& name) override;
- virtual void interruptAllDatabasesForContext(const DatabaseContext*);
+ void interruptAllDatabasesForContext(const DatabaseContext*) override;
protected:
virtual RefPtr<DatabaseBackendBase> createDatabase(RefPtr<DatabaseContext>&, const String& name, const String& expectedVersion, const String& displayName, unsigned long estimatedSize, bool setVersionInNewDatabase, DatabaseError&, String& errorMessage);
Modified: trunk/Source/WebCore/bindings/js/ReadableJSStream.h (185517 => 185518)
--- trunk/Source/WebCore/bindings/js/ReadableJSStream.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/bindings/js/ReadableJSStream.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -52,7 +52,7 @@
JSC::JSValue jsController(JSC::ExecState&, JSDOMGlobalObject*);
void storeError(JSC::ExecState&);
- JSC::JSValue error() { return m_error.get(); }
+ JSC::JSValue error() override { return m_error.get(); }
void enqueue(JSC::ExecState&);
Modified: trunk/Source/WebCore/editing/InsertTextCommand.h (185517 => 185518)
--- trunk/Source/WebCore/editing/InsertTextCommand.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/editing/InsertTextCommand.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -67,7 +67,7 @@
void deleteCharacter();
- virtual void doApply();
+ virtual void doApply() override;
virtual bool isInsertTextCommand() const override { return true; }
Modified: trunk/Source/WebCore/mathml/MathMLInlineContainerElement.h (185517 => 185518)
--- trunk/Source/WebCore/mathml/MathMLInlineContainerElement.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/mathml/MathMLInlineContainerElement.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -40,7 +40,7 @@
protected:
MathMLInlineContainerElement(const QualifiedName& tagName, Document&);
- void childrenChanged(const ChildChange&);
+ virtual void childrenChanged(const ChildChange&) override;
private:
virtual RenderPtr<RenderElement> createElementRenderer(Ref<RenderStyle>&&, const RenderTreePosition&) override;
Modified: trunk/Source/WebCore/platform/audio/EqualPowerPanner.h (185517 => 185518)
--- trunk/Source/WebCore/platform/audio/EqualPowerPanner.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/audio/EqualPowerPanner.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -35,9 +35,9 @@
public:
EqualPowerPanner(float sampleRate);
- virtual void pan(double azimuth, double elevation, const AudioBus* inputBus, AudioBus* outputBuf, size_t framesToProcess);
+ virtual void pan(double azimuth, double elevation, const AudioBus* inputBus, AudioBus* outputBuf, size_t framesToProcess) override;
- virtual void reset() { m_isFirstRender = true; }
+ virtual void reset() override { m_isFirstRender = true; }
virtual double tailTime() const override { return 0; }
virtual double latencyTime() const override { return 0; }
Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2015-06-12 18:48:53 UTC (rev 185518)
@@ -85,70 +85,70 @@
public:
explicit NullMediaPlayerPrivate(MediaPlayer*) { }
- virtual void load(const String&) { }
+ void load(const String&) override { }
#if ENABLE(MEDIA_SOURCE)
- virtual void load(const String&, MediaSourcePrivateClient*) { }
+ void load(const String&, MediaSourcePrivateClient*) override { }
#endif
#if ENABLE(MEDIA_STREAM)
- virtual void load(MediaStreamPrivate*) { }
+ void load(MediaStreamPrivate*) override { }
#endif
- virtual void cancelLoad() { }
+ void cancelLoad() override { }
- virtual void prepareToPlay() { }
- virtual void play() { }
- virtual void pause() { }
+ void prepareToPlay() override { }
+ void play() override { }
+ void pause() override { }
- virtual PlatformMedia platformMedia() const { return NoPlatformMedia; }
- virtual PlatformLayer* platformLayer() const { return 0; }
+ PlatformMedia platformMedia() const override { return NoPlatformMedia; }
+ PlatformLayer* platformLayer() const override { return 0; }
- virtual FloatSize naturalSize() const { return FloatSize(); }
+ FloatSize naturalSize() const override { return FloatSize(); }
- virtual bool hasVideo() const { return false; }
- virtual bool hasAudio() const { return false; }
+ bool hasVideo() const override { return false; }
+ bool hasAudio() const override { return false; }
- virtual void setVisible(bool) { }
+ void setVisible(bool) override { }
- virtual double durationDouble() const { return 0; }
+ double durationDouble() const override { return 0; }
- virtual double currentTimeDouble() const { return 0; }
- virtual void seekDouble(double) { }
- virtual bool seeking() const { return false; }
+ double currentTimeDouble() const override { return 0; }
+ void seekDouble(double) override { }
+ bool seeking() const override { return false; }
- virtual void setRateDouble(double) { }
- virtual void setPreservesPitch(bool) { }
- virtual bool paused() const { return false; }
+ void setRateDouble(double) override { }
+ void setPreservesPitch(bool) override { }
+ bool paused() const override { return false; }
- virtual void setVolumeDouble(double) { }
+ void setVolumeDouble(double) override { }
- virtual bool supportsMuting() const { return false; }
- virtual void setMuted(bool) { }
+ bool supportsMuting() const override { return false; }
+ void setMuted(bool) override { }
- virtual bool hasClosedCaptions() const { return false; }
- virtual void setClosedCaptionsVisible(bool) { };
+ bool hasClosedCaptions() const override { return false; }
+ void setClosedCaptionsVisible(bool) override { };
- virtual MediaPlayer::NetworkState networkState() const { return MediaPlayer::Empty; }
- virtual MediaPlayer::ReadyState readyState() const { return MediaPlayer::HaveNothing; }
+ MediaPlayer::NetworkState networkState() const override { return MediaPlayer::Empty; }
+ MediaPlayer::ReadyState readyState() const override { return MediaPlayer::HaveNothing; }
- virtual double maxTimeSeekableDouble() const { return 0; }
- virtual double minTimeSeekable() const { return 0; }
- virtual std::unique_ptr<PlatformTimeRanges> buffered() const { return std::make_unique<PlatformTimeRanges>(); }
+ float maxTimeSeekable() const override { return 0; }
+ double minTimeSeekable() const override { return 0; }
+ std::unique_ptr<PlatformTimeRanges> buffered() const override { return std::make_unique<PlatformTimeRanges>(); }
- virtual unsigned long long totalBytes() const { return 0; }
- virtual bool didLoadingProgress() const { return false; }
+ unsigned long long totalBytes() const override { return 0; }
+ bool didLoadingProgress() const override { return false; }
- virtual void setSize(const IntSize&) { }
+ void setSize(const IntSize&) override { }
- virtual void paint(GraphicsContext*, const FloatRect&) override { }
+ void paint(GraphicsContext*, const FloatRect&) override { }
- virtual bool canLoadPoster() const { return false; }
- virtual void setPoster(const String&) { }
+ bool canLoadPoster() const override { return false; }
+ void setPoster(const String&) override { }
- virtual bool hasSingleSecurityOrigin() const { return true; }
+ bool hasSingleSecurityOrigin() const override { return true; }
#if ENABLE(ENCRYPTED_MEDIA)
- virtual MediaPlayer::MediaKeyException generateKeyRequest(const String&, const unsigned char*, unsigned) override { return MediaPlayer::InvalidPlayerState; }
- virtual MediaPlayer::MediaKeyException addKey(const String&, const unsigned char*, unsigned, const unsigned char*, unsigned, const String&) override { return MediaPlayer::InvalidPlayerState; }
- virtual MediaPlayer::MediaKeyException cancelKeyRequest(const String&, const String&) override { return MediaPlayer::InvalidPlayerState; }
+ MediaPlayer::MediaKeyException generateKeyRequest(const String&, const unsigned char*, unsigned) override { return MediaPlayer::InvalidPlayerState; }
+ MediaPlayer::MediaKeyException addKey(const String&, const unsigned char*, unsigned, const unsigned char*, unsigned, const String&) override { return MediaPlayer::InvalidPlayerState; }
+ MediaPlayer::MediaKeyException cancelKeyRequest(const String&, const String&) override { return MediaPlayer::InvalidPlayerState; }
#endif
};
Modified: trunk/Source/WebCore/platform/graphics/filters/DistantLightSource.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/filters/DistantLightSource.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/filters/DistantLightSource.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -40,10 +40,10 @@
virtual bool setAzimuth(float) override;
virtual bool setElevation(float) override;
- virtual void initPaintingData(PaintingData&);
- virtual void updatePaintingData(PaintingData&, int x, int y, float z);
+ virtual void initPaintingData(PaintingData&) override;
+ virtual void updatePaintingData(PaintingData&, int x, int y, float z) override;
- virtual TextStream& externalRepresentation(TextStream&) const;
+ virtual TextStream& externalRepresentation(TextStream&) const override;
private:
DistantLightSource(float azimuth, float elevation)
Modified: trunk/Source/WebCore/platform/graphics/filters/FEComposite.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/filters/FEComposite.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/filters/FEComposite.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -60,12 +60,12 @@
virtual void correctFilterResultIfNeeded() override;
- virtual void platformApplySoftware();
- virtual void dump();
+ virtual void platformApplySoftware() override;
+ virtual void dump() override;
- virtual void determineAbsolutePaintRect();
+ virtual void determineAbsolutePaintRect() override;
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ virtual TextStream& externalRepresentation(TextStream&, int indention) const override;
protected:
virtual bool requiresValidPreMultipliedPixels() override { return m_type != FECOMPOSITE_OPERATOR_ARITHMETIC; }
Modified: trunk/Source/WebCore/platform/graphics/filters/FEDisplacementMap.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/filters/FEDisplacementMap.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/filters/FEDisplacementMap.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -52,12 +52,12 @@
void setResultColorSpace(ColorSpace) override;
virtual void transformResultColorSpace(FilterEffect*, const int) override;
- virtual void platformApplySoftware();
- virtual void dump();
+ virtual void platformApplySoftware() override;
+ virtual void dump() override;
- virtual void determineAbsolutePaintRect() { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
+ virtual void determineAbsolutePaintRect() override { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ virtual TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
FEDisplacementMap(Filter&, ChannelSelectorType xChannelSelector, ChannelSelectorType yChannelSelector, float);
Modified: trunk/Source/WebCore/platform/graphics/filters/FEFlood.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/filters/FEFlood.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/filters/FEFlood.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -45,15 +45,15 @@
void setResultColorSpace(ColorSpace) override { FilterEffect::setResultColorSpace(ColorSpaceDeviceRGB); }
#endif
- virtual void platformApplySoftware();
+ virtual void platformApplySoftware() override;
#if ENABLE(OPENCL)
- virtual bool platformApplyOpenCL();
+ virtual bool platformApplyOpenCL() override;
#endif
- virtual void dump();
+ virtual void dump() override;
- virtual void determineAbsolutePaintRect() { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
+ virtual void determineAbsolutePaintRect() override { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
- virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+ virtual TextStream& externalRepresentation(TextStream&, int indention) const override;
private:
FEFlood(Filter&, const Color&, float);
Modified: trunk/Source/WebCore/platform/graphics/filters/PointLightSource.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/filters/PointLightSource.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/filters/PointLightSource.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -39,10 +39,10 @@
virtual bool setY(float) override;
virtual bool setZ(float) override;
- virtual void initPaintingData(PaintingData&);
- virtual void updatePaintingData(PaintingData&, int x, int y, float z);
+ virtual void initPaintingData(PaintingData&) override;
+ virtual void updatePaintingData(PaintingData&, int x, int y, float z) override;
- virtual TextStream& externalRepresentation(TextStream&) const;
+ virtual TextStream& externalRepresentation(TextStream&) const override;
private:
PointLightSource(const FloatPoint3D& position)
Modified: trunk/Source/WebCore/platform/graphics/filters/SpotLightSource.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/filters/SpotLightSource.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/filters/SpotLightSource.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -50,10 +50,10 @@
virtual bool setSpecularExponent(float) override;
virtual bool setLimitingConeAngle(float) override;
- virtual void initPaintingData(PaintingData&);
- virtual void updatePaintingData(PaintingData&, int x, int y, float z);
+ virtual void initPaintingData(PaintingData&) override;
+ virtual void updatePaintingData(PaintingData&, int x, int y, float z) override;
- virtual TextStream& externalRepresentation(TextStream&) const;
+ virtual TextStream& externalRepresentation(TextStream&) const override;
private:
SpotLightSource(const FloatPoint3D& position, const FloatPoint3D& direction,
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -69,42 +69,42 @@
gboolean handleMessage(GstMessage*);
void handlePluginInstallerResult(GstInstallPluginsReturn);
- bool hasVideo() const { return m_hasVideo; }
- bool hasAudio() const { return m_hasAudio; }
+ bool hasVideo() const override { return m_hasVideo; }
+ bool hasAudio() const override { return m_hasAudio; }
- void load(const String &url);
+ void load(const String &url) override;
#if ENABLE(MEDIA_SOURCE)
- void load(const String& url, MediaSourcePrivateClient*);
+ void load(const String& url, MediaSourcePrivateClient*) override;
#endif
#if ENABLE(MEDIA_STREAM)
- void load(MediaStreamPrivate*);
+ void load(MediaStreamPrivate*) override;
#endif
void commitLoad();
- void cancelLoad();
+ void cancelLoad() override;
- void prepareToPlay();
- void play();
- void pause();
+ void prepareToPlay() override;
+ void play() override;
+ void pause() override;
- bool paused() const;
- bool seeking() const;
+ bool paused() const override;
+ bool seeking() const override;
- float duration() const;
- float currentTime() const;
- void seek(float);
+ float duration() const override;
+ float currentTime() const override;
+ void seek(float) override;
- void setRate(float);
+ void setRate(float) override;
double rate() const override;
- void setPreservesPitch(bool);
+ void setPreservesPitch(bool) override;
- void setPreload(MediaPlayer::Preload);
+ void setPreload(MediaPlayer::Preload) override;
void fillTimerFired();
- std::unique_ptr<PlatformTimeRanges> buffered() const;
- float maxTimeSeekable() const;
- bool didLoadingProgress() const;
- unsigned long long totalBytes() const;
- float maxTimeLoaded() const;
+ std::unique_ptr<PlatformTimeRanges> buffered() const override;
+ float maxTimeSeekable() const override;
+ bool didLoadingProgress() const override;
+ unsigned long long totalBytes() const override;
+ float maxTimeLoaded() const override;
void loadStateChanged();
void timeChanged();
@@ -128,16 +128,16 @@
#endif
void sourceChanged();
- GstElement* audioSink() const;
+ GstElement* audioSink() const override;
void setAudioStreamProperties(GObject*);
- void simulateAudioInterruption();
+ void simulateAudioInterruption() override;
bool changePipelineState(GstState);
#if ENABLE(WEB_AUDIO)
- AudioSourceProvider* audioSourceProvider() { return reinterpret_cast<AudioSourceProvider*>(m_audioSourceProvider.get()); }
+ AudioSourceProvider* audioSourceProvider() override { return reinterpret_cast<AudioSourceProvider*>(m_audioSourceProvider.get()); }
#endif
private:
@@ -146,7 +146,7 @@
static bool isAvailable();
- GstElement* createAudioSink();
+ GstElement* createAudioSink() override;
float playbackPosition() const;
@@ -172,17 +172,17 @@
void updatePlaybackRate();
- virtual String engineDescription() const { return "GStreamer"; }
- virtual bool isLiveStream() const { return m_isStreaming; }
- virtual bool didPassCORSAccessCheck() const;
- virtual bool canSaveMediaData() const override;
+ String engineDescription() const override { return "GStreamer"; }
+ bool isLiveStream() const override { return m_isStreaming; }
+ bool didPassCORSAccessCheck() const override;
+ bool canSaveMediaData() const override;
#if ENABLE(MEDIA_SOURCE)
// TODO: Implement
- virtual unsigned long totalVideoFrames() { return 0; }
- virtual unsigned long droppedVideoFrames() { return 0; }
- virtual unsigned long corruptedVideoFrames() { return 0; }
- virtual MediaTime totalFrameDelay() { return MediaTime::zeroTime(); }
+ unsigned long totalVideoFrames() override { return 0; }
+ unsigned long droppedVideoFrames() override { return 0; }
+ unsigned long corruptedVideoFrames() override { return 0; }
+ MediaTime totalFrameDelay() override { return MediaTime::zeroTime(); }
#endif
private:
Modified: trunk/Source/WebCore/platform/graphics/texmap/BitmapTextureGL.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/texmap/BitmapTextureGL.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/texmap/BitmapTextureGL.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -36,22 +36,22 @@
class BitmapTextureGL : public BitmapTexture {
public:
BitmapTextureGL(PassRefPtr<GraphicsContext3D>);
+ virtual ~BitmapTextureGL();
- virtual IntSize size() const;
- virtual bool isValid() const;
- virtual bool canReuseWith(const IntSize& contentsSize, Flags = 0);
- virtual void didReset();
+ virtual IntSize size() const override;
+ virtual bool isValid() const override;
+ virtual bool canReuseWith(const IntSize& contentsSize, Flags = 0) override;
+ virtual void didReset() override;
void bindAsSurface(GraphicsContext3D*);
void initializeStencil();
void initializeDepthBuffer();
- ~BitmapTextureGL();
virtual uint32_t id() const { return m_id; }
uint32_t textureTarget() const { return GraphicsContext3D::TEXTURE_2D; }
IntSize textureSize() const { return m_textureSize; }
- void updateContents(Image*, const IntRect&, const IntPoint&, UpdateContentsFlag);
- virtual void updateContents(const void*, const IntRect& target, const IntPoint& sourceOffset, int bytesPerLine, UpdateContentsFlag);
+ virtual void updateContents(Image*, const IntRect&, const IntPoint&, UpdateContentsFlag) override;
+ virtual void updateContents(const void*, const IntRect& target, const IntPoint& sourceOffset, int bytesPerLine, UpdateContentsFlag) override;
void updateContentsNoSwizzle(const void*, const IntRect& target, const IntPoint& sourceOffset, int bytesPerLine, unsigned bytesPerPixel = 4, Platform3DObject glFormat = GraphicsContext3D::RGBA);
- virtual bool isBackedByOpenGL() const { return true; }
+ virtual bool isBackedByOpenGL() const override { return true; }
virtual PassRefPtr<BitmapTexture> applyFilters(TextureMapper*, const FilterOperations&) override;
struct FilterInfo {
Modified: trunk/Source/WebCore/platform/graphics/transforms/Matrix3DTransformOperation.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/transforms/Matrix3DTransformOperation.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/transforms/Matrix3DTransformOperation.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -47,7 +47,7 @@
private:
virtual bool isIdentity() const override { return m_matrix.isIdentity(); }
- virtual bool isAffectedByTransformOrigin() const { return !isIdentity(); }
+ virtual bool isAffectedByTransformOrigin() const override { return !isIdentity(); }
virtual OperationType type() const override { return MATRIX_3D; }
virtual bool isSameType(const TransformOperation& o) const override { return o.type() == MATRIX_3D; }
Modified: trunk/Source/WebCore/platform/graphics/transforms/MatrixTransformOperation.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/transforms/MatrixTransformOperation.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/transforms/MatrixTransformOperation.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -52,7 +52,7 @@
private:
virtual bool isIdentity() const override { return m_a == 1 && m_b == 0 && m_c == 0 && m_d == 1 && m_e == 0 && m_f == 0; }
- virtual bool isAffectedByTransformOrigin() const { return !isIdentity(); }
+ virtual bool isAffectedByTransformOrigin() const override { return !isIdentity(); }
virtual OperationType type() const override { return MATRIX; }
virtual bool isSameType(const TransformOperation& o) const override { return o.type() == MATRIX; }
Modified: trunk/Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -49,7 +49,7 @@
private:
virtual bool isIdentity() const override { return !floatValueForLength(m_p, 1); }
- virtual bool isAffectedByTransformOrigin() const { return !isIdentity(); }
+ virtual bool isAffectedByTransformOrigin() const override { return !isIdentity(); }
virtual OperationType type() const override { return PERSPECTIVE; }
virtual bool isSameType(const TransformOperation& o) const override { return o.type() == PERSPECTIVE; }
Modified: trunk/Source/WebCore/platform/graphics/transforms/RotateTransformOperation.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/transforms/RotateTransformOperation.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/transforms/RotateTransformOperation.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -54,7 +54,7 @@
private:
virtual bool isIdentity() const override { return m_angle == 0; }
- virtual bool isAffectedByTransformOrigin() const { return !isIdentity(); }
+ virtual bool isAffectedByTransformOrigin() const override { return !isIdentity(); }
virtual OperationType type() const override { return m_type; }
virtual bool isSameType(const TransformOperation& o) const override { return o.type() == m_type; }
Modified: trunk/Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -53,7 +53,7 @@
private:
virtual bool isIdentity() const override { return m_x == 1 && m_y == 1 && m_z == 1; }
- virtual bool isAffectedByTransformOrigin() const { return !isIdentity(); }
+ virtual bool isAffectedByTransformOrigin() const override { return !isIdentity(); }
virtual OperationType type() const override { return m_type; }
virtual bool isSameType(const TransformOperation& o) const override { return o.type() == m_type; }
Modified: trunk/Source/WebCore/platform/graphics/transforms/SkewTransformOperation.h (185517 => 185518)
--- trunk/Source/WebCore/platform/graphics/transforms/SkewTransformOperation.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/graphics/transforms/SkewTransformOperation.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -47,7 +47,7 @@
private:
virtual bool isIdentity() const override { return m_angleX == 0 && m_angleY == 0; }
- virtual bool isAffectedByTransformOrigin() const { return !isIdentity(); }
+ virtual bool isAffectedByTransformOrigin() const override { return !isIdentity(); }
virtual OperationType type() const override { return m_type; }
virtual bool isSameType(const TransformOperation& o) const override { return o.type() == m_type; }
Modified: trunk/Source/WebCore/platform/image-decoders/png/PNGImageDecoder.h (185517 => 185518)
--- trunk/Source/WebCore/platform/image-decoders/png/PNGImageDecoder.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/image-decoders/png/PNGImageDecoder.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -42,18 +42,18 @@
virtual ~PNGImageDecoder();
// ImageDecoder
- virtual String filenameExtension() const { return "png"; }
+ virtual String filenameExtension() const override { return "png"; }
#if ENABLE(APNG)
virtual size_t frameCount() override { return m_frameCount; }
virtual int repetitionCount() const override { return m_playCount-1; }
#endif
- virtual bool isSizeAvailable();
- virtual bool setSize(unsigned width, unsigned height);
- virtual ImageFrame* frameBufferAtIndex(size_t index);
+ virtual bool isSizeAvailable() override;
+ virtual bool setSize(unsigned width, unsigned height) override;
+ virtual ImageFrame* frameBufferAtIndex(size_t index) override;
// CAUTION: setFailed() deletes |m_reader|. Be careful to avoid
// accessing deleted memory, especially when calling this from inside
// PNGImageReader!
- virtual bool setFailed();
+ virtual bool setFailed() override;
// Callbacks from libpng
void headerAvailable();
@@ -64,7 +64,7 @@
void frameHeader();
void init();
- virtual void clearFrameBufferCache(size_t clearBeforeFrame);
+ virtual void clearFrameBufferCache(size_t clearBeforeFrame) override;
#endif
bool isComplete() const
Modified: trunk/Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h (185517 => 185518)
--- trunk/Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -52,9 +52,9 @@
RealtimeMediaSourceCenterOwr();
~RealtimeMediaSourceCenterOwr();
- virtual void validateRequestConstraints(PassRefPtr<MediaStreamCreationClient>, PassRefPtr<MediaConstraints> audioConstraints, PassRefPtr<MediaConstraints> videoConstraints);
- virtual void createMediaStream(PassRefPtr<MediaStreamCreationClient>, PassRefPtr<MediaConstraints> audioConstraints, PassRefPtr<MediaConstraints> videoConstraints);
- virtual bool getMediaStreamTrackSources(PassRefPtr<MediaStreamTrackSourcesRequestClient>) override;
+ void validateRequestConstraints(PassRefPtr<MediaStreamCreationClient>, PassRefPtr<MediaConstraints> audioConstraints, PassRefPtr<MediaConstraints> videoConstraints) override;
+ void createMediaStream(PassRefPtr<MediaStreamCreationClient>, PassRefPtr<MediaConstraints> audioConstraints, PassRefPtr<MediaConstraints> videoConstraints) override;
+ bool getMediaStreamTrackSources(PassRefPtr<MediaStreamTrackSourcesRequestClient>) override;
void mediaSourcesAvailable(GList* sources);
Modified: trunk/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h (185517 => 185518)
--- trunk/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h 2015-06-12 18:43:01 UTC (rev 185517)
+++ trunk/Source/WebCore/platform/mock/MockRealtimeMediaSourceCenter.h 2015-06-12 18:48:53 UTC (rev 185518)
@@ -37,8 +37,8 @@
public:
WEBCORE_EXPORT static void registerMockRealtimeMediaSourceCenter();
- virtual void validateRequestConstraints(PassRefPtr<MediaStreamCreationClient>, PassRefPtr<MediaConstraints> audioConstraints, PassRefPtr<MediaConstraints> videoConstraints);
- virtual void createMediaStream(PassRefPtr<MediaStreamCreationClient>, PassRefPtr<MediaConstraints> audioConstraints, PassRefPtr<MediaConstraints> videoConstraints);
+ virtual void validateRequestConstraints(PassRefPtr<MediaStreamCreationClient>, PassRefPtr<MediaConstraints> audioConstraints, PassRefPtr<MediaConstraints> videoConstraints) override;
+ virtual void createMediaStream(PassRefPtr<MediaStreamCreationClient>, PassRefPtr<MediaConstraints> audioConstraints, PassRefPtr<MediaConstraints> videoConstraints) override;
virtual bool getMediaStreamTrackSources(PassRefPtr<MediaStreamTrackSourcesRequestClient>) override;
private:
