Title: [185847] trunk/Source/WTF
- Revision
- 185847
- Author
- ander...@apple.com
- Date
- 2015-06-22 15:07:20 -0700 (Mon, 22 Jun 2015)
Log Message
Get rid of the Windows specific BinarySemaphore implementation
https://bugs.webkit.org/show_bug.cgi?id=146216
Reviewed by Andreas Kling.
The fact that the Windows implementation uses a HEVENT internally was only useful
to the Windows port of WebKit2; we can get rid of it now.
* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:
* wtf/threads/BinarySemaphore.h:
(WTF::BinarySemaphore::event): Deleted.
* wtf/threads/win/BinarySemaphoreWin.cpp: Removed.
(WTF::BinarySemaphore::BinarySemaphore): Deleted.
(WTF::BinarySemaphore::~BinarySemaphore): Deleted.
(WTF::BinarySemaphore::signal): Deleted.
(WTF::BinarySemaphore::wait): Deleted.
Modified Paths
Removed Paths
- trunk/Source/WTF/wtf/threads/win/
Diff
Modified: trunk/Source/WTF/ChangeLog (185846 => 185847)
--- trunk/Source/WTF/ChangeLog 2015-06-22 22:06:45 UTC (rev 185846)
+++ trunk/Source/WTF/ChangeLog 2015-06-22 22:07:20 UTC (rev 185847)
@@ -1,3 +1,23 @@
+2015-06-22 Anders Carlsson <ander...@apple.com>
+
+ Get rid of the Windows specific BinarySemaphore implementation
+ https://bugs.webkit.org/show_bug.cgi?id=146216
+
+ Reviewed by Andreas Kling.
+
+ The fact that the Windows implementation uses a HEVENT internally was only useful
+ to the Windows port of WebKit2; we can get rid of it now.
+
+ * WTF.vcxproj/WTF.vcxproj:
+ * WTF.vcxproj/WTF.vcxproj.filters:
+ * wtf/threads/BinarySemaphore.h:
+ (WTF::BinarySemaphore::event): Deleted.
+ * wtf/threads/win/BinarySemaphoreWin.cpp: Removed.
+ (WTF::BinarySemaphore::BinarySemaphore): Deleted.
+ (WTF::BinarySemaphore::~BinarySemaphore): Deleted.
+ (WTF::BinarySemaphore::signal): Deleted.
+ (WTF::BinarySemaphore::wait): Deleted.
+
2015-06-21 Gavin Barraclough <barraclo...@apple.com>
Page load performance regression due to bugs.webkit.org/show_bug.cgi?id=145542
Modified: trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj (185846 => 185847)
--- trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj 2015-06-22 22:06:45 UTC (rev 185846)
+++ trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj 2015-06-22 22:07:20 UTC (rev 185847)
@@ -145,7 +145,6 @@
<ClCompile Include="..\wtf\ThreadingWin.cpp" />
<ClCompile Include="..\wtf\threadspecificWin.cpp" />
<ClCompile Include="..\wtf\threads\BinarySemaphore.cpp" />
- <ClCompile Include="..\wtf\threads\win\BinarySemaphoreWin.cpp" />
<ClCompile Include="..\wtf\unicode\icu\CollatorICU.cpp" />
<ClCompile Include="..\wtf\unicode\UTF8.cpp" />
<ClCompile Include="..\wtf\win\MainThreadWin.cpp" />
Modified: trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters (185846 => 185847)
--- trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters 2015-06-22 22:06:45 UTC (rev 185846)
+++ trunk/Source/WTF/WTF.vcxproj/WTF.vcxproj.filters 2015-06-22 22:07:20 UTC (rev 185847)
@@ -102,9 +102,6 @@
<ClCompile Include="..\wtf\win\MainThreadWin.cpp">
<Filter>wtf\win</Filter>
</ClCompile>
- <ClCompile Include="..\wtf\threads\win\BinarySemaphoreWin.cpp">
- <Filter>threads\win</Filter>
- </ClCompile>
<ClCompile Include="..\wtf\threads\BinarySemaphore.cpp">
<Filter>threads</Filter>
</ClCompile>
Modified: trunk/Source/WTF/wtf/threads/BinarySemaphore.h (185846 => 185847)
--- trunk/Source/WTF/wtf/threads/BinarySemaphore.h 2015-06-22 22:06:45 UTC (rev 185846)
+++ trunk/Source/WTF/wtf/threads/BinarySemaphore.h 2015-06-22 22:07:20 UTC (rev 185847)
@@ -41,19 +41,11 @@
WTF_EXPORT_PRIVATE void signal();
WTF_EXPORT_PRIVATE bool wait(double absoluteTime);
-#if PLATFORM(WIN)
- HANDLE event() const { return m_event; }
-#endif
-
private:
-#if PLATFORM(WIN)
- HANDLE m_event;
-#else
bool m_isSet;
Mutex m_mutex;
ThreadCondition m_condition;
-#endif
};
} // namespace WTF
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
