Title: [185871] trunk/Tools
- Revision
- 185871
- Author
- commit-qu...@webkit.org
- Date
- 2015-06-23 03:45:29 -0700 (Tue, 23 Jun 2015)
Log Message
Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=146007
Patch by Tanay C <tana...@samsung.com> on 2015-06-23
Reviewed by Darin Adler.
* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
(pluginLogWithWindowObject):
(pluginLogWithArguments):
(pluginLog):
* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
(PluginTest::executeScript):
(PluginTest::log):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (185870 => 185871)
--- trunk/Tools/ChangeLog 2015-06-23 09:34:04 UTC (rev 185870)
+++ trunk/Tools/ChangeLog 2015-06-23 10:45:29 UTC (rev 185871)
@@ -1,3 +1,19 @@
+2015-06-23 Tanay C <tana...@samsung.com>
+
+ Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
+ https://bugs.webkit.org/show_bug.cgi?id=146007
+
+ Reviewed by Darin Adler.
+
+ * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
+ * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
+ (pluginLogWithWindowObject):
+ (pluginLogWithArguments):
+ (pluginLog):
+ * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
+ (PluginTest::executeScript):
+ (PluginTest::log):
+
2015-06-23 Csaba Osztrogonác <o...@webkit.org>
[EFL] Add libhyphen-dev as dependency after r185862
Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt (185870 => 185871)
--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt 2015-06-23 09:34:04 UTC (rev 185870)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt 2015-06-23 10:45:29 UTC (rev 185871)
@@ -33,6 +33,7 @@
${WEBKIT_TESTNETSCAPEPLUGIN_DIR}
${WEBKIT_TESTNETSCAPEPLUGIN_DIR}/unix/ForwardingHeaders
${WEBCORE_DIR}
+ ${WTF_DIR}
)
set(WebKitTestNetscapePlugin_SYSTEM_INCLUDE_DIRECTORIES
Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp (185870 => 185871)
--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp 2015-06-23 09:34:04 UTC (rev 185870)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp 2015-06-23 10:45:29 UTC (rev 185871)
@@ -34,6 +34,9 @@
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
+#include <wtf/Platform.h>
+#include <wtf/ExportMacros.h>
+#include <wtf/Assertions.h>
// Helper function which takes in the plugin window object for logging to the console object.
static void pluginLogWithWindowObject(NPObject* windowObject, NPP instance, const char* message)
@@ -60,6 +63,7 @@
browser->releaseobject(consoleObject);
}
+WTF_ATTRIBUTE_PRINTF(2, 0)
void pluginLogWithArguments(NPP instance, const char* format, va_list args)
{
const size_t messageBufferSize = 2048;
@@ -80,6 +84,7 @@
}
// Helper function to log to the console object.
+WTF_ATTRIBUTE_PRINTF(2, 3)
void pluginLog(NPP instance, const char* format, ...)
{
va_list args;
Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp (185870 => 185871)
--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp 2015-06-23 09:34:04 UTC (rev 185870)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp 2015-06-23 10:45:29 UTC (rev 185871)
@@ -28,6 +28,9 @@
#include "PluginObject.h"
#include <assert.h>
#include <string.h>
+#include <wtf/Platform.h>
+#include <wtf/ExportMacros.h>
+#include <wtf/Assertions.h>
#if defined(XP_UNIX) || defined(ANDROID)
#include <unistd.h>
@@ -254,6 +257,7 @@
browser->releasevariantvalue(&browserResult);
}
+WTF_ATTRIBUTE_PRINTF(2, 3)
void PluginTest::log(const char* format, ...)
{
va_list args;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
