Title: [186084] trunk/Source/WebCore
- Revision
- 186084
- Author
- mra...@apple.com
- Date
- 2015-06-29 14:01:29 -0700 (Mon, 29 Jun 2015)
Log Message
MediaSession: use a HashSet for the collection of participating elements
https://bugs.webkit.org/show_bug.cgi?id=146421
Reviewed by Eric Carlson.
* Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::addMediaElement):
(WebCore::MediaSession::removeMediaElement):
* Modules/mediasession/MediaSession.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (186083 => 186084)
--- trunk/Source/WebCore/ChangeLog 2015-06-29 20:53:59 UTC (rev 186083)
+++ trunk/Source/WebCore/ChangeLog 2015-06-29 21:01:29 UTC (rev 186084)
@@ -1,3 +1,15 @@
+2015-06-29 Matt Rajca <mra...@apple.com>
+
+ MediaSession: use a HashSet for the collection of participating elements
+ https://bugs.webkit.org/show_bug.cgi?id=146421
+
+ Reviewed by Eric Carlson.
+
+ * Modules/mediasession/MediaSession.cpp:
+ (WebCore::MediaSession::addMediaElement):
+ (WebCore::MediaSession::removeMediaElement):
+ * Modules/mediasession/MediaSession.h:
+
2015-06-29 Dean Jackson <d...@apple.com>
Setting to enable/disable media controls sizing on page zoom
Modified: trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp (186083 => 186084)
--- trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp 2015-06-29 20:53:59 UTC (rev 186083)
+++ trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp 2015-06-29 21:01:29 UTC (rev 186084)
@@ -107,13 +107,13 @@
void MediaSession::addMediaElement(HTMLMediaElement& element)
{
ASSERT(!m_participatingElements.contains(&element));
- m_participatingElements.append(&element);
+ m_participatingElements.add(&element);
}
void MediaSession::removeMediaElement(HTMLMediaElement& element)
{
ASSERT(m_participatingElements.contains(&element));
- m_participatingElements.remove(m_participatingElements.find(&element));
+ m_participatingElements.remove(&element);
}
void MediaSession::addActiveMediaElement(HTMLMediaElement& element)
Modified: trunk/Source/WebCore/Modules/mediasession/MediaSession.h (186083 => 186084)
--- trunk/Source/WebCore/Modules/mediasession/MediaSession.h 2015-06-29 20:53:59 UTC (rev 186083)
+++ trunk/Source/WebCore/Modules/mediasession/MediaSession.h 2015-06-29 21:01:29 UTC (rev 186084)
@@ -92,7 +92,7 @@
void releaseInternal();
State m_currentState { State::Idle };
- Vector<HTMLMediaElement*> m_participatingElements;
+ HashSet<HTMLMediaElement*> m_participatingElements;
HashSet<HTMLMediaElement*> m_activeParticipatingElements;
HashSet<HTMLMediaElement*>* m_iteratedActiveParticipatingElements { nullptr };
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
