Title: [186100] trunk/Source/WebInspectorUI
- Revision
- 186100
- Author
- commit-qu...@webkit.org
- Date
- 2015-06-29 17:37:10 -0700 (Mon, 29 Jun 2015)
Log Message
Web Inspector: Network errors (404) are missing location link in console messages
https://bugs.webkit.org/show_bug.cgi?id=146442
Patch by Joseph Pecoraro <pecor...@apple.com> on 2015-06-29
Reviewed by Darin Adler.
* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
Restore behavior of adding a location link for network messages with urls.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (186099 => 186100)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-30 00:32:20 UTC (rev 186099)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-30 00:37:10 UTC (rev 186100)
@@ -1,5 +1,16 @@
2015-06-29 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Network errors (404) are missing location link in console messages
+ https://bugs.webkit.org/show_bug.cgi?id=146442
+
+ Reviewed by Darin Adler.
+
+ * UserInterface/Views/ConsoleMessageView.js:
+ (WebInspector.ConsoleMessageView.prototype._appendLocationLink):
+ Restore behavior of adding a location link for network messages with urls.
+
+2015-06-29 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: iOS 8: Resources Timeline Data does not show up
https://bugs.webkit.org/show_bug.cgi?id=146433
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js (186099 => 186100)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-06-30 00:32:20 UTC (rev 186099)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-06-30 00:37:10 UTC (rev 186100)
@@ -264,7 +264,7 @@
return;
}
- // FIXME: Better handle WebInspector.ConsoleMessage.MessageSource.Network.
+ // FIXME: Better handle WebInspector.ConsoleMessage.MessageSource.Network once it has request info.
var args = this._message.parameters || [this._message.messageText];
this._appendFormattedArguments(element, args);
@@ -290,9 +290,14 @@
_appendLocationLink()
{
- // FIXME: Better handle WebInspector.ConsoleMessage.MessageSource.Network.
- if (this._message.source === WebInspector.ConsoleMessage.MessageSource.Network || this._message.request)
+ if (this._message.source === WebInspector.ConsoleMessage.MessageSource.Network) {
+ if (this._message.url) {
+ var anchor = WebInspector.linkifyURLAsNode(this._message.url, this._message.url, "console-message-url");
+ anchor.classList.add("console-message-location");
+ this._element.appendChild(anchor);
+ }
return;
+ }
var firstNonNativeCallFrame = this._message.stackTrace.firstNonNativeCallFrame;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
