Title: [186121] trunk/Source/WebKit/win
- Revision
- 186121
- Author
- [email protected]
- Date
- 2015-06-30 10:32:28 -0700 (Tue, 30 Jun 2015)
Log Message
[Win] webViewAddMessageToConsole always gets 1 for isError
https://bugs.webkit.org/show_bug.cgi?id=146457
<rdar://problem/21606395>
Reviewed by Zalan Bujtas.
* WebCoreSupport/WebChromeClient.cpp:
(messageIsError): Added.
(WebChromeClient::addMessageToConsole): Only pass true for
isError if the message is an error message.
Modified Paths
Diff
Modified: trunk/Source/WebKit/win/ChangeLog (186120 => 186121)
--- trunk/Source/WebKit/win/ChangeLog 2015-06-30 17:20:20 UTC (rev 186120)
+++ trunk/Source/WebKit/win/ChangeLog 2015-06-30 17:32:28 UTC (rev 186121)
@@ -1,3 +1,16 @@
+2015-06-30 Brent Fulgham <[email protected]>
+
+ [Win] webViewAddMessageToConsole always gets 1 for isError
+ https://bugs.webkit.org/show_bug.cgi?id=146457
+ <rdar://problem/21606395>
+
+ Reviewed by Zalan Bujtas.
+
+ * WebCoreSupport/WebChromeClient.cpp:
+ (messageIsError): Added.
+ (WebChromeClient::addMessageToConsole): Only pass true for
+ isError if the message is an error message.
+
2015-06-30 Per Arne Vollan <[email protected]>
[WinCairo] Compile error, WebEditorClient::didApplyStyle() should not have any parameters.
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp (186120 => 186121)
--- trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp 2015-06-30 17:20:20 UTC (rev 186120)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp 2015-06-30 17:32:28 UTC (rev 186121)
@@ -334,6 +334,11 @@
}
}
+static BOOL messageIsError(MessageLevel level)
+{
+ return level == MessageLevel::Error;
+}
+
void WebChromeClient::addMessageToConsole(MessageSource source, MessageLevel level, const String& message, unsigned lineNumber, unsigned columnNumber, const String& url)
{
UNUSED_PARAM(columnNumber);
@@ -342,7 +347,7 @@
if (SUCCEEDED(m_webView->uiDelegate(&uiDelegate))) {
COMPtr<IWebUIDelegatePrivate> uiPrivate;
if (SUCCEEDED(uiDelegate->QueryInterface(IID_IWebUIDelegatePrivate, (void**)&uiPrivate)))
- uiPrivate->webViewAddMessageToConsole(m_webView, BString(message), lineNumber, BString(url), true);
+ uiPrivate->webViewAddMessageToConsole(m_webView, BString(message), lineNumber, BString(url), messageIsError(level));
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
