Title: [186210] trunk/Source/WebCore
- Revision
- 186210
- Author
- bfulg...@apple.com
- Date
- 2015-07-01 17:36:15 -0700 (Wed, 01 Jul 2015)
Log Message
[Win] REGRESSION (r185124) CACFLayer handling broken
https://bugs.webkit.org/show_bug.cgi?id=146530
<rdar://problem/21642241>
Reviewed by Tim Horton.
At some point in the past, the set of LayerChange flags
overflowed the default MSVC enum type of 'int'. This caused
Windows rendering code to not receive various update notifications.
Zalan's change moved the DebugIndicatorsChanged flag into that
overflow set, which made it obvious that something was wrong.
The fix is to tell the compiler to use a compatible base type
for the enum.
* platform/graphics/ca/GraphicsLayerCA.h: Prevent overflow.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (186209 => 186210)
--- trunk/Source/WebCore/ChangeLog 2015-07-02 00:32:46 UTC (rev 186209)
+++ trunk/Source/WebCore/ChangeLog 2015-07-02 00:36:15 UTC (rev 186210)
@@ -1,3 +1,23 @@
+2015-07-01 Brent Fulgham <bfulg...@apple.com>
+
+ [Win] REGRESSION (r185124) CACFLayer handling broken
+ https://bugs.webkit.org/show_bug.cgi?id=146530
+ <rdar://problem/21642241>
+
+ Reviewed by Tim Horton.
+
+ At some point in the past, the set of LayerChange flags
+ overflowed the default MSVC enum type of 'int'. This caused
+ Windows rendering code to not receive various update notifications.
+
+ Zalan's change moved the DebugIndicatorsChanged flag into that
+ overflow set, which made it obvious that something was wrong.
+
+ The fix is to tell the compiler to use a compatible base type
+ for the enum.
+
+ * platform/graphics/ca/GraphicsLayerCA.h: Prevent overflow.
+
2015-07-01 Alex Christensen <achristen...@webkit.org>
Reduce resolution of performance.now.
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h (186209 => 186210)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h 2015-07-02 00:32:46 UTC (rev 186209)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h 2015-07-02 00:36:15 UTC (rev 186210)
@@ -443,7 +443,7 @@
bool appendToUncommittedAnimations(const KeyframeValueList&, const TransformOperations*, const Animation*, const String& animationName, const FloatSize& boxSize, int animationIndex, double timeOffset, bool isMatrixAnimation);
bool appendToUncommittedAnimations(const KeyframeValueList&, const FilterOperation*, const Animation*, const String& animationName, int animationIndex, double timeOffset);
- enum LayerChange {
+ enum LayerChange : uint64_t {
NoChange = 0,
NameChanged = 1LLU << 1,
ChildrenChanged = 1LLU << 2, // also used for content layer, and preserves-3d, and size if tiling changes?
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
