Title: [186445] releases/WebKitGTK/webkit-2.8/Source/WebCore
- Revision
- 186445
- Author
- [email protected]
- Date
- 2015-07-07 04:21:04 -0700 (Tue, 07 Jul 2015)
Log Message
Merge r186263 - Crash on xLarge memory allocation using bmalloc on 32bit systems
https://bugs.webkit.org/show_bug.cgi?id=146440
Reviewed by Gustavo Noronha Silva.
Disable the gcc's -ftree-sra optimization (automatically enabled
with -O1 and higher levels) for WebCore and 32bit Intel architectures,
as that causes the crash in bmalloc when allocating large amounts of
memory from the texture mapper's tiled backing store implementation.
* CMakeLists.txt: Pass -fno-free-sra to gcc on 32bit Intel architectures.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/CMakeLists.txt (186444 => 186445)
--- releases/WebKitGTK/webkit-2.8/Source/WebCore/CMakeLists.txt 2015-07-07 11:11:02 UTC (rev 186444)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/CMakeLists.txt 2015-07-07 11:21:04 UTC (rev 186445)
@@ -3478,6 +3478,14 @@
set_target_properties(WebCore PROPERTIES COMPILE_DEFINITIONS "BUILDING_WebCore")
set_target_properties(WebCore PROPERTIES FOLDER "WebCore")
+# The -ftree-sra optimization (implicit with -O2) causes crashes when
+# allocating large chunks of memory using bmalloc on Intel 32bit.
+# See https://bugs.webkit.org/show_bug.cgi?id=146440
+string(TOLOWER ${CMAKE_HOST_SYSTEM_PROCESSOR} LOWERCASE_CMAKE_HOST_SYSTEM_PROCESSOR)
+if (CMAKE_COMPILER_IS_GNUCXX AND "${LOWERCASE_CMAKE_HOST_SYSTEM_PROCESSOR}" MATCHES "(i[3-6]86|x86)$")
+ ADD_TARGET_PROPERTIES(WebCore COMPILE_FLAGS "-fno-tree-sra")
+endif ()
+
if (WebCore_OUTPUT_NAME)
set_target_properties(WebCore PROPERTIES OUTPUT_NAME ${WebCore_OUTPUT_NAME})
endif ()
Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (186444 => 186445)
--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-07-07 11:11:02 UTC (rev 186444)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog 2015-07-07 11:21:04 UTC (rev 186445)
@@ -1,3 +1,17 @@
+2015-07-03 Mario Sanchez Prada <[email protected]>
+
+ Crash on xLarge memory allocation using bmalloc on 32bit systems
+ https://bugs.webkit.org/show_bug.cgi?id=146440
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Disable the gcc's -ftree-sra optimization (automatically enabled
+ with -O1 and higher levels) for WebCore and 32bit Intel architectures,
+ as that causes the crash in bmalloc when allocating large amounts of
+ memory from the texture mapper's tiled backing store implementation.
+
+ * CMakeLists.txt: Pass -fno-free-sra to gcc on 32bit Intel architectures.
+
2015-06-30 Ryosuke Niwa <[email protected]>
REGRESSION (r179168): Characters overlap after resizing the font on the copy-pasted Japanese text
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
