Title: [186897] trunk/Source/WebKit2
- Revision
- 186897
- Author
- beid...@apple.com
- Date
- 2015-07-16 10:39:05 -0700 (Thu, 16 Jul 2015)
Log Message
Review feedback followup for:
REGRESSION(r186088): Crash under WebKit::WebPageProxy::didFailLoadForFrame
<rdar://problem/21692212> and https://bugs.webkit.org/show_bug.cgi?id=146988
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::refView): CFRetain instead of Obj-C retain.
(WebKit::PageClientImpl::derefView): CFRelease instead of Obj-C release.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186896 => 186897)
--- trunk/Source/WebKit2/ChangeLog 2015-07-16 17:26:55 UTC (rev 186896)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-16 17:39:05 UTC (rev 186897)
@@ -1,3 +1,14 @@
+2015-07-16 Brady Eidson <beid...@apple.com>
+
+ Review feedback followup for:
+ REGRESSION(r186088): Crash under WebKit::WebPageProxy::didFailLoadForFrame
+ <rdar://problem/21692212> and https://bugs.webkit.org/show_bug.cgi?id=146988
+
+ * UIProcess/mac/PageClientImpl.mm:
+ (WebKit::PageClientImpl::refView): CFRetain instead of Obj-C retain.
+ (WebKit::PageClientImpl::derefView): CFRelease instead of Obj-C release.
+
+
2015-07-16 Michael Catanzaro <mcatanz...@igalia.com>
[Linux] Seccomp: fix -Wmismatched-tags
Modified: trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm (186896 => 186897)
--- trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm 2015-07-16 17:26:55 UTC (rev 186896)
+++ trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm 2015-07-16 17:39:05 UTC (rev 186897)
@@ -838,12 +838,12 @@
void PageClientImpl::refView()
{
- [m_wkView retain];
+ CFRetain(m_wkView);
}
void PageClientImpl::derefView()
{
- [m_wkView release];
+ CFRelease(m_wkView);
}
} // namespace WebKit
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
