Title: [187571] trunk/Source/WebCore
- Revision
- 187571
- Author
- gyuyoung....@webkit.org
- Date
- 2015-07-29 19:00:31 -0700 (Wed, 29 Jul 2015)
Log Message
[EFL][CoordinatedGraphics] fixed position banner is moved when enabling delegateScrolling
https://bugs.webkit.org/show_bug.cgi?id=146959
Reviewed by Simon Fraser.
Don't update fixed visible content area in ScrollingCoordinatorCoordinatedGraphics::requestScrollPositionUpdate
because PageViewportController and WebView on CoordinatedGraphics also update the visible content area according
to the scrolling. So this problem has been caused by duplicated fixed visible rect update.
EFL WTR doesn't work with fixed layout and delegatesScrolling yet. So no test for this issue.
* page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::requestScrollPositionUpdate): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (187570 => 187571)
--- trunk/Source/WebCore/ChangeLog 2015-07-30 01:18:04 UTC (rev 187570)
+++ trunk/Source/WebCore/ChangeLog 2015-07-30 02:00:31 UTC (rev 187571)
@@ -1,3 +1,19 @@
+2015-07-29 Gyuyoung Kim <gyuyoung....@webkit.org>
+
+ [EFL][CoordinatedGraphics] fixed position banner is moved when enabling delegateScrolling
+ https://bugs.webkit.org/show_bug.cgi?id=146959
+
+ Reviewed by Simon Fraser.
+
+ Don't update fixed visible content area in ScrollingCoordinatorCoordinatedGraphics::requestScrollPositionUpdate
+ because PageViewportController and WebView on CoordinatedGraphics also update the visible content area according
+ to the scrolling. So this problem has been caused by duplicated fixed visible rect update.
+
+ EFL WTR doesn't work with fixed layout and delegatesScrolling yet. So no test for this issue.
+
+ * page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
+ (WebCore::ScrollingCoordinatorCoordinatedGraphics::requestScrollPositionUpdate): Deleted.
+
2015-07-29 Myles C. Maxfield <mmaxfi...@apple.com>
Use rvalue references in FontCascade
Modified: trunk/Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp (187570 => 187571)
--- trunk/Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp 2015-07-30 01:18:04 UTC (rev 187570)
+++ trunk/Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp 2015-07-30 02:00:31 UTC (rev 187571)
@@ -117,7 +117,6 @@
if (!frameView.delegatesScrolling())
return false;
- frameView.setFixedVisibleContentRect(IntRect(scrollPosition, frameView.visibleContentRect().size()));
frameView.hostWindow()->delegatedScrollRequested(scrollPosition);
return true;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
