Diff
Modified: trunk/ChangeLog (187595 => 187596)
--- trunk/ChangeLog 2015-07-30 18:39:42 UTC (rev 187595)
+++ trunk/ChangeLog 2015-07-30 18:47:37 UTC (rev 187596)
@@ -1,3 +1,12 @@
+2015-07-30 Joonghun Park <jh718.p...@samsung.com>
+
+ [EFL] Enable IndexedDB based on DatabaseProcess
+ https://bugs.webkit.org/show_bug.cgi?id=147221
+
+ Reviewed by Csaba Osztrogonác.
+
+ * Source/cmake/OptionsEfl.cmake:
+
2015-07-30 Alex Christensen <achristen...@webkit.org>
Build AppleWin port with CMake
Modified: trunk/LayoutTests/ChangeLog (187595 => 187596)
--- trunk/LayoutTests/ChangeLog 2015-07-30 18:39:42 UTC (rev 187595)
+++ trunk/LayoutTests/ChangeLog 2015-07-30 18:47:37 UTC (rev 187596)
@@ -1,3 +1,12 @@
+2015-07-30 Joonghun Park <jh718.p...@samsung.com>
+
+ [EFL] Enable IndexedDB based on DatabaseProcess
+ https://bugs.webkit.org/show_bug.cgi?id=147221
+
+ Reviewed by Csaba Osztrogonác.
+
+ * platform/efl/TestExpectations: Update IndexedDB test expectations.
+
2015-07-30 Nan Wang <n_w...@apple.com>
aria-liveregions-notifications tests are very flaky
Modified: trunk/LayoutTests/platform/efl/TestExpectations (187595 => 187596)
--- trunk/LayoutTests/platform/efl/TestExpectations 2015-07-30 18:39:42 UTC (rev 187595)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2015-07-30 18:47:37 UTC (rev 187596)
@@ -273,16 +273,106 @@
# ENABLE(DRAGGABLE_REGION) is disabled
fast/css/draggable-region-parser.html
-# IndexedDB is on refactoring/refreshing, so the tests are quite unstable at this point.
-webkit.org/b/87661 storage/indexeddb [ Skip ]
-webkit.org/b/87661 http/tests/security/cross-origin-indexeddb-allowed.html [ Skip ]
-webkit.org/b/87661 http/tests/security/cross-origin-indexeddb.html [ Skip ]
-webkit.org/b/87661 http/tests/security/cross-origin-worker-indexeddb-allowed.html [ Skip ]
-webkit.org/b/87661 http/tests/security/cross-origin-worker-indexeddb.html [ Skip ]
-webkit.org/b/87661 http/tests/security/no-indexeddb-from-sandbox.html [ Skip ]
+## IndexedDB related failures
+
+# Blink tests with unexplained timeouts
+storage/indexeddb/database-deletepending-flag.html [ Skip ]
+storage/indexeddb/exceptions.html [ Skip ]
+storage/indexeddb/intversion-gated-on-delete.html [ Skip ]
+storage/indexeddb/intversion-long-queue.html [ Skip ]
+storage/indexeddb/open-ordering.html [ Skip ]
+storage/indexeddb/transaction-basics.html [ Skip ]
+storage/indexeddb/transaction-coordination-within-database.html [ Skip ]
+
+# Blink tests with non-trivial text failures.
+storage/indexeddb/createIndex-after-failure.html [ Skip ]
+storage/indexeddb/create-object-store-options.html [ Skip ]
+storage/indexeddb/cursor-advance.html [ Skip ]
+storage/indexeddb/cursor-basics.html [ Skip ]
+storage/indexeddb/cursor-continue.html [ Skip ]
+storage/indexeddb/cursor-continue-validity.html [ Skip ]
+storage/indexeddb/cursor-continueprimarykey.html [ Skip ]
+storage/indexeddb/cursor-index-delete.html [ Skip ]
+storage/indexeddb/cursor-key-order.html [ Skip ]
+storage/indexeddb/cursor-leak.html [ Skip ] # Missing needed WKTR feature?
+storage/indexeddb/cursor-overloads.html [ Skip ]
+storage/indexeddb/cursor-primary-key-order.html [ Skip ]
+storage/indexeddb/cursor-request-cycle.html [ Skip ] # Missing needed WKTR feature?
+storage/indexeddb/cursor-update.html [ Skip ]
+storage/indexeddb/data-corruption.html [ Skip ]
+storage/indexeddb/database-close.html [ Skip ]
+storage/indexeddb/database-closepending-flag.html [ Skip ]
+storage/indexeddb/database-quota.html [ Skip ]
+storage/indexeddb/deleteIndex.html [ Skip ]
+storage/indexeddb/delete-in-upgradeneeded-close-in-open-success.html [ Skip ]
+storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange.html [ Skip ]
+storage/indexeddb/deletedatabase-blocked.html [ Skip ]
+storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange.html [ Skip ]
+storage/indexeddb/deletedatabase-delayed-by-versionchange.html [ Skip ]
+storage/indexeddb/deletedatabase-not-blocked.html [ Skip ]
+storage/indexeddb/deleted-objects.html [ Skip ]
+storage/indexeddb/duplicates.html [ Skip ] # Difference between null + undefined
+storage/indexeddb/events.html [ Skip ]
+storage/indexeddb/factory-basics.html [ Skip ] # indexedDB.webkitGetDatabaseNames is missing)
+storage/indexeddb/factory-cmp.html [ Skip ]
+storage/indexeddb/factory-deletedatabase.html [ Skip ]
+storage/indexeddb/get-keyrange.html [ Skip ]
+storage/indexeddb/index-basics.html [ Skip ] # Difference between null + undefined
+storage/indexeddb/index-duplicate-keypaths.html [ Skip ]
+storage/indexeddb/index-multientry.html [ Skip ]
+storage/indexeddb/index-population.html [ Skip ]
+storage/indexeddb/index-unique.html [ Skip ]
+storage/indexeddb/intversion-blocked.html [ Skip ]
+storage/indexeddb/intversion-close-between-events.html [ Skip ]
+storage/indexeddb/intversion-open-in-upgradeneeded.html [ Skip ]
+storage/indexeddb/intversion-open-with-version.html [ Skip ] # INTMAX exposed to script as database version
+storage/indexeddb/intversion-pending-version-changes-ascending.html [ Skip ]
+storage/indexeddb/intversion-pending-version-changes-descending.html [ Skip ]
+storage/indexeddb/intversion-pending-version-changes-same.html [ Skip ]
+storage/indexeddb/intversion-two-opens-no-versions.html [ Skip ] # INTMAX exposed to script as database version
+storage/indexeddb/intversion-upgrades.html [ Skip ]
+storage/indexeddb/key-generator.html [ Skip ]
+storage/indexeddb/key-type-binary.html [ Skip ]
+storage/indexeddb/lazy-index-population.html [ Skip ]
+storage/indexeddb/metadata.html [ Skip ]
+storage/indexeddb/noblobs.html [ Skip ] # Missing DRT file/blob support
+storage/indexeddb/objectstore-autoincrement.html [ Skip ]
+storage/indexeddb/objectstore-basics.html [ Skip ]
+storage/indexeddb/objectstore-keycursor.html [ Skip ]
+storage/indexeddb/odd-strings.html [ Skip ]
+storage/indexeddb/optional-arguments.html [ Skip ]
+storage/indexeddb/persistence.html [ Skip ]
+storage/indexeddb/request-leak.html [ Skip ] # Missing WKTR support? GC?
+storage/indexeddb/setversion-blocked-by-versionchange-close.html [ Skip ]
+storage/indexeddb/setversion-not-blocked.html [ Skip ]
+storage/indexeddb/structured-clone.html [ Skip ] # Missing DRT file/blob support
+storage/indexeddb/transaction-and-objectstore-calls.html [ Skip ]
+storage/indexeddb/transaction-error.html [ Skip ]
+storage/indexeddb/transaction-scope-sequencing.html [ Skip ]
+
+# Blink tests that crash the WebProcess.
+storage/indexeddb/cursor-cast.html [ Skip ]
+
+# We don't currently support indexeddb in workers
+storage/indexeddb/basics-workers.html [ Skip ]
+storage/indexeddb/cursor-advance-workers.html [ Skip ]
+storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers.html [ Skip ]
+storage/indexeddb/dont-commit-on-blocked.html [ Skip ]
+storage/indexeddb/factory-basics-workers.html [ Skip ]
+storage/indexeddb/index-basics-workers.html [ Skip ]
+storage/indexeddb/objectstore-basics-workers.html [ Skip ]
+storage/indexeddb/open-twice-workers.html [ Skip ]
+storage/indexeddb/pending-activity-workers.html [ Skip ]
+storage/indexeddb/pending-version-change-on-exit.html [ Skip ]
+storage/indexeddb/pending-version-change-stuck-works-with-terminate.html [ Skip ]
+storage/indexeddb/pending-version-change-stuck.html [ Skip ]
+storage/indexeddb/transaction-complete-workers.html [ Skip ]
+storage/indexeddb/unprefix-workers.html [ Skip ]
+http/tests/security/cross-origin-worker-indexeddb-allowed.html [ Skip ]
+http/tests/security/cross-origin-worker-indexeddb.html [ Skip ]
+
webkit.org/b/87661 crypto/subtle/rsa-indexeddb.html [ Skip ]
-webkit.org/b/87661 fast/history/page-cache-indexed-closed-db.html [ Skip ]
-webkit.org/b/87661 fast/history/page-cache-indexed-opened-db.html [ Skip ]
+storage/indexeddb/database-odd-names.html [ Skip ]
#////////////////////////////////////////////////////////////////////////////////////////
# TESTS EXPECTED TO FAIL
Modified: trunk/Source/WebKit2/ChangeLog (187595 => 187596)
--- trunk/Source/WebKit2/ChangeLog 2015-07-30 18:39:42 UTC (rev 187595)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-30 18:47:37 UTC (rev 187596)
@@ -1,3 +1,21 @@
+2015-07-30 Joonghun Park <jh718.p...@samsung.com>
+
+ [EFL] Enable IndexedDB based on DatabaseProcess
+ https://bugs.webkit.org/show_bug.cgi?id=147221
+
+ Reviewed by Csaba Osztrogonác.
+
+ * DatabaseProcess/efl/DatabaseProcessMainEfl.cpp: Add ecore_init().
+ Without this call, it leads to crash when launching DatabaseProcess.
+ * PlatformEfl.cmake: Add missing include_directory.
+ * Shared/efl/ProcessExecutablePathEfl.cpp:
+ (WebKit::executablePathOfDatabaseProcess):
+ * UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
+ (WebKit::ProcessLauncher::launchProcess):
+ * UIProcess/efl/WebProcessPoolEfl.cpp:
+ (WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory):
+ Add default path for indexedDB sqlite3 db file.
+
2015-07-30 Chris Dumez <cdu...@apple.com>
Minimize children vector capacity changes in PlatformCALayerRemote::recursiveBuildTransaction()
Modified: trunk/Source/WebKit2/DatabaseProcess/efl/DatabaseProcessMainEfl.cpp (187595 => 187596)
--- trunk/Source/WebKit2/DatabaseProcess/efl/DatabaseProcessMainEfl.cpp 2015-07-30 18:39:42 UTC (rev 187595)
+++ trunk/Source/WebKit2/DatabaseProcess/efl/DatabaseProcessMainEfl.cpp 2015-07-30 18:47:37 UTC (rev 187596)
@@ -39,8 +39,16 @@
public:
bool platformInitialize() override
{
+ if (!ecore_init())
+ return false;
+
return true;
}
+
+ void platformFinalize() override
+ {
+ ecore_shutdown();
+ }
};
int DatabaseProcessMainUnix(int argc, char** argv)
Modified: trunk/Source/WebKit2/PlatformEfl.cmake (187595 => 187596)
--- trunk/Source/WebKit2/PlatformEfl.cmake 2015-07-30 18:39:42 UTC (rev 187595)
+++ trunk/Source/WebKit2/PlatformEfl.cmake 2015-07-30 18:47:37 UTC (rev 187596)
@@ -251,6 +251,7 @@
"${WEBKIT2_DIR}/Shared/Downloads/soup"
"${WEBKIT2_DIR}/Shared/Network/CustomProtocols/soup"
"${WEBKIT2_DIR}/Shared/Plugins/unix"
+ "${WEBKIT2_DIR}/Shared/glib"
"${WEBKIT2_DIR}/Shared/efl"
"${WEBKIT2_DIR}/Shared/soup"
"${WEBKIT2_DIR}/Shared/unix"
@@ -506,6 +507,7 @@
-DWEBPROCESSNAME=\"WebProcess\"
-DPLUGINPROCESSNAME=\"PluginProcess\"
-DNETWORKPROCESSNAME=\"NetworkProcess\"
+ -DDATABASEPROCESSNAME=\"DatabaseProcess\"
-DEXTENSIONMANAGERNAME=\"libewebkit_extension_manager.so\"
-DGTEST_HAS_RTTI=0
)
Modified: trunk/Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp (187595 => 187596)
--- trunk/Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp 2015-07-30 18:39:42 UTC (rev 187595)
+++ trunk/Source/WebKit2/Shared/efl/ProcessExecutablePathEfl.cpp 2015-07-30 18:47:37 UTC (rev 187596)
@@ -90,4 +90,13 @@
}
#endif
+#if ENABLE(DATABASE_PROCESS)
+String executablePathOfDatabaseProcess()
+{
+ static NeverDestroyed<const String> webkitDatabaseProcessName(findProcessPath(DATABASEPROCESSNAME));
+
+ return webkitDatabaseProcessName;
+}
+#endif
+
} // namespace WebKit
Modified: trunk/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp (187595 => 187596)
--- trunk/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp 2015-07-30 18:39:42 UTC (rev 187595)
+++ trunk/Source/WebKit2/UIProcess/Launcher/efl/ProcessLauncherEfl.cpp 2015-07-30 18:47:37 UTC (rev 187596)
@@ -89,6 +89,11 @@
executablePath = executablePathOfNetworkProcess();
break;
#endif
+#if ENABLE(DATABASE_PROCESS)
+ case DatabaseProcess:
+ executablePath = executablePathOfDatabaseProcess();
+ break;
+#endif
default:
ASSERT_NOT_REACHED();
return;
Modified: trunk/Source/WebKit2/UIProcess/efl/WebProcessPoolEfl.cpp (187595 => 187596)
--- trunk/Source/WebKit2/UIProcess/efl/WebProcessPoolEfl.cpp 2015-07-30 18:39:42 UTC (rev 187595)
+++ trunk/Source/WebKit2/UIProcess/efl/WebProcessPoolEfl.cpp 2015-07-30 18:47:37 UTC (rev 187596)
@@ -109,8 +109,7 @@
String WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory()
{
- notImplemented();
- return String();
+ return String::fromUTF8(efreet_data_home_get()) + "/WebKitEfl/IndexedDB";
}
String WebProcessPool::platformDefaultIconDatabasePath() const
Modified: trunk/Source/cmake/OptionsEfl.cmake (187595 => 187596)
--- trunk/Source/cmake/OptionsEfl.cmake 2015-07-30 18:39:42 UTC (rev 187595)
+++ trunk/Source/cmake/OptionsEfl.cmake 2015-07-30 18:47:37 UTC (rev 187596)
@@ -79,6 +79,7 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SCROLL_SNAP PUBLIC OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CUSTOM_SCHEME_HANDLER PUBLIC ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATABASE_PROCESS PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATALIST_ELEMENT PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DOM4_EVENTS_CONSTRUCTOR PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DOWNLOAD_ATTRIBUTE PUBLIC ON)
@@ -91,7 +92,7 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GAMEPAD_DEPRECATED PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GEOLOCATION PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE_IN_WORKERS PUBLIC OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE PUBLIC OFF)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INDEXED_DATABASE PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_INPUT_TYPE_COLOR PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LINK_PREFETCH PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_CAPTURE PUBLIC ON)
Modified: trunk/Tools/ChangeLog (187595 => 187596)
--- trunk/Tools/ChangeLog 2015-07-30 18:39:42 UTC (rev 187595)
+++ trunk/Tools/ChangeLog 2015-07-30 18:47:37 UTC (rev 187596)
@@ -1,3 +1,12 @@
+2015-07-30 Joonghun Park <jh718.p...@samsung.com>
+
+ [EFL] Enable IndexedDB based on DatabaseProcess
+ https://bugs.webkit.org/show_bug.cgi?id=147221
+
+ Reviewed by Csaba Osztrogonác.
+
+ * Scripts/webkitperl/FeatureList.pm:
+
2015-07-30 Alex Christensen <achristen...@webkit.org>
Build AppleWin port with CMake
Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (187595 => 187596)
--- trunk/Tools/Scripts/webkitperl/FeatureList.pm 2015-07-30 18:39:42 UTC (rev 187595)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm 2015-07-30 18:47:37 UTC (rev 187596)
@@ -264,7 +264,7 @@
define => "ENABLE_ICONDATABASE", default => !isIOSWebKit(), value => \$icondatabaseSupport },
{ option => "indexed-database", desc => "Toggle Indexed Database support",
- define => "ENABLE_INDEXED_DATABASE", default => isGtk(), value => \$indexedDatabaseSupport },
+ define => "ENABLE_INDEXED_DATABASE", default => (isEfl() || isGtk()), value => \$indexedDatabaseSupport },
{ option => "input-speech", desc => "Toggle Input Speech support",
define => "ENABLE_INPUT_SPEECH", default => 0, value => \$inputSpeechSupport },
